These are chat archives for Snaipe/Criterion

25th
Apr 2016
Dominik
@kaidowei
Apr 25 2016 11:59
@Snaipe a coworker asked me, if Criterion supports multithreading? (e.g. he wants to start a server and a client in one test and let them do stuff)
Franklin Mathieu
@Snaipe
Apr 25 2016 14:12
@kaidowei well, yes
A test is a sandboxed process, you can do whatever you want in it
Dominik
@kaidowei
Apr 25 2016 14:13
he said, that fork doesn't work
[ERR ] Could not link back the event PID to the active workers.
[ERR ] The event pipe might have been corrupted.
Franklin Mathieu
@Snaipe
Apr 25 2016 14:13
fork and threads doesn't mix well, but I never fork inside a child process
I guess that what happens here is that a large quantity of data gets sent
i.e. more than the pipe buffer
so the message back to the runner isn't atomic anymore
Dominik
@kaidowei
Apr 25 2016 14:15
so again, he has to provide custom messages?
Franklin Mathieu
@Snaipe
Apr 25 2016 14:15
is he running on linux? Tell him to try it with bleeding -- it should work
yes
until 2.3.0 hits, sending packets to the runner with a size of > 4096 is unsupported
Dominik
@kaidowei
Apr 25 2016 14:16
hmm bleeding is no option, otherwise the automatic builds will fail...
okay, I'll investigate. Thanks!
Franklin Mathieu
@Snaipe
Apr 25 2016 14:17
ah, I guess you're running some tests on windows, right?
Because otherwise the linux/os x side should be quite stable
Dominik
@kaidowei
Apr 25 2016 14:42
no, but "we" don't want unstable software (company policy)
and our automatic builds use version 2.2.1
Franklin Mathieu
@Snaipe
Apr 25 2016 14:43
right, that's understandable
although, when I fix the issues on the windows side, before I release 2.3.0, I would appreciate if you could test bleeding locally to be sure I'm not releasing anything with flagrant failure points
(though there is a fair chance that everything will go alright since all tests are reporting OK, but we're never sure with huge refactors like this)
Dominik
@kaidowei
Apr 25 2016 14:45
sure, I can do that :)