These are chat archives for Snaipe/Criterion

25th
Oct 2016
Masayuki Nagamachi
@masnagam
Oct 25 2016 02:38
Hi,
Would you like me to register an issue to GitHub issues before sending a pull request?
I have found an issue in a cmake file, and MasayukiNagamachi/Criterion@4fd6fbd.
Franklin Mathieu
@Snaipe
Oct 25 2016 07:45
@MasayukiNagamachi As long as you describe the issue fully and what the patch addresses in your PR, I don't mind
Franklin Mathieu
@Snaipe
Oct 25 2016 07:55
From what I'm collecting from your script above, the issue is that the path to dependencies are relative to the root source directory, not the submodule one, right?