Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 13 21:29
    kugel- commented #172
  • Nov 13 20:49
    Snaipe commented #312
  • Nov 13 20:29
    Snaipe labeled #313
  • Nov 13 20:29
    Snaipe labeled #313
  • Nov 13 20:29
    Snaipe labeled #313
  • Nov 13 20:29
    Snaipe opened #313
  • Nov 13 20:26
    Snaipe commented #172
  • Nov 13 15:12
    kugel- commented #172
  • Nov 11 17:41
    jonathanturcotte commented #312
  • Nov 06 16:25
    jonathanturcotte commented #312
  • Nov 06 16:12
    jonathanturcotte commented #312
  • Nov 06 15:56
    Snaipe commented #312
  • Nov 06 15:48
    jonathanturcotte commented #312
  • Nov 06 12:31
    Snaipe commented #312
  • Nov 05 23:41
    jonathanturcotte opened #312
  • Nov 04 18:20
    Snaipe commented #310
  • Nov 04 18:01
    am11 commented on 81982a2
  • Nov 04 11:57
    Snaipe labeled #311
  • Nov 04 11:57
    Snaipe labeled #311
  • Nov 04 11:57
    Snaipe labeled #311
Franklin Mathieu
@Snaipe
Ah, yes, there isn't a --client yet.
and --server is actually called --wait
oh right, I remember why
--wait runs the tests on the current runner and waits for external clients
Dominik
@kaidowei
where is the current option parsing done?
Franklin Mathieu
@Snaipe
src/entry/params.c
you'll need to add an url field to criterion_options too
Dominik
@kaidowei
okay. Anything else I should know?
Franklin Mathieu
@Snaipe
I think a good starting point would be in src/core/runner.c, where the bind_server happens
you'll need to change bind_server and connect_client (defined in src/protocol/connect.c) to take in a (possibly NULL) nanomsg url
(if the parameter is NULL, the url should be the one currently generated by sprintf)
and I guess that's all
Dominik
@kaidowei
:+1: is there a deadline?
(e.g. do you need that very soon?)
Franklin Mathieu
@Snaipe
Nope
Dominik
@kaidowei
okay, so no release date scheduled for 2.3?
Franklin Mathieu
@Snaipe
I think this should be post 2.3
Dominik
@kaidowei
ah okay.
Franklin Mathieu
@Snaipe
2.3 has been delayed for a long time, and should be the transition to nanomsg
And while there is no scheduled date for 2.3 because I have limited time to work on criterion, the release should happen ASAP
(i.e. when all issues are cleared on the windows port & my nanomsg patch is merged)
Dominik
@kaidowei
so have you talked to the maintainer?
Franklin Mathieu
@Snaipe
My patch is currently being reviewed, and there are some issues with leaks sometimes
(mostly happenning if a fork happens while another thread is send/recv-ing some data)
We're trying to figure something out
if you want you can follow the progress over at nanomsg/nanomsg#587
Dominik
@kaidowei
thanks
Dominik
@kaidowei
@Snaipe I'm playing around with the xml output of criterion and it seems, that the xml does not contain the duration. Is that correct or am I missing something?
Franklin Mathieu
@Snaipe
let me check
It might be something I've forgotten
or simply something not included in the JUnit XML spec
okay, it was forgotten
there is definitely a "time" attribute
For both "testsuite" and "test" it seems
Dominik
@kaidowei
should I open an issue or create a pullrequest
or do you want to fix it
Franklin Mathieu
@Snaipe
I'm currently working on the fork patch for nanomsg, so go ahead if you want to fix it
just note that the spec says that the time is an integer representing the number of seconds
so you'll need to round to the nearest integer
Dominik
@kaidowei
which (in almost all cases) makes no sense :(
Franklin Mathieu
@Snaipe
yeah, it's a shame
I think the idea was to have more detail in the "timestamp" field
but currently "timestamp" is not an information that is gathered in the stats
actually nevermind, there's no "timestamp_end", so "timestamp" in itself is useless to calculate the time spent
and in any case a timestamp is in seconds
so yeah, it's too bad.
Dominik
@kaidowei
meaning 0.001 is 1ms
Franklin Mathieu
@Snaipe
Oh, then that's perfect
I don't know why I remember it being an integer