Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:44
    rmzelnick opened #309
  • Oct 18 14:45
    he2lec closed #308
  • Oct 18 14:17
    he2lec opened #308
  • Oct 18 07:17
    P-NA-J closed #306
  • Oct 18 07:17
    P-NA-J commented #306
  • Oct 17 17:42
    Snaipe commented #306
  • Oct 17 17:37
    ntuDerekWang closed #307
  • Oct 17 17:37
    ntuDerekWang commented #307
  • Oct 17 17:34
    Snaipe commented #307
  • Oct 17 17:28
    ntuDerekWang edited #307
  • Oct 17 17:28
    ntuDerekWang edited #307
  • Oct 17 17:26
    ntuDerekWang opened #307
  • Oct 17 17:23
    ntuDerekWang closed #305
  • Oct 17 17:23
    ntuDerekWang commented #305
  • Oct 17 07:32
    vincentdupaquis commented #304
  • Oct 16 12:25
    P-NA-J opened #306
  • Oct 14 08:44
    Snaipe commented #304
  • Oct 14 07:41
    vincentdupaquis commented #304
  • Oct 12 17:28
    Snaipe commented #304
  • Oct 12 12:13
    Snaipe commented #304
Franklin Mathieu
@Snaipe
We're trying to figure something out
if you want you can follow the progress over at nanomsg/nanomsg#587
Dominik
@kaidowei
thanks
Dominik
@kaidowei
@Snaipe I'm playing around with the xml output of criterion and it seems, that the xml does not contain the duration. Is that correct or am I missing something?
Franklin Mathieu
@Snaipe
let me check
It might be something I've forgotten
or simply something not included in the JUnit XML spec
okay, it was forgotten
there is definitely a "time" attribute
For both "testsuite" and "test" it seems
Dominik
@kaidowei
should I open an issue or create a pullrequest
or do you want to fix it
Franklin Mathieu
@Snaipe
I'm currently working on the fork patch for nanomsg, so go ahead if you want to fix it
just note that the spec says that the time is an integer representing the number of seconds
so you'll need to round to the nearest integer
Dominik
@kaidowei
which (in almost all cases) makes no sense :(
Franklin Mathieu
@Snaipe
yeah, it's a shame
I think the idea was to have more detail in the "timestamp" field
but currently "timestamp" is not an information that is gathered in the stats
actually nevermind, there's no "timestamp_end", so "timestamp" in itself is useless to calculate the time spent
and in any case a timestamp is in seconds
so yeah, it's too bad.
Dominik
@kaidowei
meaning 0.001 is 1ms
Franklin Mathieu
@Snaipe
Oh, then that's perfect
I don't know why I remember it being an integer
I must have mixed it up with something else
so then round up to the millisecond
in any case it's the only sane measurement accross platforms, as some does not give precision up to nanoseconds
Dominik
@kaidowei
elapsed_time is already in ms?
Franklin Mathieu
@Snaipe
seconds
Dominik
@kaidowei
ah so, I don't have to do anything, cool
Franklin Mathieu
@Snaipe
yep
Dominik
@kaidowei
what does it contain, if the test crashed?
Franklin Mathieu
@Snaipe
0
because nothing gets reported after the crash
I ought to fix this someday
Dominik
@kaidowei
the time for a suite... do I have to calc that or is there already a function somewhere?
Franklin Mathieu
@Snaipe
no, you have to sum all the elapsed_times
Dominik
@kaidowei
best place for that?
Franklin Mathieu
@Snaipe
Dominik
@kaidowei
yeah... are there unittests for the xml io?
Franklin Mathieu
@Snaipe
there are no unit tests, but a bunch of system tests to validate the output in test/cram
if you want to regenerate the new tests outputs, simply call make cram_tests CRAM=-i
Dominik
@kaidowei
pullrequest to master or bleeding?
Franklin Mathieu
@Snaipe
bleeding
I'll roll this out for 2.3.0
Dominik
@kaidowei
are you currently on bleeding?
can you check for me, if the time is accounted correctly?
I have a sleep in my test and the time is still 0.00