Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:44
    rmzelnick opened #309
  • Oct 18 14:45
    he2lec closed #308
  • Oct 18 14:17
    he2lec opened #308
  • Oct 18 07:17
    P-NA-J closed #306
  • Oct 18 07:17
    P-NA-J commented #306
  • Oct 17 17:42
    Snaipe commented #306
  • Oct 17 17:37
    ntuDerekWang closed #307
  • Oct 17 17:37
    ntuDerekWang commented #307
  • Oct 17 17:34
    Snaipe commented #307
  • Oct 17 17:28
    ntuDerekWang edited #307
  • Oct 17 17:28
    ntuDerekWang edited #307
  • Oct 17 17:26
    ntuDerekWang opened #307
  • Oct 17 17:23
    ntuDerekWang closed #305
  • Oct 17 17:23
    ntuDerekWang commented #305
  • Oct 17 07:32
    vincentdupaquis commented #304
  • Oct 16 12:25
    P-NA-J opened #306
  • Oct 14 08:44
    Snaipe commented #304
  • Oct 14 07:41
    vincentdupaquis commented #304
  • Oct 12 17:28
    Snaipe commented #304
  • Oct 12 12:13
    Snaipe commented #304
Franklin Mathieu
@Snaipe
0
because nothing gets reported after the crash
I ought to fix this someday
Dominik
@kaidowei
the time for a suite... do I have to calc that or is there already a function somewhere?
Franklin Mathieu
@Snaipe
no, you have to sum all the elapsed_times
Dominik
@kaidowei
best place for that?
Franklin Mathieu
@Snaipe
Dominik
@kaidowei
yeah... are there unittests for the xml io?
Franklin Mathieu
@Snaipe
there are no unit tests, but a bunch of system tests to validate the output in test/cram
if you want to regenerate the new tests outputs, simply call make cram_tests CRAM=-i
Dominik
@kaidowei
pullrequest to master or bleeding?
Franklin Mathieu
@Snaipe
bleeding
I'll roll this out for 2.3.0
Dominik
@kaidowei
are you currently on bleeding?
can you check for me, if the time is accounted correctly?
I have a sleep in my test and the time is still 0.00
with 2.2.1 it works
Franklin Mathieu
@Snaipe
mmh, right. Times aren't reported on bleeding for some reason
let me investigate
oh, right, I remember why
that's because the protocol started working with timestamps rather than elapsed times
and currently timestamps aren't implemented
I ought to make an issue so I don't forget
Dominik
@kaidowei
can you elaborate on the cram tests? can't get them to run
Franklin Mathieu
@Snaipe
they run alongside everything else when running ctest
if ctest does nothing, then you probably have to run cmake -DCTESTS=ON -DDEV_BUILD=ON .. from your build directory
Dominik
@kaidowei
ah, I don't know cmake, so I didn't know about ctest
they're running now
where can I see the results of the cram test?
it just says, it failed
Franklin Mathieu
@Snaipe
oh, right, I'm assuming you don't have cram installed on your system
install cram 0.6 with sudo pip install cram==0.6 (or with --user if you don't want to install it in /usr)
Dominik
@kaidowei
I have... if I remember correctly, we had this conversation some time ago
Franklin Mathieu
@Snaipe
okay
in doubt, run make cram_tests
and to troubleshoot with ctest, you need to pass it an option
let me check which one
--output-on-failure
Dominik
@kaidowei
[100%] Built target criterion_samples
CMake Error at /*beep*/Criterion/.cmake/Modules/Cram.cmake:66 (message):
  Cram tests failed


make[3]: *** [cram_tests] Error 1
make[2]: *** [test/CMakeFiles/cram_tests.dir/all] Error 2
make[1]: *** [test/CMakeFiles/cram_tests.dir/rule] Error 2
make: *** [cram_tests] Error 2
Franklin Mathieu
@Snaipe
huh.
let me check on my end
oh, it's a bug in the cmake module, somehow
try export PYTHON_BIN=python3
and re-run the tests
I'll push a fix to address the case where PYTHON_BIN isn't set
Dominik
@kaidowei
yeah, works
Dominik
@kaidowei
mkay, did my part :)
Franklin Mathieu
@Snaipe
Thanks!
Dominik
@kaidowei
uuuh, just noticed, that the locale print sometimes prints "0,05" instead of "0.05"
do you think, xml parsers mind?