Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 11:46
    risaldar closed #356
  • Oct 15 06:49
    khuang0312 edited #362
  • Oct 15 06:46
    khuang0312 edited #362
  • Oct 15 06:45
    khuang0312 edited #362
  • Oct 15 06:45
    khuang0312 opened #362
  • Oct 06 22:59
    Eazhi synchronize #361
  • Oct 06 22:55
    Eazhi synchronize #361
  • Oct 05 14:36
    utybo commented #229
  • Oct 04 00:57
    Eazhi synchronize #361
  • Oct 04 00:54
    Eazhi synchronize #361
  • Oct 04 00:44
    Eazhi opened #361
  • Oct 02 14:29
    zbeaoce opened #360
  • Oct 01 23:29
    paul000001 closed #358
  • Sep 16 19:51
    stef commented #221
  • Sep 04 21:11
    yesudeep opened #359
  • Aug 22 13:29
    paul000001 commented #358
  • Aug 15 06:37
    Snaipe closed #349
  • Aug 15 06:37
    Snaipe commented #349
  • Aug 15 06:28
    Snaipe commented #358
  • Aug 13 23:43
    paul000001 commented #358
Dominik
@kaidowei
can you elaborate on the cram tests? can't get them to run
Franklin Mathieu
@Snaipe
they run alongside everything else when running ctest
if ctest does nothing, then you probably have to run cmake -DCTESTS=ON -DDEV_BUILD=ON .. from your build directory
Dominik
@kaidowei
ah, I don't know cmake, so I didn't know about ctest
they're running now
where can I see the results of the cram test?
it just says, it failed
Franklin Mathieu
@Snaipe
oh, right, I'm assuming you don't have cram installed on your system
install cram 0.6 with sudo pip install cram==0.6 (or with --user if you don't want to install it in /usr)
Dominik
@kaidowei
I have... if I remember correctly, we had this conversation some time ago
Franklin Mathieu
@Snaipe
okay
in doubt, run make cram_tests
and to troubleshoot with ctest, you need to pass it an option
let me check which one
--output-on-failure
Dominik
@kaidowei
[100%] Built target criterion_samples
CMake Error at /*beep*/Criterion/.cmake/Modules/Cram.cmake:66 (message):
  Cram tests failed


make[3]: *** [cram_tests] Error 1
make[2]: *** [test/CMakeFiles/cram_tests.dir/all] Error 2
make[1]: *** [test/CMakeFiles/cram_tests.dir/rule] Error 2
make: *** [cram_tests] Error 2
Franklin Mathieu
@Snaipe
huh.
let me check on my end
oh, it's a bug in the cmake module, somehow
try export PYTHON_BIN=python3
and re-run the tests
I'll push a fix to address the case where PYTHON_BIN isn't set
Dominik
@kaidowei
yeah, works
Dominik
@kaidowei
mkay, did my part :)
Franklin Mathieu
@Snaipe
Thanks!
Dominik
@kaidowei
uuuh, just noticed, that the locale print sometimes prints "0,05" instead of "0.05"
do you think, xml parsers mind?
Franklin Mathieu
@Snaipe
oh, right
Dominik
@kaidowei
damn it
Franklin Mathieu
@Snaipe
well, according to the standard, xs:decimal needs a dot
actually, let me rephrase: the internet is telling me that the standard says that it needs a dot
Let me check for sure
so how do we fix that?
Franklin Mathieu
@Snaipe
well, you could swap the locale, but you'll have to restore it afterwards
Dominik
@kaidowei
that really stinks...
how did you do that for the other output providers?
Franklin Mathieu
@Snaipe
Other output providers doesn't have this restriction
and I didn't have any floats to print anyway, so that's why
Dominik
@kaidowei
that's not entirely true, the --tap option also prints floats
Franklin Mathieu
@Snaipe
I guess the cleanest way (as in, reusable for other output providers) would be to implement a compatibility function for this
yes, but tap doesn't have the restriction, iirc the time is part of a comment string
so using the locale here is the right thing to do
Dominik
@kaidowei
okay...
the jenkins tap parser had problems finding the time, but I guess that is a problem of the tap-format
(and the locale, maybe)
Franklin Mathieu
@Snaipe
this is precisely why I'm not testing the timestamps in cram
because the way to print time just isn't consistent
Dominik
@kaidowei
so the xml.t should be removed? (which is also not a good thing)