Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 23 16:53
    rmzelnick commented #309
  • Oct 23 16:53
    rmzelnick commented #309
  • Oct 23 14:46
    Snaipe commented #309
  • Oct 23 13:17
    rmzelnick commented #309
  • Oct 23 11:54
    Snaipe commented #309
  • Oct 23 02:46
    rmzelnick commented #309
  • Oct 23 02:44
    rmzelnick commented #309
  • Oct 23 02:36
    rmzelnick commented #309
  • Oct 23 02:36
    rmzelnick commented #309
  • Oct 23 02:28
    rmzelnick commented #309
  • Oct 23 02:25
    rmzelnick commented #309
  • Oct 23 02:24
    rmzelnick commented #309
  • Oct 23 02:08
    rmzelnick reopened #309
  • Oct 23 02:08
    rmzelnick commented #309
  • Oct 23 02:08
    rmzelnick closed #309
  • Oct 23 02:08
    rmzelnick commented #309
  • Oct 23 02:01
    rmzelnick commented #309
  • Oct 23 01:51
    rmzelnick commented #309
  • Oct 22 10:11
    am11 commented #309
  • Oct 22 09:48
    Snaipe commented #309
Franklin Mathieu
@Snaipe
and re-run the tests
I'll push a fix to address the case where PYTHON_BIN isn't set
Dominik
@kaidowei
yeah, works
Dominik
@kaidowei
mkay, did my part :)
Franklin Mathieu
@Snaipe
Thanks!
Dominik
@kaidowei
uuuh, just noticed, that the locale print sometimes prints "0,05" instead of "0.05"
do you think, xml parsers mind?
Franklin Mathieu
@Snaipe
oh, right
Dominik
@kaidowei
damn it
Franklin Mathieu
@Snaipe
well, according to the standard, xs:decimal needs a dot
actually, let me rephrase: the internet is telling me that the standard says that it needs a dot
Let me check for sure
yep, it's a dot: http://docstore.mik.ua/orelly/xml/schema/ch16_01.htm#ch16-77036
Dominik
@kaidowei
http://stackoverflow.com/questions/7684014/c-printf-with-f-but-localized-for-the-users-country
so how do we fix that?
Franklin Mathieu
@Snaipe
well, you could swap the locale, but you'll have to restore it afterwards
Dominik
@kaidowei
that really stinks...
how did you do that for the other output providers?
Franklin Mathieu
@Snaipe
Other output providers doesn't have this restriction
and I didn't have any floats to print anyway, so that's why
Dominik
@kaidowei
that's not entirely true, the --tap option also prints floats
Franklin Mathieu
@Snaipe
I guess the cleanest way (as in, reusable for other output providers) would be to implement a compatibility function for this
yes, but tap doesn't have the restriction, iirc the time is part of a comment string
so using the locale here is the right thing to do
Dominik
@kaidowei
okay...
the jenkins tap parser had problems finding the time, but I guess that is a problem of the tap-format
(and the locale, maybe)
Franklin Mathieu
@Snaipe
this is precisely why I'm not testing the timestamps in cram
because the way to print time just isn't consistent
Dominik
@kaidowei
so the xml.t should be removed? (which is also not a good thing)
Franklin Mathieu
@Snaipe
no, but xml.t will probably not have time measurements anyway
I mean, time is disabled for tests because you can't really compare two times textually
well, you can, but I mean it's not reliable
because one test might take 1ms to complete one time, and 2ms the other time
Dominik
@kaidowei
okay... amend this pull request or make another one?
Franklin Mathieu
@Snaipe
whatever you want, although amending should be simpler for you
Although, its a shame because cram is supposed to support regexp matches on the output
but I haven't been able to get it to work with ANSI escape codes
Dominik
@kaidowei
yes. but in this case, we need a dot anyway :)
Franklin Mathieu
@Snaipe
right
Aaah, it is possible to swap locales, nice
Dominik
@kaidowei
you mean setlocale or something different?
Franklin Mathieu
@Snaipe
yeah, I didn't know setlocale with NULL gave the current value back
so you should be able to make a locale-specific printf or something of that flavor
Dominik
@kaidowei
static CR_INLINE or static INLINE
you're using both in the xml file
Franklin Mathieu
@Snaipe
you can use both, but INLINE is preferred as it's for internal use
Dominik
@kaidowei
so I'll change static CR_INLINE ?
Franklin Mathieu
@Snaipe
sure, go ahead
Dominik
@kaidowei
so, I updated the commit (which was not that easy, if you only used svn all the time :p)