Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 14 11:21

    Snaipe on bleeding

    log: Fix crash in `cr_log_info(… (compare)

  • Jan 14 11:21
    Snaipe closed #370
  • Jan 14 11:21
    Snaipe closed #311
  • Jan 14 00:58
    khuang0312 closed #362
  • Jan 12 18:59
    Ersikan commented #370
  • Jan 12 18:58
    Ersikan synchronize #370
  • Jan 12 17:40
    qpages closed #371
  • Jan 12 17:24
    qpages opened #371
  • Jan 12 00:52
    Ersikan opened #370
  • Jan 11 15:42
    Snaipe commented #350
  • Jan 11 15:39
    Snaipe commented #357
  • Jan 11 15:38
    Snaipe commented #359
  • Jan 11 15:38
    Snaipe labeled #359
  • Jan 11 15:35
    Snaipe commented #362
  • Jan 11 15:33
    Snaipe closed #363
  • Jan 11 15:33
    Snaipe commented #367
  • Jan 11 15:28

    Snaipe on bleeding

    xml: Fix escape of special char… (compare)

  • Jan 11 15:28
    Snaipe closed #361
  • Jan 11 15:28
    Snaipe commented #361
  • Jan 11 15:27

    Snaipe on bleeding

    autotools: use PKG_CHECK_MODULE… autotools: use substitued PKG_C… autotools: use TEST_LOG_DRIVER and 3 more (compare)

Dominik
@kaidowei
so how do we fix that?
Franklin Mathieu
@Snaipe
well, you could swap the locale, but you'll have to restore it afterwards
Dominik
@kaidowei
that really stinks...
how did you do that for the other output providers?
Franklin Mathieu
@Snaipe
Other output providers doesn't have this restriction
and I didn't have any floats to print anyway, so that's why
Dominik
@kaidowei
that's not entirely true, the --tap option also prints floats
Franklin Mathieu
@Snaipe
I guess the cleanest way (as in, reusable for other output providers) would be to implement a compatibility function for this
yes, but tap doesn't have the restriction, iirc the time is part of a comment string
so using the locale here is the right thing to do
Dominik
@kaidowei
okay...
the jenkins tap parser had problems finding the time, but I guess that is a problem of the tap-format
(and the locale, maybe)
Franklin Mathieu
@Snaipe
this is precisely why I'm not testing the timestamps in cram
because the way to print time just isn't consistent
Dominik
@kaidowei
so the xml.t should be removed? (which is also not a good thing)
Franklin Mathieu
@Snaipe
no, but xml.t will probably not have time measurements anyway
I mean, time is disabled for tests because you can't really compare two times textually
well, you can, but I mean it's not reliable
because one test might take 1ms to complete one time, and 2ms the other time
Dominik
@kaidowei
okay... amend this pull request or make another one?
Franklin Mathieu
@Snaipe
whatever you want, although amending should be simpler for you
Although, its a shame because cram is supposed to support regexp matches on the output
but I haven't been able to get it to work with ANSI escape codes
Dominik
@kaidowei
yes. but in this case, we need a dot anyway :)
Franklin Mathieu
@Snaipe
right
Aaah, it is possible to swap locales, nice
Dominik
@kaidowei
you mean setlocale or something different?
Franklin Mathieu
@Snaipe
yeah, I didn't know setlocale with NULL gave the current value back
so you should be able to make a locale-specific printf or something of that flavor
Dominik
@kaidowei
static CR_INLINE or static INLINE
you're using both in the xml file
Franklin Mathieu
@Snaipe
you can use both, but INLINE is preferred as it's for internal use
Dominik
@kaidowei
so I'll change static CR_INLINE ?
Franklin Mathieu
@Snaipe
sure, go ahead
Dominik
@kaidowei
so, I updated the commit (which was not that easy, if you only used svn all the time :p)
is the pullrequest updated automatically?
Franklin Mathieu
@Snaipe
yes, the PR mirrors your remote branch
Dominik
@kaidowei
nice
Franklin Mathieu
@Snaipe
I commented on your PR
Appart from the two points mentionned, it looks good
Dominik
@kaidowei
...
g option is not that cool
<testcase name="cmm___item_create" assertions="6" status="PASSED" time="6.03e-05">
Franklin Mathieu
@Snaipe
ugh, I forgot that it added exponents
Dominik
@kaidowei
meh, btw. exponents are forbidden in xs:decimal :(
Franklin Mathieu
@Snaipe
I thought so, but I'm trying to see if there's a way to not have trailing zeroes with %f
and it seems that it's not possible
Dominik
@kaidowei
but I think that's not a problem...
Franklin Mathieu
@Snaipe
so screw it, I'll allow the use of %.3f