Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 19 16:41
    SDAChess commented #376
  • Feb 19 16:10
    SDAChess commented #376
  • Feb 19 16:08
    SDAChess commented #376
  • Feb 19 15:24
    SDAChess opened #376
  • Feb 07 15:40
    borjasotomayor commented #301
  • Feb 06 18:44
    Sombre0mbre opened #375
  • Feb 05 20:49
    xfbs opened #374
  • Feb 04 10:04
    MrAnno edited #301
  • Feb 04 09:59
    MrAnno commented #301
  • Jan 29 20:16
    HugoGDRM commented #223
  • Jan 27 21:01
    abkarcher closed #373
  • Jan 27 21:01
    abkarcher commented #373
  • Jan 27 20:31
    Snaipe commented #373
  • Jan 27 20:31
    abkarcher edited #373
  • Jan 27 20:30
    abkarcher edited #373
  • Jan 27 19:57
    abkarcher opened #373
  • Jan 27 04:39
    aolia-0303 opened #372
  • Jan 14 11:21

    Snaipe on bleeding

    log: Fix crash in `cr_log_info(… (compare)

  • Jan 14 11:21
    Snaipe closed #370
  • Jan 14 11:21
    Snaipe closed #311
Franklin Mathieu
@Snaipe
so using the locale here is the right thing to do
Dominik
@kaidowei
okay...
the jenkins tap parser had problems finding the time, but I guess that is a problem of the tap-format
(and the locale, maybe)
Franklin Mathieu
@Snaipe
this is precisely why I'm not testing the timestamps in cram
because the way to print time just isn't consistent
Dominik
@kaidowei
so the xml.t should be removed? (which is also not a good thing)
Franklin Mathieu
@Snaipe
no, but xml.t will probably not have time measurements anyway
I mean, time is disabled for tests because you can't really compare two times textually
well, you can, but I mean it's not reliable
because one test might take 1ms to complete one time, and 2ms the other time
Dominik
@kaidowei
okay... amend this pull request or make another one?
Franklin Mathieu
@Snaipe
whatever you want, although amending should be simpler for you
Although, its a shame because cram is supposed to support regexp matches on the output
but I haven't been able to get it to work with ANSI escape codes
Dominik
@kaidowei
yes. but in this case, we need a dot anyway :)
Franklin Mathieu
@Snaipe
right
Aaah, it is possible to swap locales, nice
Dominik
@kaidowei
you mean setlocale or something different?
Franklin Mathieu
@Snaipe
yeah, I didn't know setlocale with NULL gave the current value back
so you should be able to make a locale-specific printf or something of that flavor
Dominik
@kaidowei
static CR_INLINE or static INLINE
you're using both in the xml file
Franklin Mathieu
@Snaipe
you can use both, but INLINE is preferred as it's for internal use
Dominik
@kaidowei
so I'll change static CR_INLINE ?
Franklin Mathieu
@Snaipe
sure, go ahead
Dominik
@kaidowei
so, I updated the commit (which was not that easy, if you only used svn all the time :p)
is the pullrequest updated automatically?
Franklin Mathieu
@Snaipe
yes, the PR mirrors your remote branch
Dominik
@kaidowei
nice
Franklin Mathieu
@Snaipe
I commented on your PR
Appart from the two points mentionned, it looks good
Dominik
@kaidowei
...
g option is not that cool
<testcase name="cmm___item_create" assertions="6" status="PASSED" time="6.03e-05">
Franklin Mathieu
@Snaipe
ugh, I forgot that it added exponents
Dominik
@kaidowei
meh, btw. exponents are forbidden in xs:decimal :(
Franklin Mathieu
@Snaipe
I thought so, but I'm trying to see if there's a way to not have trailing zeroes with %f
and it seems that it's not possible
Dominik
@kaidowei
but I think that's not a problem...
Franklin Mathieu
@Snaipe
so screw it, I'll allow the use of %.3f
Dominik
@kaidowei
or I'll do round(time * 1000) / 1000.0 and %f
Franklin Mathieu
@Snaipe
sure
Dominik
@kaidowei
better?
Franklin Mathieu
@Snaipe
also, is there a reason why this line is using fprintf_locale ?
Dominik
@kaidowei
because the suite also has a time
entry
Franklin Mathieu
@Snaipe
right, but the line I linked doesn't
(L164)
I think you meant to change L141