Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 19 18:12
    Snaipe commented #287
  • Sep 19 18:11
    Snaipe commented #287
  • Sep 14 16:25
    Snaipe commented #301
  • Sep 13 19:26
    Snaipe commented #302
  • Sep 13 19:21
    Snaipe commented #302
  • Sep 13 17:36
    MrAnno commented #301
  • Sep 13 17:35
    MrAnno commented #301
  • Sep 13 15:28
    kugel- commented #302
  • Sep 13 15:26
    kugel- commented #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe assigned #302
  • Sep 13 15:14
    Snaipe opened #302
  • Sep 13 14:55

    Snaipe on actions

    ci: setup basic actions yaml (compare)

  • Sep 11 08:33
    MrAnno opened #301
  • Sep 03 18:13
    Fumesover closed #300
  • Sep 03 18:13
    Fumesover commented #300
  • Sep 03 18:02
    Fumesover edited #300
  • Sep 03 18:02
    Fumesover edited #300
Dominik
@kaidowei
okay... amend this pull request or make another one?
Franklin Mathieu
@Snaipe
whatever you want, although amending should be simpler for you
Although, its a shame because cram is supposed to support regexp matches on the output
but I haven't been able to get it to work with ANSI escape codes
Dominik
@kaidowei
yes. but in this case, we need a dot anyway :)
Franklin Mathieu
@Snaipe
right
Aaah, it is possible to swap locales, nice
Dominik
@kaidowei
you mean setlocale or something different?
Franklin Mathieu
@Snaipe
yeah, I didn't know setlocale with NULL gave the current value back
so you should be able to make a locale-specific printf or something of that flavor
Dominik
@kaidowei
static CR_INLINE or static INLINE
you're using both in the xml file
Franklin Mathieu
@Snaipe
you can use both, but INLINE is preferred as it's for internal use
Dominik
@kaidowei
so I'll change static CR_INLINE ?
Franklin Mathieu
@Snaipe
sure, go ahead
Dominik
@kaidowei
so, I updated the commit (which was not that easy, if you only used svn all the time :p)
is the pullrequest updated automatically?
Franklin Mathieu
@Snaipe
yes, the PR mirrors your remote branch
Dominik
@kaidowei
nice
Franklin Mathieu
@Snaipe
I commented on your PR
Appart from the two points mentionned, it looks good
Dominik
@kaidowei
...
g option is not that cool
<testcase name="cmm___item_create" assertions="6" status="PASSED" time="6.03e-05">
Franklin Mathieu
@Snaipe
ugh, I forgot that it added exponents
Dominik
@kaidowei
meh, btw. exponents are forbidden in xs:decimal :(
Franklin Mathieu
@Snaipe
I thought so, but I'm trying to see if there's a way to not have trailing zeroes with %f
and it seems that it's not possible
Dominik
@kaidowei
but I think that's not a problem...
Franklin Mathieu
@Snaipe
so screw it, I'll allow the use of %.3f
Dominik
@kaidowei
or I'll do round(time * 1000) / 1000.0 and %f
Franklin Mathieu
@Snaipe
sure
Dominik
@kaidowei
better?
Franklin Mathieu
@Snaipe
also, is there a reason why this line is using fprintf_locale ?
Dominik
@kaidowei
because the suite also has a time
entry
Franklin Mathieu
@Snaipe
right, but the line I linked doesn't
(L164)
I think you meant to change L141
Dominik
@kaidowei
yeah, just saw that github creates an overlay over the line you linked to...
and yes, you're right
so...
rounding or %f?
%.3f I mean
Franklin Mathieu
@Snaipe
%.3f, no need to add more complexity
Dominik
@kaidowei
awesome, just used tap and xml provider in one run... works like a charm.
Franklin Mathieu
@Snaipe
Merged. Thanks for the PR!
Dominik
@kaidowei
you're welcome :)
Dominik
@kaidowei
@Snaipe are you aware of problems with gcov?
I tried compiling our libs with coverage stuff and now criterion crashes: