Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:34
    Snaipe commented #307
  • 17:28
    ntuDerekWang edited #307
  • 17:28
    ntuDerekWang edited #307
  • 17:26
    ntuDerekWang opened #307
  • 17:23
    ntuDerekWang closed #305
  • 17:23
    ntuDerekWang commented #305
  • 07:32
    vincentdupaquis commented #304
  • Oct 16 12:25
    P-NA-J opened #306
  • Oct 14 08:44
    Snaipe commented #304
  • Oct 14 07:41
    vincentdupaquis commented #304
  • Oct 12 17:28
    Snaipe commented #304
  • Oct 12 12:13
    Snaipe commented #304
  • Oct 12 11:43
    Snaipe commented #305
  • Oct 12 00:25
    ntuDerekWang opened #305
  • Oct 09 10:43

    Snaipe on master

    (compare)

  • Oct 09 10:41

    Snaipe on bleeding

    Struct pointer references use -… (compare)

  • Oct 03 16:05
    vincentdupaquis commented #304
  • Oct 02 15:20
    vincentdupaquis commented #304
  • Oct 02 15:19
    Snaipe commented #304
  • Oct 02 14:58
    vincentdupaquis commented #304
Franklin Mathieu
@Snaipe
right
Aaah, it is possible to swap locales, nice
Dominik
@kaidowei
you mean setlocale or something different?
Franklin Mathieu
@Snaipe
yeah, I didn't know setlocale with NULL gave the current value back
so you should be able to make a locale-specific printf or something of that flavor
Dominik
@kaidowei
static CR_INLINE or static INLINE
you're using both in the xml file
Franklin Mathieu
@Snaipe
you can use both, but INLINE is preferred as it's for internal use
Dominik
@kaidowei
so I'll change static CR_INLINE ?
Franklin Mathieu
@Snaipe
sure, go ahead
Dominik
@kaidowei
so, I updated the commit (which was not that easy, if you only used svn all the time :p)
is the pullrequest updated automatically?
Franklin Mathieu
@Snaipe
yes, the PR mirrors your remote branch
Dominik
@kaidowei
nice
Franklin Mathieu
@Snaipe
I commented on your PR
Appart from the two points mentionned, it looks good
Dominik
@kaidowei
...
g option is not that cool
<testcase name="cmm___item_create" assertions="6" status="PASSED" time="6.03e-05">
Franklin Mathieu
@Snaipe
ugh, I forgot that it added exponents
Dominik
@kaidowei
meh, btw. exponents are forbidden in xs:decimal :(
Franklin Mathieu
@Snaipe
I thought so, but I'm trying to see if there's a way to not have trailing zeroes with %f
and it seems that it's not possible
Dominik
@kaidowei
but I think that's not a problem...
Franklin Mathieu
@Snaipe
so screw it, I'll allow the use of %.3f
Dominik
@kaidowei
or I'll do round(time * 1000) / 1000.0 and %f
Franklin Mathieu
@Snaipe
sure
Dominik
@kaidowei
better?
Franklin Mathieu
@Snaipe
also, is there a reason why this line is using fprintf_locale ?
Dominik
@kaidowei
because the suite also has a time
entry
Franklin Mathieu
@Snaipe
right, but the line I linked doesn't
(L164)
I think you meant to change L141
Dominik
@kaidowei
yeah, just saw that github creates an overlay over the line you linked to...
and yes, you're right
so...
rounding or %f?
%.3f I mean
Franklin Mathieu
@Snaipe
%.3f, no need to add more complexity
Dominik
@kaidowei
awesome, just used tap and xml provider in one run... works like a charm.
Franklin Mathieu
@Snaipe
Merged. Thanks for the PR!
Dominik
@kaidowei
you're welcome :)
Dominik
@kaidowei
@Snaipe are you aware of problems with gcov?
I tried compiling our libs with coverage stuff and now criterion crashes:
[----] Warning! The test `chmap::chmap_delete_from_loop_safe` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_delete` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_add` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_create` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_distribution` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_power_of_two` crashed during its setup or teardown.
but only, if I give the --no-early-exit option
Franklin Mathieu
@Snaipe
CI builds with coverage, so I don't see why this is happening
Is this happening on the release?
Dominik
@kaidowei
and I guess it is during teardown, because the results come in normally
yes, 2.2.1