Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 19 18:12
    Snaipe commented #287
  • Sep 19 18:11
    Snaipe commented #287
  • Sep 14 16:25
    Snaipe commented #301
  • Sep 13 19:26
    Snaipe commented #302
  • Sep 13 19:21
    Snaipe commented #302
  • Sep 13 17:36
    MrAnno commented #301
  • Sep 13 17:35
    MrAnno commented #301
  • Sep 13 15:28
    kugel- commented #302
  • Sep 13 15:26
    kugel- commented #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe assigned #302
  • Sep 13 15:14
    Snaipe opened #302
  • Sep 13 14:55

    Snaipe on actions

    ci: setup basic actions yaml (compare)

  • Sep 11 08:33
    MrAnno opened #301
  • Sep 03 18:13
    Fumesover closed #300
  • Sep 03 18:13
    Fumesover commented #300
  • Sep 03 18:02
    Fumesover edited #300
  • Sep 03 18:02
    Fumesover edited #300
Franklin Mathieu
@Snaipe
Appart from the two points mentionned, it looks good
Dominik
@kaidowei
...
g option is not that cool
<testcase name="cmm___item_create" assertions="6" status="PASSED" time="6.03e-05">
Franklin Mathieu
@Snaipe
ugh, I forgot that it added exponents
Dominik
@kaidowei
meh, btw. exponents are forbidden in xs:decimal :(
Franklin Mathieu
@Snaipe
I thought so, but I'm trying to see if there's a way to not have trailing zeroes with %f
and it seems that it's not possible
Dominik
@kaidowei
but I think that's not a problem...
Franklin Mathieu
@Snaipe
so screw it, I'll allow the use of %.3f
Dominik
@kaidowei
or I'll do round(time * 1000) / 1000.0 and %f
Franklin Mathieu
@Snaipe
sure
Dominik
@kaidowei
better?
Franklin Mathieu
@Snaipe
also, is there a reason why this line is using fprintf_locale ?
Dominik
@kaidowei
because the suite also has a time
entry
Franklin Mathieu
@Snaipe
right, but the line I linked doesn't
(L164)
I think you meant to change L141
Dominik
@kaidowei
yeah, just saw that github creates an overlay over the line you linked to...
and yes, you're right
so...
rounding or %f?
%.3f I mean
Franklin Mathieu
@Snaipe
%.3f, no need to add more complexity
Dominik
@kaidowei
awesome, just used tap and xml provider in one run... works like a charm.
Franklin Mathieu
@Snaipe
Merged. Thanks for the PR!
Dominik
@kaidowei
you're welcome :)
Dominik
@kaidowei
@Snaipe are you aware of problems with gcov?
I tried compiling our libs with coverage stuff and now criterion crashes:
[----] Warning! The test `chmap::chmap_delete_from_loop_safe` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_delete` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_add` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_create` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_distribution` crashed during its setup or teardown.
[----] Warning! The test `chmap::chmap_power_of_two` crashed during its setup or teardown.
but only, if I give the --no-early-exit option
Franklin Mathieu
@Snaipe
CI builds with coverage, so I don't see why this is happening
Is this happening on the release?
Dominik
@kaidowei
and I guess it is during teardown, because the results come in normally
yes, 2.2.1
Franklin Mathieu
@Snaipe
What version of GCC & Gcov?
Dominik
@kaidowei
gcov --version
gcov (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.
gcc --version
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
and I just saw, that the test runner crashes too
./test_all --version
Tests compiled with Criterion v2.2.1
Segmentation fault (core dumped)
Franklin Mathieu
@Snaipe
I can't seem to reproduce that, this is weird
let me fire up an ubuntu vm
Could I get the full command line(s) used to build test_all?
Dominik
@kaidowei
Dominik
@kaidowei
okay, @Snaipe please stop looking, I suspect some of our libs
because in another directory it does not crash
Franklin Mathieu
@Snaipe
Okay
Also, as a heads up, don't forget to run your test with --no-early-exit
otherwise you won't get any coverage data
Dominik
@kaidowei
yeah, we're doing that