Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 19 18:12
    Snaipe commented #287
  • Sep 19 18:11
    Snaipe commented #287
  • Sep 14 16:25
    Snaipe commented #301
  • Sep 13 19:26
    Snaipe commented #302
  • Sep 13 19:21
    Snaipe commented #302
  • Sep 13 17:36
    MrAnno commented #301
  • Sep 13 17:35
    MrAnno commented #301
  • Sep 13 15:28
    kugel- commented #302
  • Sep 13 15:26
    kugel- commented #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe labeled #302
  • Sep 13 15:14
    Snaipe assigned #302
  • Sep 13 15:14
    Snaipe opened #302
  • Sep 13 14:55

    Snaipe on actions

    ci: setup basic actions yaml (compare)

  • Sep 11 08:33
    MrAnno opened #301
  • Sep 03 18:13
    Fumesover closed #300
  • Sep 03 18:13
    Fumesover commented #300
  • Sep 03 18:02
    Fumesover edited #300
  • Sep 03 18:02
    Fumesover edited #300
Franklin Mathieu
@Snaipe
Maintaining API compatibility with MSVC is quite hard on that aspect, yes
I'm still wondering why people aren't using clang-cl these days
it would solve all of these problems
Ben Turrubiates
@bturrubiates
i actually haven’t heard of clang-cl before
oh, looks like it can even be used from inside visual studio. that does sound like a better alternative...
Franklin Mathieu
@Snaipe
Its quite recent, I stumbled upon it a few months ago
and yes, the big plus is the visual studio integration
Ben Turrubiates
@bturrubiates
well sometimes you interact with windows projects where their main build system is visual studio files committed to a repoo
repo* and it feels kinda…dirty?
Franklin Mathieu
@Snaipe
This is encouraged by the VCS plugin for visual studio though
it versions the projects files with the sources
so for people not using the command line, this is the default behaviour
Ben Turrubiates
@bturrubiates
yeah, it seems pretty normal for VS + Windows development
just seems strange to someone not used to that workflow
Dominik
@kaidowei
@Snaipe hi there :)
we just found a bug/strange behavior with 2.2.2
[----] Warning! The test "ar7config::scg_active3" crashed during its setup or teardown.
[----] Warning! The test "ar7config::scg_delete" crashed during its setup or teardown.
[----] Warning! The test "ar7config::vcc_no_scg1" crashed during its setup or teardown.
[----] Warning! The test "ar7config::vcc_no_scg2" crashed during its setup or teardown.
[====] Synthesis: Tested: 14 | Passing: 14 | Failing: 0 | Crashing: 0
hmm
The return Code of the Tests is 0
which is unfortunate, if we run it with jenkins
Franklin Mathieu
@Snaipe
@kaidowei what are these tests doing during setup and/or teardown?
Also is this happening on v2.3.0-rc1?
Franklin Mathieu
@Snaipe
Looking at your log in more detail, these tests are crashing during teardown. If a test crashes during setup it is immediately marked as failed.
Crashing during teardown does not impact the result of the test
Dominik
@kaidowei
These tests tried to free something and due to a bug in our code, the free crashed.
Fortunately, we ran the tests manually, otherwise we would not have seen that.
so maybe crashing while teardown should also mark the tests as failed?
Franklin Mathieu
@Snaipe
I'm not sure it would be a good design idea since if you enforce that everything has to go right in your teardown then why isn't it part of the test function itself? (Same reasoning as putting assertions in JUnit's @After is considered bad practice)
however I do agree that those warnings should mandate a nonzero exit status
perhaps make Criterion return a nonzero status when at least one warning or error is caught
and introduce something like --ignore-warnings for the original behaviour
Dominik
@kaidowei
Seems reasonable :) :+1:
Masayuki Nagamachi
@masnagam
Hi,
Would you like me to register an issue to GitHub issues before sending a pull request?
I have found an issue in a cmake file, and MasayukiNagamachi/Criterion@4fd6fbd.
Franklin Mathieu
@Snaipe
@MasayukiNagamachi As long as you describe the issue fully and what the patch addresses in your PR, I don't mind
Franklin Mathieu
@Snaipe
From what I'm collecting from your script above, the issue is that the path to dependencies are relative to the root source directory, not the submodule one, right?
Masayuki Nagamachi
@masnagam
Yes, that's right.
Two dependencies folders are created.
First one is created in the root source directory by CMake and doesn't contains source files of submodules.
The other is created in vendor/criterion by git-submodule command and contains source files of submodules.
I'll send a pull request soon.
Thank you for your reply.
Franklin Mathieu
@Snaipe
2.3.0-rc2 is out. As always, feedback appreciated before we hit the release.
Kasper Sacharias Roos Eenberg
@kse
Hmm. Building criterion from our fails, in fact I cannot build from source with versions 2.2.{1,2}.
I get the error:
/tmp/yaourt-tmp-kse/aur-criterion/src/criterion/src/io/output.c:3:19: fatal error: khash.h: No such file or directory
 #include <khash.h>
Building v2.3.0-rc2 works.
Franklin Mathieu
@Snaipe
@kse v2.3.0-rc2 is stable on linux, so I'm going to update the package to that version
thanks for the report!
Kasper Sacharias Roos Eenberg
@kse
You are very welcome, it's a lovely library, so thank you.
Franklin Mathieu
@Snaipe
2.3.0 is finally out! The full announcement can be found here.
Douman
@DoumanAsh
@Snaipe How is going mimick?
Franklin Mathieu
@Snaipe
Not much done due to school projects, but I'm going back to it soon-ish
I think there are issues with PIE builds, but it should still be functional otherwise
Douman
@DoumanAsh
Where is from symbol libintl_dgettext, trying to build from sources right now on my msys setup but i'm failing for now :(
Douman
@DoumanAsh
Is it ok that binaries from release 2.3 have version: v2.3.0-rc2
Douman
@DoumanAsh
And it seems like 2.2. binaries for mingw-x64 are actually 32bit...
Franklin Mathieu
@Snaipe
@DoumanAsh That's mostly what the re-release was for