Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:42
    Snaipe commented #306
  • 17:37
    ntuDerekWang closed #307
  • 17:37
    ntuDerekWang commented #307
  • 17:34
    Snaipe commented #307
  • 17:28
    ntuDerekWang edited #307
  • 17:28
    ntuDerekWang edited #307
  • 17:26
    ntuDerekWang opened #307
  • 17:23
    ntuDerekWang closed #305
  • 17:23
    ntuDerekWang commented #305
  • 07:32
    vincentdupaquis commented #304
  • Oct 16 12:25
    P-NA-J opened #306
  • Oct 14 08:44
    Snaipe commented #304
  • Oct 14 07:41
    vincentdupaquis commented #304
  • Oct 12 17:28
    Snaipe commented #304
  • Oct 12 12:13
    Snaipe commented #304
  • Oct 12 11:43
    Snaipe commented #305
  • Oct 12 00:25
    ntuDerekWang opened #305
  • Oct 09 10:43

    Snaipe on master

    (compare)

  • Oct 09 10:41

    Snaipe on bleeding

    Struct pointer references use -… (compare)

  • Oct 03 16:05
    vincentdupaquis commented #304
Ben Turrubiates
@bturrubiates
yeah, it seems pretty normal for VS + Windows development
just seems strange to someone not used to that workflow
Dominik
@kaidowei
@Snaipe hi there :)
we just found a bug/strange behavior with 2.2.2
[----] Warning! The test "ar7config::scg_active3" crashed during its setup or teardown.
[----] Warning! The test "ar7config::scg_delete" crashed during its setup or teardown.
[----] Warning! The test "ar7config::vcc_no_scg1" crashed during its setup or teardown.
[----] Warning! The test "ar7config::vcc_no_scg2" crashed during its setup or teardown.
[====] Synthesis: Tested: 14 | Passing: 14 | Failing: 0 | Crashing: 0
hmm
The return Code of the Tests is 0
which is unfortunate, if we run it with jenkins
Franklin Mathieu
@Snaipe
@kaidowei what are these tests doing during setup and/or teardown?
Also is this happening on v2.3.0-rc1?
Franklin Mathieu
@Snaipe
Looking at your log in more detail, these tests are crashing during teardown. If a test crashes during setup it is immediately marked as failed.
Crashing during teardown does not impact the result of the test
Dominik
@kaidowei
These tests tried to free something and due to a bug in our code, the free crashed.
Fortunately, we ran the tests manually, otherwise we would not have seen that.
so maybe crashing while teardown should also mark the tests as failed?
Franklin Mathieu
@Snaipe
I'm not sure it would be a good design idea since if you enforce that everything has to go right in your teardown then why isn't it part of the test function itself? (Same reasoning as putting assertions in JUnit's @After is considered bad practice)
however I do agree that those warnings should mandate a nonzero exit status
perhaps make Criterion return a nonzero status when at least one warning or error is caught
and introduce something like --ignore-warnings for the original behaviour
Dominik
@kaidowei
Seems reasonable :) :+1:
Masayuki Nagamachi
@masnagam
Hi,
Would you like me to register an issue to GitHub issues before sending a pull request?
I have found an issue in a cmake file, and MasayukiNagamachi/Criterion@4fd6fbd.
Franklin Mathieu
@Snaipe
@MasayukiNagamachi As long as you describe the issue fully and what the patch addresses in your PR, I don't mind
Franklin Mathieu
@Snaipe
From what I'm collecting from your script above, the issue is that the path to dependencies are relative to the root source directory, not the submodule one, right?
Masayuki Nagamachi
@masnagam
Yes, that's right.
Two dependencies folders are created.
First one is created in the root source directory by CMake and doesn't contains source files of submodules.
The other is created in vendor/criterion by git-submodule command and contains source files of submodules.
I'll send a pull request soon.
Thank you for your reply.
Franklin Mathieu
@Snaipe
2.3.0-rc2 is out. As always, feedback appreciated before we hit the release.
Kasper Sacharias Roos Eenberg
@kse
Hmm. Building criterion from our fails, in fact I cannot build from source with versions 2.2.{1,2}.
I get the error:
/tmp/yaourt-tmp-kse/aur-criterion/src/criterion/src/io/output.c:3:19: fatal error: khash.h: No such file or directory
 #include <khash.h>
Building v2.3.0-rc2 works.
Franklin Mathieu
@Snaipe
@kse v2.3.0-rc2 is stable on linux, so I'm going to update the package to that version
thanks for the report!
Kasper Sacharias Roos Eenberg
@kse
You are very welcome, it's a lovely library, so thank you.
Franklin Mathieu
@Snaipe
2.3.0 is finally out! The full announcement can be found here.
Douman
@DoumanAsh
@Snaipe How is going mimick?
Franklin Mathieu
@Snaipe
Not much done due to school projects, but I'm going back to it soon-ish
I think there are issues with PIE builds, but it should still be functional otherwise
Douman
@DoumanAsh
Where is from symbol libintl_dgettext, trying to build from sources right now on my msys setup but i'm failing for now :(
Douman
@DoumanAsh
Is it ok that binaries from release 2.3 have version: v2.3.0-rc2
Douman
@DoumanAsh
And it seems like 2.2. binaries for mingw-x64 are actually 32bit...
Franklin Mathieu
@Snaipe
@DoumanAsh That's mostly what the re-release was for
as for i18n, it gets detected on msys even though the support is, well, untested, so I'd advise you pass -DI18N=OFF to cmake
Douman
@DoumanAsh
Actually i made 2.3 binaries to work. Originally it is just crashed, but now it is ok, so no need for 2.2 :)
Douman
@DoumanAsh
@Snaipe Q about mimick. How exactly works mmk_when()? I don't get why CallExpr isn't chaning anything for me :(
Franklin Mathieu
@Snaipe
@DoumanAsh mmk_when takes an expression that must call your mocked function with the parameter (or matchers) you want
e.g. if you're mocking malloc, and want to describe the behaviour of the mock when called with 4, you'd do mmk_when(malloc(4), ...)
(do mind that for some standard functions like malloc or memset the CallExpr can be optimized away because the compiler thinks that it has no side effects)
Douman
@DoumanAsh
@Snaipe it is just after i made test i tried to change expression, but it seems it works as usual... even though test itself works as usual. For example i tried to mmk_when(GetClipboardData(mmk_eq(UINT, format))) - format is variable. Test works, then i tried to change it like format + 1 it works too. But when i use mmk_verify(GetClipboardData(mmk_eq(UINT, format + 1)) it finds error
Franklin Mathieu
@Snaipe
do you perhaps have a self contained example with the expected vs actual result?
Douman
@DoumanAsh
Not right now, i'll push my code and will link it
Douman
@DoumanAsh
Here is repo https://github.com/DoumanAsh/lazy-winapi.c - It relies on WinAPI so it works only on windows... Do you use Windows? If not maybe i could try to make some more simple example. You can build it with Cmake UNIT_TESTING option and then build unit tests with make. In result there should be ut.exe, but these tests are stable only with -j1 :(
If i try to change mmk_eq(UINT, format) over https://github.com/DoumanAsh/lazy-winapi.c/blob/master/test/clipboard_mock.c#L38 with a different value of format, test will pass. But if i do the same over line https://github.com/DoumanAsh/lazy-winapi.c/blob/master/test/clipboard_mock.c#L42 then it fails
Not sure if i got it right though