Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 23 13:02
    pwt assigned #778
  • Jan 23 12:56
    pwt milestoned #796
  • Jan 23 12:56
    pwt assigned #796
  • Jan 23 12:56
    pwt milestoned #797
  • Jan 23 12:56
    pwt assigned #797
  • Jan 22 23:39
    amelchio opened #797
  • Jan 22 23:10
    amelchio opened #796
  • Jan 22 23:01
    pwt milestoned #795
  • Jan 22 23:00
    pwt assigned #795
  • Jan 22 22:57
    amelchio opened #795
  • Jan 22 13:45
    P-a-t-r-i-c-k starred SoCo/SoCo
  • Jan 22 11:28
    pwt demilestoned #794
  • Jan 22 11:28
    pwt milestoned #794
  • Jan 22 10:40
    pwt review_requested #788
  • Jan 22 10:27
    pwt synchronize #788
  • Jan 22 09:44

    pwt on master

    Fixes #794: Add 'Arc SL' to lis… (compare)

  • Jan 22 09:28

    pwt on v0.21.1

    (compare)

  • Jan 22 09:16

    pwt on v0.21.1

    (compare)

  • Jan 22 09:00
    pwt milestoned #794
  • Jan 22 08:57
    pwt demilestoned #794
Kenneth Nielsen
@KennethNielsen
Ok, so not this week. Fell into a hole of work. Next week for sure :D
Kenneth Nielsen
@KennethNielsen
Ok. So I have items searching and adding to queue from one LinkDevice service working. I will try and add a AppLink one as well and then share as WIP for testing. Still missing though is automatic reauth, because I'm waiting for the token I got to expire :D
Kenneth Nielsen
@KennethNielsen
Finally SoCo/SoCo#763
Have a look. The Music services may be coming back :D
pwt
@pwt
I've created PR #767 as a fix for #764. It changes how discover() determines the IP addresses to use for multicast discovery, and would really benefit from some testing by others.
(If this is a solid fix, and combined with the new network scan discovery option, I think we'll have addressed the vast majority of discovery issues that users encounter.)
Kenneth Nielsen
@KennethNielsen
Sounds great. I will see if I can run a quick test this evening.
pwt
@pwt
Thanks @KennethNielsen
Kenneth Nielsen
@KennethNielsen
BTW. I've gotten a little behind on emails from Github. If you have the overview of currently active issues and PRs and have a priority in mind, then let me know and I will tackle your high priority items first
pwt
@pwt
Will do. It's all reasonably under control :)
Kenneth Nielsen
@KennethNielsen
Ok. Oh yeah, I just checked, so feature freeze for 0.21 is scheduled for today. I don't know how you feel about that, maybe you want to add that PR to the milestone and then call it. I would of course like to see music services included as well, but I recognize that there is more work in that than I can cram quickly, so probably better to push that for next release, which could then be a short cycle. I think I should have some time over the holidays.
pwt
@pwt
The v0.21 milestone is scheduled for 17-Jan-2021 (45 days to go). The music services enhancement is a huge deal, so perhaps it would be good to keep this under review for 0.21 (without putting you under any pressure). I'm also reviewing the other PRs in the queue.
Kenneth Nielsen
@KennethNielsen
Ok. I will see if I can find a little time for it soon. I do also want it to go in soon. At least an early version to get some testing.
pwt
@pwt
A couple of 'low-hanging fruit' PRs ready for review, if anyone's up for it: #773 and #774.
Also, would like some testing on #767. This is a more fundamental change to how 'discover()' works.
Kenneth Nielsen
@KennethNielsen
@pwt :+1:
pwt
@pwt
Travis check jobs are not currently running: https://travis-ci.com/github/SoCo/SoCo/requests. I can't see enough of the error message ("Owner SoCo does not have...") to determine what's going wrong, and I don't have login creds.
Kenneth Nielsen
@KennethNielsen
@pwt I will try and have a look later
Kenneth Nielsen
@KennethNielsen
The message ends with " .. have enough credits". It seems now might be the time to look into Github actions. It is annoying however, since the releases are also done by TravisCI :(
pwt
@pwt
That's what I suspected. The documentation on the TravisCI site is ambiguous about open source projects. On the front page it states "Testing your open source projects is always 100% free!", whereas there was a blog post from November stating that OSS projects would be moved to a trial plan, with a fixed (non-renewable) number of credits (https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing). We could contact them to request a renewable allocation of free credits for SoCo.
Kenneth Nielsen
@KennethNielsen
I've made the request
pwt
@pwt
Happy New Year folks! A reminder that today is feature freeze for SoCo 0.21, with an expected release date two weeks from now (Jan 17th). If you have time for testing (with the current HEAD of master), please do help out. See
SoCo/SoCo#747 for an idea of where to focus.
In particular, there have been major enhancements to discovery, and full support for multi-household Sonos systems.
pwt
@pwt
On a completely separate note, my SoCo CLI utility (https://github.com/avantrec/soco-cli) now supports direct playback of audio files from the local filesystem using the new play_file and play_m3u actions. All feedback welcome.
Kenneth Nielsen
@KennethNielsen
@pwt I'm sorry about not finishing the music service PR, but I simply didn't find the time. I will see about testing during the week.
pwt
@pwt
@KennethNielsen No problem, there'll be another release train along in a while!
Kenneth Nielsen
@KennethNielsen
BTW. It doesn't seem like we should wait to free credits from TravisCI, it seems they stopped handing them out. So we will need to figure out a normal release process. I think it involves setting up some tool to get access to PyPI. I will try and have a look at it tomorrow.
@pwt :arrow_heading_up:
Kenneth Nielsen
@KennethNielsen
Ok I think I found some workable instructions. I administrative stuff I usually have a look at some of the guides and blog posts from Hynek Schlawack. The "The final step" section in https://hynek.me/articles/sharing-your-labor-of-love-pypi-quick-and-dirty/) describes how to upload the packages to pypi using twine and token access. So when you tag your release, as per the release procedure, then we can have a look at uploading it. Let me know if you prefer that I do it, or if we should transfer to you straight away, in which case you will need a user on PyPI which I can add to the soco team.
pwt
@pwt
Thanks @KennethNielsen. I know how to build and upload SoCo to PyPI, assuming I have the relevant creds. There is a pre-release test version of 0.21 at my Test PyPI repo which folks can take a look at: pip install -i https://test.pypi.org/simple/ soco.
pwt
@pwt
(It takes hours for Gitter to notify me of new messages by email ... is the same for others?)
Kenneth Nielsen
@KennethNielsen
Cool. I will add you to the organisation. Can you pm me your username?
Kenneth Nielsen
@KennethNielsen
@stefankoegl do you have a minute. Do you remember if the only use for the soco-bot user on PyPI was to let TravisCI upload packages? Because in that case I will delete it from the group, since we can't use Travis anymore.
pwt
@pwt
All: FYI, we're on track for making the 0.21 release on the 17th (Sunday). I have a couple of remaining, release-related PRs that I'll merge shortly before release (https://github.com/SoCo/SoCo/milestone/17). Let me know ASAP if there's anything else that needs to be included.
NB: v0.21 will not support Python 2.x. Pip installs on Python < 3.5 will install v0.20.
Kenneth Nielsen
@KennethNielsen
Sounds great. So you still need testing?
pwt
@pwt
Testing for people's specific use cases would still be good. However, in general, I think it's solid: passing all check jobs for me locally on Python 3.5 and Python 3.9. Plus, all the big changes have had plenty of testing now.
pwt
@pwt
SoCo v0.21 has just been released, on schedule, with lots of good new stuff: https://github.com/SoCo/SoCo/releases/tag/v0.21. Thanks to everyone who contributed.
Kenneth Nielsen
@KennethNielsen

SoCo v0.21 has just been released, on schedule, with lots of good new stuff: https://github.com/SoCo/SoCo/releases/tag/v0.21. Thanks to everyone who contributed.

:fireworks:

Thanks @pwt
pwt
@pwt
FYI: I'm going to push a v0.21.1 release to PyPI tomorrow, addressing #794. There's now a v0.21.fixes branch to pick up fixes and minor mods that we want to release now instead of waiting for 0.22.0. I'll also pull the changes across to master tomorrow.
pwt
@pwt
v0.21.1 is now released.
jjlawren
@jjlawren
would someone be able to help me understand the proper SoCo data structure i should be using for what seems to be a currently unsupported use-case?
jjlawren
@jjlawren
i'm starting to take a stab at adding better support for working with the Plex music service: SoCo/SoCo#778
pwt
@pwt
Hi @jjlawren : I'd like to help, but I'm not especially familiar with the data structure areas of the code. However, if I get time next week, I'll stumble around and see if I can help.
jjlawren
@jjlawren
if you look at the metadata payload in the issue, i'm able to create the DIDL payload inside, but I don't see any existing methods to wrap that into the <URLs> block
i had to add another class to match the new object.containervalue
then it seems that new action needs to be added. all of the existing actions seem to operate on AVTransport instead of Queue (which is what I need)
i think i'm starting to get a feel for it, but i'm not totally sure i'm following best practices