by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 11 19:55
    vince105 starred SoCo/SoCo
  • Jul 09 10:35
    pwt opened #735
  • Jul 09 10:09
    pwt opened #734
  • Jul 07 17:13
    webdaemontx starred SoCo/SoCo
  • Jul 03 10:43
    pwt synchronize #733
  • Jul 03 10:37
    pwt synchronize #733
  • Jul 02 10:09
    pavll starred SoCo/SoCo
  • Jun 29 20:38
    23maverick23 starred SoCo/SoCo
  • Jun 29 15:42
  • Jun 28 14:43
    pwt converted_to_draft #733
  • Jun 28 13:14
    pwt synchronize #733
  • Jun 28 13:11
    pwt opened #733
  • Jun 23 20:21
    timspit starred SoCo/SoCo
  • Jun 23 19:51
    emtee14 starred SoCo/SoCo
  • Jun 23 02:26
    emtee14 starred SoCo/SoCo
  • Jun 22 15:44
    WillFantom starred SoCo/SoCo
  • Jun 20 23:16
    joemulray starred SoCo/SoCo
  • Jun 20 09:51
    alikulov starred SoCo/SoCo
  • Jun 19 13:28
    physi3 opened #732
  • Jun 19 09:05
    fdp2 starred SoCo/SoCo
Kenneth Nielsen
@KennethNielsen
And yeah, logging is a good idea
I also have another idea which might help in bringing the data structure modules back closer to spec, so this will fit in nicely with some restructuring there
Kenneth Nielsen
@KennethNielsen
@DPH hi. It's been a while since I was active with SoCo, so I'm trying to touch base with everyone. Are you interested and have time to do a little bit of testing of various PR. I have very limited time, so if possible I would like to try and do more reviews and bug squashing.
David Harding
@DPH
Hi @KennethNielsen I can make some contribution but have less time than I used to. Feel free to ask, or I will spot changes and jump in where I can. Cheers David
Kenneth Nielsen
@KennethNielsen
@DPH ok, what I will do is tag you once in a while in PRs and ask if you can test and if you do not have time to spend on SoCo, just ignore it ;)
Kenneth Nielsen
@KennethNielsen
@stefankoegl I was considering updating the code example on the io pages, but they seem to contain a lot of html. Did you use some sort of tool to generate the html?
Stefan Kögl
@stefankoegl
@KennethNielsen I apparently created it using the "Automatic Page Generator", which has been discontinued since
maybe I can find the time during the weekend to re-create it with today's tools
Kenneth Nielsen
@KennethNielsen
@stefankoegl if you can, that would be great. I think the page content wise is good enough as it is except the code example. The code example is Python 2 only and I also don't think shows of the best parts of our API. I would, humbly, suggest the code example in the frontpage of read the docs
Kenneth Nielsen
@KennethNielsen
Ok. So it has been quite in here for a while. For once SoCo is not late due to real life taking all the time but shear forgetfulness, probably about time I add SoCo deadlines to my real world calendar. I preparing to feature freeze 0.19 shortly and want to get a few more changes in. Most significantly is #697 for adding a Python 2.7 deprecation warning, which will allow us to start removing Python 2 support immediately after release.
@stefankoegl regarding 1.0 I've run into an API design "issue" regarding group handling, which I would prefer to have sorted out before we do a 1.0, so if you don't mind I'd prefer to keep this one 0.19
Kenneth Nielsen
@KennethNielsen
@maru-sama I will start the quirks work with the missing protocol info being the first and only thing in there in time for 0.19, unless you already started it.
Kenneth Nielsen
@KennethNielsen
@maru-sama please see #698 and check that the fix for Sprotify Direct is correct
Kenneth Nielsen
@KennethNielsen
0.19 is feature frozen and we now enter a 2 week testing period. At this link is a (not necessarily complete) check list for the testing period: https://github.com/SoCo/SoCo/issues/673#issuecomment-570391917
Kenneth Nielsen
@KennethNielsen
Gentle reminder for testing 0.19. I have only limited time and we shouldn't release without proper testing.
Michael Guntsche
@maru-sama
@KennethNielsen I just checked this and made some additional comments. It does not fix the issue completely but I explained how I fixed it in #698
Michael Guntsche
@maru-sama
I found a way to do it in quirks and commented in #698
Michael Guntsche
@maru-sama
@KennethNielsen As you might have seen I did a pull request with the most straightforward fix I could find.
Kenneth Nielsen
@KennethNielsen
@maru-sama thanks a lot for testing it. I will have a look at it as soon as I get the chance.
pwt
@pwt
What's left to do for the 0.19 release? Anything specific I can help with?
pwt
@pwt
Anyone up for reviewing PR #704 for merge onto master? It's been system tested, is documented, and comes with unit tests.
Kenneth Nielsen
@KennethNielsen
@pwt I need testing as per https://github.com/SoCo/SoCo/issues/673#issuecomment-570391917, but it seems that amidst the spotty maintainer coverage we lost active developers as well, but that is understandable
I will have a look at that PR
Kenneth Nielsen
@KennethNielsen
I finally got around to finishing the PR to paint SoCo black, please have a look: SoCo/SoCo#706
pwt
@pwt
I've done some 0.19 integration (and unit) testing. I'll accumulate results and notes at: https://github.com/SoCo/SoCo/issues/673#issuecomment-599095679
The Black changes #706 look good to me. No issues for me with flake8, pylint, or the unit and integration tests (or the Black check).
Kenneth Nielsen
@KennethNielsen
@pwt thanks a lot
Kenneth Nielsen
@KennethNielsen
If anyone else have a second, please have a look at #706 as I want to get that in before starting to merge other stuff
pwt
@pwt
I've now successfully run all v0.19 unit and integration tests on:
Python 3.9.0a4+ on Raspbian Buster
Python 3.8.2+ on Raspbian Buster
Python 3.7.7 on macOS 10.14.6
Python 3.7.3 on Raspbian Buster
Python 3.6.10+ on Raspbian Buster
Python 2.7.16 on Raspbian Buster
pwt
@pwt
... also Python 3.5.9+ on Raspbian Buster
Kenneth Nielsen
@KennethNielsen
Wow, ok ok, more than enough. I was just looking for one more python and OS. I will do the release as soon as I have a little extra time. @pwt thanks a lot.
Kenneth Nielsen
@KennethNielsen
:fireworks:
Kenneth Nielsen
@KennethNielsen
Next release is 0.20. due out no later than May 21st. Nominate issue and PR's in this issue: SoCo/SoCo#708
Kenneth Nielsen
@KennethNielsen
And SoCo now comes only in black. Wuhu.
pwt
@pwt
Thanks for all the work on making the release, @KennethNielsen.
Kenneth Nielsen
@KennethNielsen
PR #713 fixes a long running issue of not autogenerating unknown vendor extended classes. Since quite a few of the issues we get, originate from this issue this is quite important. I would like eyes on it and some testing in your common usecases to make sure I haven't broken anything.
Kenneth Nielsen
@KennethNielsen
Just FYI. Kitchen project at home combined with pretty busy time at work has response somewhat slow in github. Hope to get to it soon.
pwt
@pwt
Just to note that the changes in PR #720 are required in order to pass the pylint tests in the Travis test jobs. An updated version of pylint flags a couple of new issues.
Kenneth Nielsen
@KennethNielsen
Hi everyone. I found a little time to work on SoCo so I will try to cram as much in as possible. If there are any recommandations for things to look at @pwt let me know.
Kenneth Nielsen
@KennethNielsen
#713 is merged, this is an important one as it tries to get rid of all those pesky errors we get when we run into unknonw vendor specific DIDLLite classes. Please test as much as possible,
Kenneth Nielsen
@KennethNielsen
@pwt I reviewed #719 and requested a few simple changes to improve logic and readability. Ping me here and I will merge as soon as they are fixed.
Kenneth Nielsen
@KennethNielsen
For everyones onfi. I pushed the 0.20 feature freeze for June 14th and release 14 days later.
pwt
@pwt
I've updated the PR for #719. Passes tests but would benefit from a quick review to check I have the logic correct.
Kenneth Nielsen
@KennethNielsen
@pwt thanks, I will get to it today
Kenneth Nielsen
@KennethNielsen
Feature freeze is delayed to allow #724 to get in. In the meantime however, I have a lot of problems getting TravisCI to pass. Lots of dependency problems with pytest and pytest_cov etc. If anyone wants to give that a crack I could use a hand. Since the release are created automatically with Travis CI, we will need to fix it before releasing (or disable the pytest check all together, which I'm not too fond of).
Kenneth Nielsen
@KennethNielsen
Ah nevermind that. The build is now passing.
Kenneth Nielsen
@KennethNielsen
0.20 is feature frozen. Test away everyone.