Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:35
    pwt synchronize #733
  • 10:19
    pwt synchronize #733
  • 09:42
    pwt synchronize #733
  • 06:52
    euphdk starred SoCo/SoCo
  • Oct 20 20:19
    KennethNielsen milestoned #733
  • Oct 20 20:19
    KennethNielsen labeled #733
  • Oct 20 20:19
    KennethNielsen labeled #733
  • Oct 20 20:19
    KennethNielsen labeled #733
  • Oct 20 19:40
    KennethNielsen labeled #594
  • Oct 20 19:35
    KennethNielsen milestoned #749
  • Oct 20 19:35
    KennethNielsen milestoned #748
  • Oct 20 19:35

    KennethNielsen on master

    Updated documentation for core.… (compare)

  • Oct 20 19:35
    KennethNielsen closed #739
  • Oct 20 19:31
    KennethNielsen milestoned #739
  • Oct 20 19:26

    KennethNielsen on master

    Add reference to soco-cli in th… (compare)

  • Oct 20 19:26
    KennethNielsen closed #741
  • Oct 20 19:21
    KennethNielsen labeled #586
  • Oct 20 19:21
    KennethNielsen labeled #586
  • Oct 20 18:57
    KennethNielsen labeled #742
  • Oct 20 18:57
    KennethNielsen labeled #742
Kenneth Nielsen
@KennethNielsen
Hi @stefankoegl and thanks for the help with the release. I'm trying with another real time option, we will see if it catches on this time. I think you even suggested gitter back when I created the IRC channel.
Stefan Kögl
@stefankoegl
Hi!
That might have been someone else - I haven't used gitter before
but I am happy to give it a try :)
Kenneth Nielsen
@KennethNielsen
Or it was some other online chat solutions. But anyway, IRC seems to be slowly dying, so it is probably better this way. BTW do you have a second to discuss something else?
Stefan Kögl
@stefankoegl
What do you want to discuss? I'll try to respond when I can
Kenneth Nielsen
@KennethNielsen
@stefankoegl I was watching this presentation by Hynek (attrs etc.) about basically lowering the overhead of maintaining a FOSS project. Basically system you can put in place to make sure that the time you spend on it is spent on the things that matter. One of the suggestions there was to make the use of a code formatter mandatory (by making one of the CI checks check that formatting the code doesn't introduce a change). The point of doing this, by his argument, was not as much to get that specific code style, but basically that all discussion about code style goes away from reviews. There was also some other suggestions there, like autogenerating the contributors list from git history etc. But I wanted to run the idea by you before I open the discussion in an issue.
I have been making use of black as a code formatter for at 8 kLOC project at work and I have to say that I really find it liberating
Stefan Kögl
@stefankoegl
I've been using black in other projects as well. I've even integrated it into the tests, so tests fail if the code is not properly formatted
so a definite +1 from me
Kenneth Nielsen
@KennethNielsen
Great. I will propose it then. Have a nice weekend.
Kenneth Nielsen
@KennethNielsen
@stefankoegl hi. Quick question. Do you know if the auto deploy fuctionality only tracks tags in master or in all branches. And if currently only master is it possible to make it do it for all branches. The reason is that it will make it easier to release bugfix releases, if I can do it in a "0.18" branch instead of from master.
Well, maybe not a quick question at all. Bad habit I picked up at work :$ prefixing everything with quick question
Stefan Kögl
@stefankoegl
In git tags do not belong to a branch
So whenever you create and push a tag, it will create and deploy a release
I think you can configure travis-ci to pattern-match the tag name, if you'd like to distinguish release-tags from non-release-tags
Kenneth Nielsen
@KennethNielsen
@stefankoegl ok, great, well I don't need the tags for anything else, so that's perfect
Michael Guntsche
@maru-sama
@KennethNielsen regarding bugfix releases, most likely because of the event issue that was just fixed, do you intend to use a micro number like 0.18.1? I am still wondering if SoCo should not be declared 1.xx since in my opinion it is already very stable.
Stefan Kögl
@stefankoegl
There was some discussion on switching to 1.0: SoCo/SoCo#316
If I remember correctly there was no real consensus back then
Michael Guntsche
@maru-sama
I think the situation did not change from back then a lot. The basic functionality is working and we know what isnt. I also doubt that there will be api breaking changes in the near future. So why not go ahead and call 0.19 1.0.0 instead and then go with a x.x.x versioning from then on?
Kenneth Nielsen
@KennethNielsen
We could. I think my argument from back then was that I really wanted to get music services in before calling it 1.0, but I have to admit that there has been no progress on that, so might as well continue without it
@maru-sama yes, I intend for the bugfix release to be 0.18.1, we have done that before but luckily they are rare
Kenneth Nielsen
@KennethNielsen
@stefankoegl regarding my comment above about version 1.0. I think I agree with you that it might as well be API stability. The only thing that I can think of that might need to be done is to remove some old that we have warned about deprecation of and there might be some things that should be removed like the old music service data structures and an old Spotify plugin
Kenneth Nielsen
@KennethNielsen
:fireworks: :fireworks: version 0.18.1 bugfix release is out
Michael Guntsche
@maru-sama
That fixes the event issue I was having thanks. In a side note. Spotify direct managed to do it again and botched the spec. The xml does not have the protocolinfo set BUT the text of the element contains it. Right now I have a hackish solution in data_structures.py namely checking the text and then manually setting the protocolInfo
if element.text and element.text.startswith("x-sonos"): content['protocol_info'] = "sonos.com-spotify:*:audio/x-spotify.*" else: raise DIDLMetadataError('Could not create Resource from Element: ' 'protocolInfo not found (required).')
Kenneth Nielsen
@KennethNielsen
@maru-sama wow that sounds incredibly ugly, no chance that they will fix it I guess?
Michael Guntsche
@maru-sama
Ok I suck ad using the markup but you get the idea I think
Kenneth Nielsen
@KennethNielsen
Not really, was looking for a squinting smiley ;)
Michael Guntsche
@maru-sama
Well they seem to break stuff on a quarterly base it seems.
Let me try and get a xml dump of that
Kenneth Nielsen
@KennethNielsen
In any case, if the code markup is too difficult, I can review it in a PR