by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
pwt
@pwt
I've done some 0.19 integration (and unit) testing. I'll accumulate results and notes at: https://github.com/SoCo/SoCo/issues/673#issuecomment-599095679
The Black changes #706 look good to me. No issues for me with flake8, pylint, or the unit and integration tests (or the Black check).
Kenneth Nielsen
@KennethNielsen
@pwt thanks a lot
Kenneth Nielsen
@KennethNielsen
If anyone else have a second, please have a look at #706 as I want to get that in before starting to merge other stuff
pwt
@pwt
I've now successfully run all v0.19 unit and integration tests on:
Python 3.9.0a4+ on Raspbian Buster
Python 3.8.2+ on Raspbian Buster
Python 3.7.7 on macOS 10.14.6
Python 3.7.3 on Raspbian Buster
Python 3.6.10+ on Raspbian Buster
Python 2.7.16 on Raspbian Buster
pwt
@pwt
... also Python 3.5.9+ on Raspbian Buster
Kenneth Nielsen
@KennethNielsen
Wow, ok ok, more than enough. I was just looking for one more python and OS. I will do the release as soon as I have a little extra time. @pwt thanks a lot.
Kenneth Nielsen
@KennethNielsen
:fireworks:
Kenneth Nielsen
@KennethNielsen
Next release is 0.20. due out no later than May 21st. Nominate issue and PR's in this issue: SoCo/SoCo#708
Kenneth Nielsen
@KennethNielsen
And SoCo now comes only in black. Wuhu.
pwt
@pwt
Thanks for all the work on making the release, @KennethNielsen.
Kenneth Nielsen
@KennethNielsen
PR #713 fixes a long running issue of not autogenerating unknown vendor extended classes. Since quite a few of the issues we get, originate from this issue this is quite important. I would like eyes on it and some testing in your common usecases to make sure I haven't broken anything.
Kenneth Nielsen
@KennethNielsen
Just FYI. Kitchen project at home combined with pretty busy time at work has response somewhat slow in github. Hope to get to it soon.
pwt
@pwt
Just to note that the changes in PR #720 are required in order to pass the pylint tests in the Travis test jobs. An updated version of pylint flags a couple of new issues.
Kenneth Nielsen
@KennethNielsen
Hi everyone. I found a little time to work on SoCo so I will try to cram as much in as possible. If there are any recommandations for things to look at @pwt let me know.
Kenneth Nielsen
@KennethNielsen
#713 is merged, this is an important one as it tries to get rid of all those pesky errors we get when we run into unknonw vendor specific DIDLLite classes. Please test as much as possible,
Kenneth Nielsen
@KennethNielsen
@pwt I reviewed #719 and requested a few simple changes to improve logic and readability. Ping me here and I will merge as soon as they are fixed.
Kenneth Nielsen
@KennethNielsen
For everyones onfi. I pushed the 0.20 feature freeze for June 14th and release 14 days later.
pwt
@pwt
I've updated the PR for #719. Passes tests but would benefit from a quick review to check I have the logic correct.
Kenneth Nielsen
@KennethNielsen
@pwt thanks, I will get to it today
Kenneth Nielsen
@KennethNielsen
Feature freeze is delayed to allow #724 to get in. In the meantime however, I have a lot of problems getting TravisCI to pass. Lots of dependency problems with pytest and pytest_cov etc. If anyone wants to give that a crack I could use a hand. Since the release are created automatically with Travis CI, we will need to fix it before releasing (or disable the pytest check all together, which I'm not too fond of).
Kenneth Nielsen
@KennethNielsen
Ah nevermind that. The build is now passing.
Kenneth Nielsen
@KennethNielsen
0.20 is feature frozen. Test away everyone.
pwt
@pwt
Just want to let folks know about a new CLI wrapper I've developed for SoCo: https://github.com/avantrec/soco-cli. (I know there are other attempts at this, but none met my needs). Comments welcome; usage feedback even more welcome.
pwt
@pwt
I'd really like to see 0.20 released. In particular I'm waiting on #724, and I wouldn't mind seeing #735 expedited.