Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Matthias Mohr
    @m-mohr
    Yes agreed. For now, we probably need to remove the dev restriction for a second.
    How many should that be for master? It's 2 at the moment. 3?
    Matthew Hanson
    @matthewhanson
    Yeah, I think 3 is fine
    Chris Holmes
    @cholmes
    Yeah, 3 sounds good - we'd notice it.
    Matthias Mohr
    @m-mohr
    Okay, I'll quickly shut down restrictions for dev to sort the issues out
    Chris Holmes
    @cholmes
    Yeah, sounds great - I've done that for release time before. It's a special time :)
    Matthias Mohr
    @m-mohr
    Conflict solved, reverted back to dev restrictions, still a review missing. Can't set reviewer number to three for master...
    Errors with Could not resolve to a node with the global id of 'MDQ6VGVhbTIzNTY3MTY='.
    Matthew Hanson
    @matthewhanson
    What if you remove restrictions first, save that, then set them back?
    Matthias Mohr
    @m-mohr
    Don't want to risk that after I removed them, I can't set them back and master is then not protected... ;-)
    Matthew Hanson
    @matthewhanson
    I’ve added my review
    Matthias Mohr
    @m-mohr
    Maybe it works after the PR is merged?
    Matthew Hanson
    @matthewhanson
    yeah maybe we can try again, you merging now?
    Matthias Mohr
    @m-mohr
    Yes, merged
    Still doesn't work
    Can't remove the protection rules either. Maybe a problem with my rights? Chris, could you try?
    Chris Holmes
    @cholmes
    oh yeah, I can remove protection rules
    Matthias Mohr
    @m-mohr
    First try to set it to three people
    for master
    Chris Holmes
    @cholmes
    on master?
    ok, just did that
    Matthias Mohr
    @m-mohr
    Great, seems we have different privileges ;-)
    Matthew Hanson
    @matthewhanson
    weird, we are all admins
    Chris Holmes
    @cholmes
    Yeah, I didn't realize I had anything more. Will see if I can give you more.
    you want me to change dev? Remove protection?
    Matthias Mohr
    @m-mohr
    Maybe has to do with radiantearth/radiant-standards-twg group? Not sure
    No, dev is fine.
    I was able to change the "Include administrators" rule there, which allowed me to commit directly to dev.
    Now we need to do a release, I guess.
    Chris Holmes
    @cholmes
    Ah, ok, cool. So we're all set? I see it on master.
    Yup, that's the final step.
    Matthias Mohr
    @m-mohr
    Yes, should I make a release?
    Chris Holmes
    @cholmes
    Oh, and check that the website updated the API docs.
    Matthew Hanson
    @matthewhanson
    +1 (on release)
    Chris Holmes
    @cholmes
    I think that's supposed to just happen? Or is there a manual step?
    Matthew Hanson
    @matthewhanson
    the website links to the API docs on master
    Chris Holmes
    @cholmes
    Yup, looks like it's working
    Matthias Mohr
    @m-mohr
    Chris Holmes
    @cholmes
    Yup, go for it with the release @m-mohr
    Matthias Mohr
    @m-mohr
    Released
    Matthew Hanson
    @matthewhanson
    :dancers:
    Chris Holmes
    @cholmes
    nice!
    I'll put up the medium post on monday, and tweet it out.
    thanks for pushing it out!
    Matthias Mohr
    @m-mohr
    Why did nobody tell me it's 9pm here? Will head home now ;-)
    Matthew Hanson
    @matthewhanson
    Are you tweeting today Chris, or after your post?
    Chris Holmes
    @cholmes
    And to everyone for all their hard work on this release.
    I was going to do after post
    But feel free to tweet today if you'd like.
    Matthew Hanson
    @matthewhanson
    Ok, I’ll fire off quick tweet