Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:21
    proceps labeled #1229
  • 00:21
    proceps assigned #1229
  • 00:21
    proceps opened #1229
  • Dec 10 22:40

    mjy on development

    whitespace WIP for #1204 Merge branch 'development' of g… and 1 more (compare)

  • Dec 10 22:40
    PJansta opened #1228
  • Dec 10 22:40
    PJansta labeled #1228
  • Dec 10 22:33
    mjy commented #1227
  • Dec 10 22:31
    PJansta commented #1227
  • Dec 10 22:23
    mjy labeled #1227
  • Dec 10 22:23
    mjy assigned #1227
  • Dec 10 22:23
    mjy labeled #1227
  • Dec 10 22:23
    mjy opened #1227
  • Dec 10 21:28

    jlpereira on page

    Fix (compare)

  • Dec 10 21:25

    jlpereira on page

    Added filter #1220 (compare)

  • Dec 10 21:13
    mjy labeled #1226
  • Dec 10 21:13
    mjy labeled #1226
  • Dec 10 21:13
    mjy opened #1226
  • Dec 10 20:54
    jlpereira edited #1220
  • Dec 10 20:53
    jlpereira edited #1220
  • Dec 10 20:53
    jlpereira edited #1220
Hernán Lucas Pereira
@LocoDelAssembly
image.png
You should see similar output, but with ctrl instead of alt
Matt
@mjy
Passed for me
Identical
Hernán Lucas Pereira
@LocoDelAssembly
Literally identical??
Matt
@mjy
No
sorry
ctrl-t
there
Uhoh- 2 red
checking
Those are all random
timeouts on features
let's release
Hernán Lucas Pereira
@LocoDelAssembly
OK, merging into master and tagging
Hernán Lucas Pereira
@LocoDelAssembly
What do you think about generating random values like https://github.com/faker-ruby/faker#ensuring-unique-values ?
@/all production is about to be updated to version 0.8.8.
Matt
@mjy
We definitely need to be more determininstic.
Hernán Lucas Pereira
@LocoDelAssembly
Well, there is a separate method to do that as well. Generating always the same set of values would be better?
Matt
@mjy
Deterministic, but different values without having to think about those values would be ideal.
Wether or not they are always the same is a different issue.
In theory we might get more coverage if they weren't the same.
But I don't know.
Hernán Lucas Pereira
@LocoDelAssembly
v0.8.8 is live.
Matt
@mjy
Thanks much @LocoDelAssembly.
Matt
@mjy
I suppose we'll wait at least till tomorrow to roll to Rails 6 ;)
Matt
@mjy
Think we're still going to have to modify behaviour of identifier on digitization.
If user hits save before verifciation sends it should send, and respond with not saved after. The initial check should be more like the new taxon name check I think- it's there, but doesn't interupt things.
Matt
@mjy
@LocoDelAssembly We need to roll sandboxes too?
14hrs past
I think we do...
Hernán Lucas Pereira
@LocoDelAssembly
Yes, will do in a moment. Not getting green for a long time... Investigating a DatabaseCleaner issue.
Matt
@mjy
Something from geo or taxon names?
Or sources?
Hernán Lucas Pereira
@LocoDelAssembly
The random failures. I added exception handling on sign_in to see why cannot find email field. Turns out the page was the dashboard, so it is like the test user is logged in without signing in first...
Matt
@mjy
Which spec?
I think most random failures are just headless browser timing.
Hernán Lucas Pereira
@LocoDelAssembly
any feature spec, but in particular otu was failing too often today
Matt
@mjy
and that's the simplest form
Hernán Lucas Pereira
@LocoDelAssembly
    while User.count > 0 && i >=3
      puts "DATABASE NOT YET CLEARED, RETRYING..."
      sleep 2**i
      DatabaseCleaner.clean
      i += 1
    end
Failed again. Too bad I checked i value wrong... :angry: Well... Will update sandboxes with the build that is about to complete.
Rolling
Hernán Lucas Pereira
@LocoDelAssembly
Ready, zero restarts with new probes. Will watch until they are 15 minutes old. Tomorrow morning if there are still at zero restart I'll merge new kubernetes configs into master (have tested this at the time with sandcastle, so it would be really unexpected if this doesn't work). Good night.
Matt
@mjy
Thanks Hernán
Hernán Lucas Pereira
@LocoDelAssembly
FYI Gitter seems to not be working so well today, needed Ctrl+F5 many times to receive messages. @jlpereira and @jrflood experienced problems as well.
Matt
@mjy
If you have an Ad blocker check and disable it. I think it might have picked up some requests.
A report: "I have passed through catalog number, repository, adding images. All seemed to work perfectly until I have saved the whole thing with images uploaded. First save (after I added captions to first image) was ok and all images stated visible, after second saving, all images disappeared again. I wish to see them as a miniatures because then I can add/change captions to image I did not do or at least see what kong of images I have already uploaded."
José Luis Pereira
@jlpereira
Im using the desktop app and it happen the same thing
Matt
@mjy
Come to think of it, me too.
Matt
@mjy
@LocoDelAssembly How can I run these tests on dev machine? https://travis-ci.org/SpeciesFileGroup/taxonworks/jobs/623415201#L7482