Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 09 22:50
    mjy commented #3009
  • Dec 09 22:42
    tmcelrath commented #3009
  • Dec 09 17:39

    jlpereira on development

    Add edit button #3222 (compare)

  • Dec 09 17:17

    jlpereira on development

    UI changes #2176 (compare)

  • Dec 09 17:15
    jlpereira edited #2176
  • Dec 09 17:15
    jlpereira edited #2176
  • Dec 09 16:09
    jlpereira edited #2176
  • Dec 08 22:35
    michesposito commented #3223
  • Dec 08 22:35
    michesposito opened #3223
  • Dec 08 22:35
    michesposito labeled #3223
  • Dec 08 22:15
    michesposito commented #3222
  • Dec 08 22:14
    michesposito opened #3222
  • Dec 08 22:14
    michesposito labeled #3222
  • Dec 08 20:28
    michesposito commented #3221
  • Dec 08 20:27
    michesposito labeled #3221
  • Dec 08 20:27
    michesposito opened #3221
  • Dec 08 18:34

    jlpereira on development

    Prevent duplicate shortcuts. Cleanup (compare)

  • Dec 08 17:43
    proceps commented #2771
  • Dec 08 17:40
    debpaul commented #2771
  • Dec 08 17:40
    debpaul commented #2771
José Luis Pereira
@jlpereira
and try again
Matt
@mjy
npm version?
José Luis Pereira
@jlpereira
8.19.2 (Ubuntu)
Matt
@mjy
9.1.2 here
Should be OK?
José Luis Pereira
@jlpereira
I guess?
I will try updating here
Matt
@mjy
Not working.
when I wipe modules and install again.
José Luis Pereira
@jlpereira
      def node_modules_bin_exist?
        File.exist?("#{@node_modules_bin_path}/webpack-dev-server")
      end
check if webpack-dev-server folder exist inside node_modules
Matt
@mjy
Screen Shot 2022-11-30 at 8.45.17 AM.png
José Luis Pereira
@jlpereira
open /bin/webpacker-dev-server
what do you have on line 10?
Matt
@mjy
To confirm- we do not need yarn, right?
José Luis Pereira
@jlpereira
We don't. I don't have it on the Mac
what do you get when you run npm bin?
Matt
@mjy
#!/usr/bin/env ruby

ENV["RAILS_ENV"] ||= "development"
ENV["NODE_ENV"]  ||= ENV["RAILS_ENV"]

require "pathname"
ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
  Pathname.new(__FILE__).realpath)

ENV["WEBPACKER_NODE_MODULES_BIN_PATH"] = `npm bin`.chomp

require "bundler/setup"

require "webpacker"
require "webpacker/dev_server_runner"

APP_ROOT = File.expand_path("..", __dir__)
Dir.chdir(APP_ROOT) do
  Webpacker::DevServerRunner.run(ARGV)
end
Hernán Lucas Pereira
@LocoDelAssembly
Can you add byebug somewhere inside the gem code and then inspect what @node_modules_bin_path is?
Matt
@mjy
'nil'
Did that earlier ^
José Luis Pereira
@jlpereira
that's the problem
Matt
@mjy
npm bin -> unknown command
José Luis Pereira
@jlpereira
there it is
Hernán Lucas Pereira
@LocoDelAssembly
npm bin
/home/hernan/Projects/taxonworks/node_modules/.bin
José Luis Pereira
@jlpereira
maybe was removed on v9?
Matt
@mjy
must be
José Luis Pereira
@jlpereira
npm bin has been removed (use npx or npm exec to execute binaries)
Hernán Lucas Pereira
@LocoDelAssembly
npx webpack-dev-server doesn't fully work, needs some configuration maybe.
José Luis Pereira
@jlpereira
yep, it won't work
Matt
@mjy
any reason we can bump to 9.1 ?
José Luis Pereira
@jlpereira
Try this
ENV["WEBPACKER_NODE_MODULES_BIN_PATH"] = `npm root`.chomp + '/.bin'
Matt
@mjy
Works, building.
José Luis Pereira
@jlpereira
Not the most elegant solution but should works for both versions
Matt
@mjy
Should I commit?
José Luis Pereira
@jlpereira
I will do in a moment, I want to try a couple of things first, and I have to update the other file too
Matt
@mjy
:thumbsup:
José Luis Pereira
@jlpereira
pushed
Matt
@mjy
Thanks
Tommy McElrath
@tmcelrath
Should adding a determination on a collection object take longer if the associated collecting event has lots of associated collection objects? Especially if the collecting event is not being updated?
Basically, the more COs on a CE, the longer saving a CO takes, even in the CE is not being updated.
Matt
@mjy
That doesn't sound right.
Doing a quick check I don't see cascading issues.
If you update CE, definitely.
But simply adding a TD to a CO shouldn't be a problem.
Tommy McElrath
@tmcelrath
Want me to submit a bug report?
Matt
@mjy
If you can replicate it yes please.