These are chat archives for Spring-Chobby/Chobby

14th
Jul 2016
GoogleFrog
@GoogleFrog
Jul 14 2016 03:18
gajop I think abmas comment meant you can change springsettings to be editable
GoogleFrog
@GoogleFrog
Jul 14 2016 03:29
or is it said @gajop?
Gajo Petrovic
@gajop
Jul 14 2016 03:29
i saw the message
from what abma said i assume that it's a security reason
it doesn't make much sense to forbid it, since you can change it via Spring.SetConfig*
i wish forb were here
i feel like an idiot doing this
i'd like to try material design
i think it looks nicer and tends to avoid these huge amounts of borders
there are panels which represent parts of content, but they're currently nearly black
GoogleFrog
@GoogleFrog
Jul 14 2016 03:44
I like material design, nice skinning
abma said restricting to spring directory is for security reasons. he did not seem to recall why springsettings was affected
you don't have to be doing skinning now though
Gajo Petrovic
@gajop
Jul 14 2016 03:48
ok i've just pushed this stuff and that's it
GoogleFrog
@GoogleFrog
Jul 14 2016 04:29
I'll mess with it as a the colour differences are quite subtle
Gajo Petrovic
@gajop
Jul 14 2016 04:33
it's pretty badly spread out throughout the project
GoogleFrog
@GoogleFrog
Jul 14 2016 04:33
yea I noticed that it is not a chili skin
are you still workaround along your priority list?
Gajo Petrovic
@gajop
Jul 14 2016 04:34
yea, these were just things i felt doing since other people are looking at the project
GoogleFrog
@GoogleFrog
Jul 14 2016 04:34
do you think you can make the settings change?
Gajo Petrovic
@gajop
Jul 14 2016 04:34
i'm back to textbox stuff soonish (although have some real-world work first atm)
i can probably make them part of startscript
GoogleFrog
@GoogleFrog
Jul 14 2016 04:34
I'd like to get some sort of interface in so I can finish off that area
Gajo Petrovic
@gajop
Jul 14 2016 04:35
ok
the only other UI thing i want to do is the tab/chat alerts
GoogleFrog
@GoogleFrog
Jul 14 2016 04:36
I think I can do that
I've already messed with the tab panel buttons control
Gajo Petrovic
@gajop
Jul 14 2016 04:36
ok
GoogleFrog
@GoogleFrog
Jul 14 2016 04:36
did you see the player interaction dropdown menu? I made combobox better
Gajo Petrovic
@gajop
Jul 14 2016 04:36
i've seen the one that appears on click
GoogleFrog
@GoogleFrog
Jul 14 2016 04:36
that is the one
Gajo Petrovic
@gajop
Jul 14 2016 04:37
i think it's a decent start
GoogleFrog
@GoogleFrog
Jul 14 2016 04:37
is it not sufficient?
Gajo Petrovic
@gajop
Jul 14 2016 04:37
i'm not sure i like LMB and RMB both working on everything in chili
GoogleFrog
@GoogleFrog
Jul 14 2016 04:37
as that particular bit of UI
Gajo Petrovic
@gajop
Jul 14 2016 04:38
i'd probably trigger it just on RMB and have double click LMB open chat
oh great, even MMB and MB4/MB5 trigger chili OnClick
so annoying..
GoogleFrog
@GoogleFrog
Jul 14 2016 04:40
well that is easy to change
Gajo Petrovic
@gajop
Jul 14 2016 04:40
i think people brought that issue to jk but he dismissed it
GoogleFrog
@GoogleFrog
Jul 14 2016 04:40
I think the obvious design for chili is to let them all through by default
and sort by button later
Gajo Petrovic
@gajop
Jul 14 2016 04:41
i honestly dislike having "if button == 1" ...
GoogleFrog
@GoogleFrog
Jul 14 2016 04:41
don't worry about it for now
Gajo Petrovic
@gajop
Jul 14 2016 04:41
ok
but what do you think about having RMB for extra uses?
GoogleFrog
@GoogleFrog
Jul 14 2016 04:41
nothing at the moment
I guess RMB is good if it is intuative but otherwise it can end up hidden
Gajo Petrovic
@gajop
Jul 14 2016 04:45
yeah i'm not sure either
Gajo Petrovic
@gajop
Jul 14 2016 04:56
btw i haven't heard what you think of having the slightly animated Playing/Spectating status above the My battle?
GoogleFrog
@GoogleFrog
Jul 14 2016 04:56
We Dota Now
Gajo Petrovic
@gajop
Jul 14 2016 04:56
lol
GoogleFrog
@GoogleFrog
Jul 14 2016 04:56
I don't think its appropriate for a battle room
because they are less dire actions than being in a queue
Gajo Petrovic
@gajop
Jul 14 2016 04:57
can it just be non-animated then?
i like the idea of being able to infer play/spectate state by color
GoogleFrog
@GoogleFrog
Jul 14 2016 04:57
the Dota Queue thingy means "you had better not leave the computer and you're basically sure to get a game without 5 minutes"
*within
Gajo Petrovic
@gajop
Jul 14 2016 04:58
yeah it does mean a slightly different thing
GoogleFrog
@GoogleFrog
Jul 14 2016 04:58
I don't see a reason to not make the whole thing clickable
it works well for QM I think
for QM we can have a similarly animated thing with a big X button on one side to cancel (that is what new dota has btw)
Gajo Petrovic
@gajop
Jul 14 2016 04:59
button feels too big i think, and separating state can be useful since highlighting doesn't affect state color
yeah i think so too for MM
maybe status can also show time in queue, ETA or w/e
GoogleFrog
@GoogleFrog
Jul 14 2016 05:02
yes
players
minimap
current chat!
Gajo Petrovic
@gajop
Jul 14 2016 05:03
oh so for the battleroom status?
that feels too much :x
I'd put it in a fairly irrelevant color font and only include map name (not image) OR room title, and perhaps number of players
i dislike having duplicate info on screen, which is what most players would see
(as they'll also often have the battleroom window open) and everything will feel crowded
GoogleFrog
@GoogleFrog
Jul 14 2016 05:22
you know it would be nice if the chat started at the bottom of the screen and got pushed upwards
Gajo Petrovic
@gajop
Jul 14 2016 05:23
hm yeah
GoogleFrog
@GoogleFrog
Jul 14 2016 06:20
I can't make a textbox grow higher by adding text with newlines in it
numLines does not go up
ah nevermind
Gajo Petrovic
@gajop
Jul 14 2016 07:22
hmph
i think detachable chat tabs should be off by default
it makes the My Battle area a bit messy and sticks out
it's also odd if you aren't in any channel
just has the "+"
Gajo Petrovic
@gajop
Jul 14 2016 07:51
i just realized switching the interfaces on the fly would require to abandon the inheritance thing in liblobby and replace it with encapsulation
otherwise if any widget does lobby = WG.LibLobby.lobby they will always use the old interface
buut think i'll wait a bit with doing that
not really hard thankfully, just requires to explicitly call the Lobby or Interface methods
GoogleFrog
@GoogleFrog
Jul 14 2016 08:58
I want to see skirmish and lobby at the same time
GoogleFrog
@GoogleFrog
Jul 14 2016 11:39
I want to put the ZK garbage collection widget in to see whether out of memory then fails to occur
Gajo Petrovic
@gajop
Jul 14 2016 11:40
it's certainly a bug somewhere
GoogleFrog
@GoogleFrog
Jul 14 2016 11:42
but it may be in spring
or chili
I'm saying it may exist in ZK but be hidden by the GC widget. It would be good to know whether the GC widget prevents it
and the way to discover that is to add it and then look back over weeks to see if any out of memory occured
GoogleFrog
@GoogleFrog
Jul 14 2016 11:51
I think the configuration is getting into a loop and causing an increasing number of copies of #zk to be joined
the data structure doesn't stop duplicates
and config sends off a join command for each duplicate
which apparently the server sends a response for
so the number of channel duplicates stored in the config goes up
I'll fix this
(since zk server also auto-joins #zk)
Gajo Petrovic
@gajop
Jul 14 2016 11:57
ah
yeah that's possible, i didn't look into the details
GoogleFrog
@GoogleFrog
Jul 14 2016 11:57
that might not cause it
Gajo Petrovic
@gajop
Jul 14 2016 12:00
i think we shouldn't hide errors though, but at least print them
GoogleFrog
@GoogleFrog
Jul 14 2016 12:00
same with a lot of things
they'll add duplicate fields
Gajo Petrovic
@gajop
Jul 14 2016 12:00
yeah that's bad
GoogleFrog
@GoogleFrog
Jul 14 2016 12:00
I don't expect the server to work correctly though
Gajo Petrovic
@gajop
Jul 14 2016 12:00
should print errors in the interface
GoogleFrog
@GoogleFrog
Jul 14 2016 12:00
its just the interfaces job to deal with whatever it throws up
Gajo Petrovic
@gajop
Jul 14 2016 12:00
interface should send clean data to the lobby
but it should also print errors
idk what the oom widget, but same story there, i'd like to know there's something causing excessive memory usage as that probably hurts performance a lot
could be the textbox and the million strings it creates..
but i doubt it
GoogleFrog
@GoogleFrog
Jul 14 2016 12:02
it happens for me at load or not at all
Gajo Petrovic
@gajop
Jul 14 2016 12:02
yes
but i don't know how to reproduce it or debug it
GoogleFrog
@GoogleFrog
Jul 14 2016 12:11
I'm not sure about calling when the user is not inserted
I guess no data has changed so it is pointless to call
Gajo Petrovic
@gajop
Jul 14 2016 12:11
shouldn't call
GoogleFrog
@GoogleFrog
Jul 14 2016 12:11
I just feel that there will be situations where doing the update is useful
Gajo Petrovic
@gajop
Jul 14 2016 12:11
adding a user when one already exists is an error
i see this current code as a temporary workaround to catch issues
GoogleFrog
@GoogleFrog
Jul 14 2016 12:13
its a server error
I see this as necessary input sanitising
Gajo Petrovic
@gajop
Jul 14 2016 12:14
yes, server or skirmish interface
idk where to do it though
GoogleFrog
@GoogleFrog
Jul 14 2016 12:14
what?
Gajo Petrovic
@gajop
Jul 14 2016 12:14
the input sanitizing part
idk if they should be moved to lobby.lua or kept in the specific interfaces
but everything should still be logged so we can detect errors and fix them
GoogleFrog
@GoogleFrog
Jul 14 2016 12:20
do you know how to focus a control?
Gajo Petrovic
@gajop
Jul 14 2016 12:20
screen:FocusControl(ctrl)
GoogleFrog
@GoogleFrog
Jul 14 2016 12:41
I don't think we want material design buttons
I dislike how the panel changes removed skinning
something to think about later I guess
there are other people better at skinning
Gajo Petrovic
@gajop
Jul 14 2016 12:41
the panel changes are just temporary and should be moved to a real chili skin
i know i want chat tabs to be material design
GoogleFrog
@GoogleFrog
Jul 14 2016 12:45
well then you need it for everything to be consistent
Gajo Petrovic
@gajop
Jul 14 2016 12:45
sure
GoogleFrog
@GoogleFrog
Jul 14 2016 12:46
I don't really want or not want that
Анархид
@Anarchid
Jul 14 2016 12:49
material design doesn't mean no skinning
GoogleFrog
@GoogleFrog
Jul 14 2016 12:50
it does with this implementation
because it bypasses the skin
technically we're using robocracy with a bunch of images on top
Gajo Petrovic
@gajop
Jul 14 2016 12:50
that's just a hack though
GoogleFrog
@GoogleFrog
Jul 14 2016 12:50
I know
Gajo Petrovic
@gajop
Jul 14 2016 12:51
i think it would be very important to finish the UI
just graphically add components that aren't yet implemented
i'd like this done by end of august, and perhaps even sooner, so people can skin it
GoogleFrog
@GoogleFrog
Jul 14 2016 12:52
this is the lobby?
the basics of
Gajo Petrovic
@gajop
Jul 14 2016 12:52
?
GoogleFrog
@GoogleFrog
Jul 14 2016 12:53
what is the "this" to be done?
Gajo Petrovic
@gajop
Jul 14 2016 12:53
adding all UI components that we plan to have
GoogleFrog
@GoogleFrog
Jul 14 2016 12:53
right
what about the engine changes?
Gajo Petrovic
@gajop
Jul 14 2016 12:53
so queues, downloads, friends, etc.
engine changes can happen independently
I'd just like UI stuff in, even if it isn't fully implemented
GoogleFrog
@GoogleFrog
Jul 14 2016 12:55
I'm not sure that you can finish the UI before people are using it
Анархид
@Anarchid
Jul 14 2016 13:22
does signing up as a JsonCommand give me data in parsed form?
Gajo Petrovic
@gajop
Jul 14 2016 13:22
yea
it'll decode the json
that's the point
GoogleFrog
@GoogleFrog
Jul 14 2016 14:01
would you like to do testing on ZK people? I would
I think I'll create a milestone for it
because there are a decent number of tickets that are not require for a "We'd like you to download this archieve and test this lobby" thing
to fairly competent people
Gajo Petrovic
@gajop
Jul 14 2016 14:02
disable echo and /console
well just /console i guess
disable custom widgets
etc.
GoogleFrog
@GoogleFrog
Jul 14 2016 14:03
such as rapid
Gajo Petrovic
@gajop
Jul 14 2016 14:03
in general i wouldn't really like it yet
GoogleFrog
@GoogleFrog
Jul 14 2016 14:03
not yet
but as a milestone
GoogleFrog
@GoogleFrog
Jul 14 2016 14:04
I thought it was before that
Gajo Petrovic
@gajop
Jul 14 2016 14:04
maybe a few of those but i'd say after in general
e.g. you may be ok with just 102 engine
or without an engine AI blacklist
GoogleFrog
@GoogleFrog
Jul 14 2016 14:05
102 is not good enough
because I want settings
Gajo Petrovic
@gajop
Jul 14 2016 14:05
but imo not before #14 #112 #31 etc.
GoogleFrog
@GoogleFrog
Jul 14 2016 14:06
yes, there is a lot of overlap
Gajo Petrovic
@gajop
Jul 14 2016 14:06
no i mean you'd be ok without #53
GoogleFrog
@GoogleFrog
Jul 14 2016 14:06
yes
well, if I could set the springies I'd be ok
Gajo Petrovic
@gajop
Jul 14 2016 14:07
how about we put an actual date instead?
Анархид
@Anarchid
Jul 14 2016 14:07
lua not having split is eminently stupid
_stupid)
stupid
Gajo Petrovic
@gajop
Jul 14 2016 14:08
i know i'll be very busy from 30th July to like 14th of August, probably won't be seeing a commit
so i think something like the 28th would be ideal for a test release
i don't even want to call it a release
"a test version they can try"
GoogleFrog
@GoogleFrog
Jul 14 2016 14:17
that sounds good
the main things from you I want are Spring-Chobby/Chobby#119 and Spring-Chobby/Chobby#100
Gajo Petrovic
@gajop
Jul 14 2016 14:18
ok then, if you want to spend time making a milestone go ahead; otherwise i'll just be doing issues in the mandatory list that i think are relevant to it
k
GoogleFrog
@GoogleFrog
Jul 14 2016 14:19
Spring-Chobby/Chobby#7 would be a bonus
and launching urls
Gajo Petrovic
@gajop
Jul 14 2016 14:19
that's what i'm doing
URLs probably not going to happen
Анархид
@Anarchid
Jul 14 2016 14:19
hrm
GoogleFrog
@GoogleFrog
Jul 14 2016 14:19
actually I think urls might be mandatory for things like reports and streams
Gajo Petrovic
@gajop
Jul 14 2016 14:20
for reports no obviously
jsonrpc and send to server
GoogleFrog
@GoogleFrog
Jul 14 2016 14:20
I think there is a decent case for putting url in spring
Анархид
@Anarchid
Jul 14 2016 14:20
what do you mean by launching urls
i accidentally clicked the wrong thing and it sent me a SiteToLobbyCommand asking me to host a map
Gajo Petrovic
@gajop
Jul 14 2016 14:20
he means opening the browser from spring
GoogleFrog
@GoogleFrog
Jul 14 2016 14:20
telling spring to tell the OS to make the default browser go somewhere
Анархид
@Anarchid
Jul 14 2016 14:20
oh
Gajo Petrovic
@gajop
Jul 14 2016 14:21
@Anarchid, keep in mind i'm not sure what to do with replays yet
GoogleFrog
@GoogleFrog
Jul 14 2016 14:21
its a thing modern games do
Анархид
@Anarchid
Jul 14 2016 14:21
i declared them to be a LaunchRemoteReplay thing
Gajo Petrovic
@gajop
Jul 14 2016 14:21
i deeply dislike working with protocols that have no design and i will not have one such thing forced on me
Анархид
@Anarchid
Jul 14 2016 14:22
default interface doesn't hook that to anything
lobby has that but doesn't see the zk url thing
zk interface handles sitetolobbycommand and turns it into launch remote replay
Gajo Petrovic
@gajop
Jul 14 2016 14:22
it's ok for the interface to have such things
but even the launch remote replay that i told you to implement is something that i'm not sure is right or not
Анархид
@Anarchid
Jul 14 2016 14:22
should i move it out of lobby and into interface?
Gajo Petrovic
@gajop
Jul 14 2016 14:23
no
if anything it must be part of lobby or nowhere
just go on as you are
Анархид
@Anarchid
Jul 14 2016 14:23
ok
maybe it makes sense to call it ugly
*to just
Gajo Petrovic
@gajop
Jul 14 2016 14:23
but keep in mind that it might be destroyed if we reconsider the whole "lobby server sends you command of what to do" and go for spring URLs or something
or we may make more things into something like that
Анархид
@Anarchid
Jul 14 2016 14:24
i think you're saying that i shouldn't rush to implement "site told you to host a map"
Gajo Petrovic
@gajop
Jul 14 2016 14:24
it's not a bad idea or anything but it's not discussed
you can implement it but i don't guarantee it's permanence
Анархид
@Anarchid
Jul 14 2016 14:24
i don't hold onto permanence
besides any replacement will likely reuse the code
Gajo Petrovic
@gajop
Jul 14 2016 14:25
i plan to have lobby protocol done by committee or at least consent
very likely yes
at least parts of it, but maybe not the callin itself
Анархид
@Anarchid
Jul 14 2016 14:25
the parts that do things
Gajo Petrovic
@gajop
Jul 14 2016 14:25
(the download part that's probably the hardest thing will)
i think so yes
i'm just giving you a heads up for other stuff like "Play on this map"
Анархид
@Anarchid
Jul 14 2016 14:26
i guess i'll replase -- MISCwith transient
Gajo Petrovic
@gajop
Jul 14 2016 14:27
although that one is probably OK if it can rely on existing commands
Анархид
@Anarchid
Jul 14 2016 14:27
that is -- TRANSIENT STUFF. DON'T LET THE EXISTENTIAL DREAD SET IN
GoogleFrog
@GoogleFrog
Jul 14 2016 14:27
do you think Spring will get URL opening?
Gajo Petrovic
@gajop
Jul 14 2016 14:27
90% politics
GoogleFrog
@GoogleFrog
Jul 14 2016 14:27
ofc
Gajo Petrovic
@gajop
Jul 14 2016 14:28
1% implementation, 9% debugging shit platforms
well i have push rights but i don't want to abuse them :D
i don't think it's a priority really, as long as you can copy the URL
GoogleFrog
@GoogleFrog
Jul 14 2016 14:29
I think its a really impotant lobby function
chat is perhaps the least important part of URL
Gajo Petrovic
@gajop
Jul 14 2016 14:29
so you aren't talking about chat URL?
GoogleFrog
@GoogleFrog
Jul 14 2016 14:30
a community MP lobby needs to open urls
Анархид
@Anarchid
Jul 14 2016 14:30
i don't think it's hard politically
not any harder than full http
Gajo Petrovic
@gajop
Jul 14 2016 14:30
can you give me a use case outside of chat URLs?
Анархид
@Anarchid
Jul 14 2016 14:30
open own profile page
Gajo Petrovic
@gajop
Jul 14 2016 14:30
i can think of a few but we don't have the UI (even planned) for it
Анархид
@Anarchid
Jul 14 2016 14:30
open guy profile page
open guy clan
Gajo Petrovic
@gajop
Jul 14 2016 14:30
profile page can be part of the lobby
same with replay/map/game lists
:p
GoogleFrog
@GoogleFrog
Jul 14 2016 14:31
later
Анархид
@Anarchid
Jul 14 2016 14:31
reimplementing zkinfo in lua will indeed obviate need for most non-chat links
GoogleFrog
@GoogleFrog
Jul 14 2016 14:39
outside URLs are used for links to community stuff
maps and games lists are likely not to be (fully) part of the lobby
replays are not either
tournaments and casts could be links
look at the dota news
reporting a player through the site is a reasonable implementation
ParzivalX
@ParzivalX
Jul 14 2016 14:42
Well
I went and learned some lua
So maybe I can actually do something on here now
GoogleFrog
@GoogleFrog
Jul 14 2016 14:42
Two of the current things in the middle of the Dota 2 screen are links to websites
the "your last game" could have a link to the replay site to comment on the game
injecting news, "tournament soon, sign up if you want"
chat urls are a relatively minor part of using browser stuff to make some sort of community integration lobby
Gajo Petrovic
@gajop
Jul 14 2016 14:44
also with URLs we can sell stuff
GoogleFrog
@GoogleFrog
Jul 14 2016 14:45
I can even see it being useful to games. report is there. Online guides?
a help submenu in the ingame menues which link to guides
Gajo Petrovic
@gajop
Jul 14 2016 14:46
i'm not sure what i'd put really
GoogleFrog
@GoogleFrog
Jul 14 2016 14:46
are you saying URLs are for games where you buy stuff?
I'm sure I could populate a help place
because ZK has stuff like that and I'm thinking game specific
Gajo Petrovic
@gajop
Jul 14 2016 14:48
nah i'm literally not sure what i'd put, since my first instinct for reports is ingame
GoogleFrog
@GoogleFrog
Jul 14 2016 14:48
did the gitter mess up?
download extra maps/replays. Forum link, wiki link, news link, upcoming tournament call to action
basically URLs give the community and events significantly better discoverability. Thats what you want for retention in a MP game
Gajo Petrovic
@gajop
Jul 14 2016 14:55
i think it's not that well defined
i've seen games do things arbitrarily
GoogleFrog
@GoogleFrog
Jul 14 2016 14:56
what do you mean?
Gajo Petrovic
@gajop
Jul 14 2016 14:56
some may put downloading extra maps/replays as well, even profile pages, news, stores.. etc.
all ingame
GoogleFrog
@GoogleFrog
Jul 14 2016 14:56
what is not well defined?
Gajo Petrovic
@gajop
Jul 14 2016 14:57
what belongs in the game and what should be provided with an extra URL
GoogleFrog
@GoogleFrog
Jul 14 2016 14:57
yes, there is no generic rule
but can you say that games should never have urls?
and I don't want to write a forum browser in lua
ZK has a forum that it is worthwhile linking to
Gajo Petrovic
@gajop
Jul 14 2016 14:58
the other question is what should be linked from within the lobby client
GoogleFrog
@GoogleFrog
Jul 14 2016 14:58
there are map existing sites to download maps and replays
Gajo Petrovic
@gajop
Jul 14 2016 14:58
idk how to make it obvious that something is a browser link
GoogleFrog
@GoogleFrog
Jul 14 2016 14:59
no its not. The question is whether something should be linked from within the lobby
that is not relevant
Gajo Petrovic
@gajop
Jul 14 2016 14:59
hm i mean
some things you may not want to link from within the lobby client at all, URL or directly
it's not uncommon to not have any links to forums
the assumption being that they already know the site (as that's where they got it from)
GoogleFrog
@GoogleFrog
Jul 14 2016 15:00
they may not have
but you're going with "some things you might"
Gajo Petrovic
@gajop
Jul 14 2016 15:01
well anyway
GoogleFrog
@GoogleFrog
Jul 14 2016 15:01
I think its clear enough that urls are useful for something
Gajo Petrovic
@gajop
Jul 14 2016 15:01
yeah
i'd like to know what they'd be used for first
so we have some idea of the urgency
GoogleFrog
@GoogleFrog
Jul 14 2016 15:01
why can't I say that they will definately be used for something?
something important
because there are multiple potentially important things they do. So the chance of one of those being important is high
Gajo Petrovic
@gajop
Jul 14 2016 15:02
because a lot of other issues are important and i need to prioritize
GoogleFrog
@GoogleFrog
Jul 14 2016 15:02
URL in chat is still fairly important for links to streams, from a community perspective with current operations
ok I'll put it somewhere
Gajo Petrovic
@gajop
Jul 14 2016 15:03
yeah but if that is the first thing (URL in chat) then it's really low in the priority list after i get text selection done..
we don't have a replays interface
GoogleFrog
@GoogleFrog
Jul 14 2016 15:04
can we VFS them?
Gajo Petrovic
@gajop
Jul 14 2016 15:04
probably should sit in the datadir
$DATADIR/demos
GoogleFrog
@GoogleFrog
Jul 14 2016 15:08
if they are already in VFS running them sounds easy enough
Gajo Petrovic
@gajop
Jul 14 2016 15:08
running yes, parsing, dunno
i'd like to show a "Your last match" in the status window after the first non-tutorial game
well for all proper games that is
and i think it would be nice if clicking on that would open something akin to the battleroom window with locked controls, and allowed you to play it
GoogleFrog
@GoogleFrog
Jul 14 2016 15:10
I'm counting things which require engines changes as significantly harder
Gajo Petrovic
@gajop
Jul 14 2016 15:10
with good reason :P
Анархид
@Anarchid
Jul 14 2016 15:11
spring replay format doesn't store metadata required to launch it easily
Gajo Petrovic
@gajop
Jul 14 2016 15:11
so how about we just have a "Watch replay of last game" or something like that?
Анархид
@Anarchid
Jul 14 2016 15:11
or, rather, expose it
Gajo Petrovic
@gajop
Jul 14 2016 15:11
oh it doesn't?
GoogleFrog
@GoogleFrog
Jul 14 2016 15:11
and possible impossible
Анархид
@Anarchid
Jul 14 2016 15:11
engine version
there's the naming format but it is not enforced
i can distribute a replay file called "lolreplay.sdfz" and it will run if the launching party knows what engine to execute on and which archives to obtain
Gajo Petrovic
@gajop
Jul 14 2016 15:12
i think they should fix that
and by they most likely me :x
GoogleFrog
@GoogleFrog
Jul 14 2016 15:12
engine changes may turn out to be impossible so I'd feel a lot better if the vital ones were done as soon as possible
Анархид
@Anarchid
Jul 14 2016 15:14
i've opened a replay file in mcview and it looks like the replay itself does contain the engine version
Gajo Petrovic
@gajop
Jul 14 2016 15:14
does it contain map and game at least?
i mean
the engine may know how to run it
Анархид
@Anarchid
Jul 14 2016 15:15
startscript does
Gajo Petrovic
@gajop
Jul 14 2016 15:15
ah there's a startscript?
Анархид
@Anarchid
Jul 14 2016 15:15
here's a head of that file http://hastebin.com/utekajifos.avrasm
and then a bit later http://hastebin.com/kesotofefe.hs
Gajo Petrovic
@gajop
Jul 14 2016 15:17
i see
Анархид
@Anarchid
Jul 14 2016 15:17
so theoretically you could use VFS to open a sdfz, get inside the binary sdf, and then find and parse the startscript from within the binary sdf
probably also read engine version somewhere around step 2-3
Gajo Petrovic
@gajop
Jul 14 2016 15:18
lol
Анархид
@Anarchid
Jul 14 2016 15:19
i trust lua should be fine with binary files because it has no problem saving them
unsure if vfs can unzip arbitrary zips tho
Gajo Petrovic
@gajop
Jul 14 2016 15:21
yes it can
Анархид
@Anarchid
Jul 14 2016 15:22
i guess i was wrong about no metadata
afaict games started with spring:// urls also save the proper startscript (host's one)
GoogleFrog
@GoogleFrog
Jul 14 2016 15:45
so its doable now?
once something is known to be possible with no engine changes I stop worrying about it
unless its something like a massive chili change
GoogleFrog
@GoogleFrog
Jul 14 2016 17:38
hmm you can't put issues in multiple milestones
the parallel nature of git is quickly forgotten by github
I think manditory requirements dominates my new milestone
but I'll leave it for now
Gajo Petrovic
@gajop
Jul 14 2016 18:11
well the alternative is to use labels...
Gajo Petrovic
@gajop
Jul 14 2016 18:17
i broke ZKS
Jose Luis
@TurBoss
Jul 14 2016 18:17
lol
Gajo Petrovic
@gajop
Jul 14 2016 18:17
Unterminated string. Expected delimiter: \". Path 'Text', line 1, position 184.\r\n at Newtonsoft.Json.JsonTextR
eader.ReadStringIntoBuffer(Char quote)\r\n at Newtonsoft.Json.JsonTextReader.ParseString(Char quote,
ReadType readType)\r\n at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)\r\n at
Newtonsoft.Json.JsonTextReader.ReadAsString()\r\n at Newtonsoft.Json.Serialization.JsonSerializerInternalR
eader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)\r\n at Newtonsoft.J
son.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader,
JsonObjectContract contract, JsonProperty member, String id)\r\n at Newtonsoft.Json.Serialization.JsonS
erializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty
member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)\r\n
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type
objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract,
JsonProperty containerMember, Object existingValue)\r\n at Newtonsoft.Json.Serialization.JsonSerializerI
nternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)\r\n at N
ewtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)\r\n at
Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)\r\n at
Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type)\r\n at LobbyClient.CommandJsonS
erializer.DeserializeLine(String line)\r\n at ZkLobbyServer.ClientConnection.<OnCommandReceived>d__11.M
oveNext()","Ring":false}
at least copy paste works
:P