These are chat archives for Spring-Chobby/Chobby

26th
Jul 2016
Gajo Petrovic
@gajop
Jul 26 2016 01:07
hey @ForbodingAngel . I'm not sure how skinning works and what are the limitations. I think skinning is mostly defined for existing controls (based on the class), so you might not be able to specify things like overlay windows
seems like that by looking in the code as well
i think there might be one solution to it, but it's fairly ugly: you could create different skins for specific things you want to see, e.g. a skin called "overlaywindow" much like there's "robocracy", and you basically tell the window to use the overlaywindow skin, e.g. skinname="overlaywindow"
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:16
@gajop Ok well
the controls seem to be defined in the skin file
Gajo Petrovic
@gajop
Jul 26 2016 01:17
you just define the rendering properties in the skin file
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:17

skin.window = {
TileImage = ":c:tech_dragwindow.png",
--TileImage = ":cl:tech_window.png",
--TileImage = ":cl:window_tooltip.png",
--tiles = {25, 25, 25, 25}, --// tile widths: left,top,right,bottom
tiles = {62, 62, 62, 62}, --// tile widths: left,top,right,bottom
padding = {13, 13, 13, 13},
hitpadding = {4, 4, 4, 4},

captionColor = {1, 1, 1, 0.45},

backgroundColor = {0.1, 0.1, 0.1, 0.7},

boxes = {
resize = {-21, -21, -10, -10},
drag = {0, 0, "100%", 10},
},

NCHitTest = NCHitTestWithPadding,
NCMouseDown = WindowNCMouseDown,
NCMouseDownPostChildren = WindowNCMouseDownPostChildren,

DrawControl = DrawWindow,
DrawDragGrip = function() end,
DrawResizeGrip = DrawResizeGrip,
}

Ok, somehting like this
Gajo Petrovic
@gajop
Jul 26 2016 01:18
it's like CSS i guess, but it's exclusively linked to control types, e.g. <div>, <p> or whatever
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:18
skin.window, now that has to relate to something because it's getting called somewhere. Are we sure that it's not more extensible?
for example, what is to prevent me from creating skin.overview_window
could it not be called in the same way that window is called?
or is there more to it than that?
Gajo Petrovic
@gajop
Jul 26 2016 01:19
an overview_window would basically never be used in the current way skins are loaded
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:19
Ok, fair nuff
ok then we need an alternate approach
Gajo Petrovic
@gajop
Jul 26 2016 01:20
well i wonder
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:20
for example, can we just define a backgroudn color for the panel?
Gajo Petrovic
@gajop
Jul 26 2016 01:20
what would happen if you overwrote classname=
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:20
so we can fake adding opacity to the panel?
For this particular excercist, lets focus exclusively on the tooltip
excercise*
Gajo Petrovic
@gajop
Jul 26 2016 01:20
can you make a skin.overview_window or whatever and i'll try to make controls use it?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:20
exercise* ffs
ok cool
can I have commit access so I can push the skin?
Gajo Petrovic
@gajop
Jul 26 2016 01:21
i might need to change chili a bit or it might work already but i don't think it was really intended
yeah
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:21
I can work in a branch
I'd prefer not to have to work in a fork as that would be really annoying
I'll push a skin branch to the remote repo if that is ok
Gajo Petrovic
@gajop
Jul 26 2016 01:22
just work directly in master so we don't waste time
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:22
oh ok
Gajo Petrovic
@gajop
Jul 26 2016 01:22
i invited you
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:22
ok gimmie a sec
Gajo Petrovic
@gajop
Jul 26 2016 01:22
do notice that the skin is in a separate folder
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:22
yeah :-)
The skin name is Evolved (drew a blank when it game to decent names)
Gajo Petrovic
@gajop
Jul 26 2016 01:23
as long as it's CC0 i don't care
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:25
pushed the default
Gajo Petrovic
@gajop
Jul 26 2016 01:25
please don't do Spring-Chobby/Chobby@4c3b718
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:25
let me add a skin.overview_window real quick
Gajo Petrovic
@gajop
Jul 26 2016 01:25
always git pull --rebase
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:26
ok will do
I'm sorry, I keep saying overview, I mean to say overlay
pushing
I need to figure out how to make an alias that pulls, rebases, then pushes
Gajo Petrovic
@gajop
Jul 26 2016 01:28
i like it, but you forgot some things
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:28
No I'm only like 1/3rd done
Gajo Petrovic
@gajop
Jul 26 2016 01:29
combobox, editbox and scrollpanel thing i think
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:29
I'm trying to figure out if this overlay thing can be done, cause if so that will affect how I do the rest
Gajo Petrovic
@gajop
Jul 26 2016 01:29
and well i think some buttons should be more visible
e.g. the Start button
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:29
if it can't be done, then I need to plan ahead for skin.window being used everywhere
Gajo Petrovic
@gajop
Jul 26 2016 01:29
ok so what should have the overlay thing?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:29
well, lets jsut try to make @GoogleFrog 's tooltip use it for now
if we can make that work, then we can use it for anything that is overlaid on top of chobby
If it works, we can also do special buttons, for getting user attention
kind of how Gmail has all the important buttons colored that orangish red, or blue to denote that they are important on the page you are looking at. It's a good ui scheme to use
Like I said, I'm maybe only like 1/3rd of the way through this. I'm taking my time and doing it right.
Gajo Petrovic
@gajop
Jul 26 2016 01:37
think i figured out how to do it, i needed to make a minor change in chili
so basically Spring-Chobby/Chobby@3933653 is how you'd do it
i think this is pretty close to html/css so should make most sense
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:42
nifty!
Ok this makes my life about 500000X better
Gajo Petrovic
@gajop
Jul 26 2016 01:42
i think i would prefer green/red/somethird color for most things
green for important & positive stuff, red for important & negative and third color for unimportant and neutral
well tbh as long as everything else is created around it well.. it shouldn't matter what color it is...
(changing should be a 10s thing)
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:43
Yeah, I agree
I'm trying to figure out a scheme
The color of text on buttons looks kinda nasty atm tbh
but that's an easy thing
Gajo Petrovic
@gajop
Jul 26 2016 01:44
it may take a bit of work getting it out of code and into skin
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:45
@gajop, some of these things desperately need spacing... How do we make that happen?
blob
Gajo Petrovic
@gajop
Jul 26 2016 01:45
i don't think settings are worth looking at atm
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:45
look at the combo boxes. They are boning the : preceding them
yes but it happens elsewhere too, but fair enough
notice the subtle lighting difference between the checkboxes on and off states. I liked that approach :-)
Gajo Petrovic
@gajop
Jul 26 2016 01:46
only way you can specify layout (unless you want some default padding values, which you probably shouldn't do in a skin) is to change the code
oh i didn't see that
i was really looking at the cross more
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:47
hehe :-)
ok for the colors, I'm going to make ctabutton1 - 3
Gajo Petrovic
@gajop
Jul 26 2016 01:48
i'll let you do that and then comment on the results :D
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:48
so then they can just be classname ctabutton1, ctabutton2, etc
haha ok
Gajo Petrovic
@gajop
Jul 26 2016 01:48
not sure what that'd mean
1,2,3
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:49
order of importance
primary secondary, tertiary
Gajo Petrovic
@gajop
Jul 26 2016 01:49
what's ctabutton stand for?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:49
is that too obscure?
call to action button
Gajo Petrovic
@gajop
Jul 26 2016 01:50
do you feel they should have order of importance?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:50
Essentially any button that intentionally stands out like that in web design is usually referred to as a call to action
Gajo Petrovic
@gajop
Jul 26 2016 01:50
i feel they should have type instead
maybe both :P
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:50
that would probably be more clear down the road
perhaps as types
Gajo Petrovic
@gajop
Jul 26 2016 01:50
by type i mean the positive/negative action thing
i dunno
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:50
we might have action, setting... ?
so then a color corresponds to what sort of action the button precipitates?
Gajo Petrovic
@gajop
Jul 26 2016 01:51
i think i'll just let you sort this out as you imagined it
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:51
As an idea, I really like it. I'm not sure how it comes out in practical application lol
Gajo Petrovic
@gajop
Jul 26 2016 01:51
it's probably not too hard to change eventually
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:52
true :-D
does chobby have a wiki?
Gajo Petrovic
@gajop
Jul 26 2016 01:52
nope, no time to write one atm
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:52
if so I will document the classes I add
for easy reference
Gajo Petrovic
@gajop
Jul 26 2016 01:52
sure go ahead
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:53
haha ok :-)
Gajo Petrovic
@gajop
Jul 26 2016 01:53
i wrote it early on to make sure everyone was on the same page, as i was getting many different opinions
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:53
Is it weird that I feel uncomfortable editing the wiki from a cloned repo?
I always do it view the web gui on github
dunno why
Gajo Petrovic
@gajop
Jul 26 2016 01:53
i don't know you can even edit it from a cloned repo
you have push rights, don't you?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:54
Oh really? Yeah you can edit the .md files directly, but tbh the md of github confuses me enough that I constantly have to reference sources to make sure I'm using it correctly
yes I do, thank you :-)
Gajo Petrovic
@gajop
Jul 26 2016 01:55
yes but wiki isn't a readme, it's not part of the source code
i don't think so at least? unless it's some sort of a hidden branch
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:56
It has it's own clone path
Github docu tells how to clone the wiki
I think it's just repopath/wiki iirc
Gajo Petrovic
@gajop
Jul 26 2016 01:57
oh
didn't know that
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:57
It's excellent if you have a bunch of info to put in quickly, such as transfer form another wiki or forum
Gajo Petrovic
@gajop
Jul 26 2016 01:59
should it be used for popup windows too?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 01:59
Yes, imo
even if you use the overlay effect on the rest of the screen, I believe we shoudl be uniform
I set the overlay opacity at 90%, realistically once we have it in common usage it could probably be lowered with no ill effects. I'm going to change it so that it has a colored outline though. The idea being to denote hover states. For example, hover over battle gets orange, tooltip gets a slightly more vibrant hue of orange to denote hover/layering
Shoudl result in nicer presentation
Passive hover state, that's what I was trying to think of*
So an overlay isn't a direct over state, but it is passively hovering. Hopefully that make sense. I'm taking a very microshaft/google approach to UI here, it seems to really help with intuitiveness.
Gajo Petrovic
@gajop
Jul 26 2016 02:07
right but should this be used for things like the login window, change map, and similar?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:08
Yes, exactly :-)
My description probably soudns all crazy. I promise that it will make sense when you see it
Gajo Petrovic
@gajop
Jul 26 2016 02:08
ok i pushed that then
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:09
yay good, thank you! :-D
ok @gajop, how about these colors for the button types: https://i.imgur.com/rPnywbP.png
I might need to adjust the hue a bit
Gajo Petrovic
@gajop
Jul 26 2016 02:10
what do they mean
if i go by traffic signs it's good/warning/bad
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:10
Orange would be used for something like start game
yellow for options stuffs
the greenish one for... I haven't figured that out yet lol
Gajo Petrovic
@gajop
Jul 26 2016 02:11
lol
well just by looking at the colors it seems like an arbitrary choice
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:11
Does that sound reasonable though? I mean we can always change them later, but on the face of it does that sound like a good plan?
Gajo Petrovic
@gajop
Jul 26 2016 02:12
idk what optional stuff is
i agree that stuff like "Start game" should have different color..
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:12
Map options, change map, erc
etc*
Gajo Petrovic
@gajop
Jul 26 2016 02:12
that's background we're talking?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:13
I think it would be smart to have a special button color for settings in the top right to draw attention to it
Yes
Gajo Petrovic
@gajop
Jul 26 2016 02:13
i think dark colors on a dark theme tend to be better for optional stuff
not super bright stuff like yellow
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:13
and the colors would be a bit more muted tbh
oh yes, absolutely
Gajo Petrovic
@gajop
Jul 26 2016 02:13
i do want a dark theme btw
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:13
image opacity on these colors being 0.5
Gajo Petrovic
@gajop
Jul 26 2016 02:13
but start can be orange (or whatever light color) so it stands out
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:13
and perhaps that brings it into a bit more clarity
I would say put start, settings and other 100% most important buttons as orange
well that goes against my scheme...
hmm, more thought is needed lol
Gajo Petrovic
@gajop
Jul 26 2016 02:15
i think start (important but action) needs to be different from singleplayer/multiplayer (important but menu item)
although tbh it'd be much better if we got a toggle button for play/watch thing, it's kinda confusing
maybe it should be a slide button, with Play being positive and Watch negative
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:16
ohhhh
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:16
That's a goood idea
how do you convert rgb to 1,1,1 again? is it #/255?
Gajo Petrovic
@gajop
Jul 26 2016 02:17
well the slide button is a checkbox as far as functionality goes, but needs special skin/rendering
yes /255
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:18
Yep
ok so let me test my theory...
Gajo Petrovic
@gajop
Jul 26 2016 02:19
i made like 15 issues in 1 day :c
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:21
lol
progress hurts
Gajo Petrovic
@gajop
Jul 26 2016 02:22
well i figure even if we do an early release to the ZK dev crowd it makes sense to polish as much as possible
i don't want to get reports about things we know
and telling the users you are aware about the issue makes you sound like a fool : why did you release if you knew it was bugged?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:23
yeah very true
hey riddle me somehting
I want to make overlay window a class that has a border color that is configurable via the skin like the buttons are
Gajo Petrovic
@gajop
Jul 26 2016 02:25
overlay window is not a class like a Window is, it's just a rendering class now
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:25
ahh ok, so any colors have to be hardcoded
well, that sucks, but at least I have my psd
Gajo Petrovic
@gajop
Jul 26 2016 02:26
you can override them for the specific instance
skin is just like a css
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:26
it doesn't seem to want to take a bordercolor
Gajo Petrovic
@gajop
Jul 26 2016 02:26
you don't define div/p/a/input or whatever html controls there
how did you write it?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:27
borderColor = {0.13,0.33,37,0.5},
Gajo Petrovic
@gajop
Jul 26 2016 02:27
i'm not sure windows have real borders
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:27
yeah that's what I was thinking
Gajo Petrovic
@gajop
Jul 26 2016 02:28
yep, they don't
function DrawWindow(obj)
  local w = obj.width
  local h = obj.height

  local skLeft,skTop,skRight,skBottom = unpack4(obj.tiles)

  local c = obj.color
  if (c) then
    gl.Color(c)
  else
    gl.Color(1,1,1,1)
  end
  TextureHandler.LoadTexture(0,obj.TileImage,obj)
    local texInfo = gl.TextureInfo(obj.TileImage) or {xsize=1, ysize=1}
    local tw,th = texInfo.xsize, texInfo.ysize

    gl.BeginEnd(GL.TRIANGLE_STRIP, _DrawTiledTexture, 0,0,w,h, skLeft,skTop,skRight,skBottom, tw,th)
  gl.Texture(0,false)

  if (obj.caption) then
    obj.font:Print(obj.caption, w*0.5, 9, "center")
  end
end
basically just one color
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:29
ok so here is my idea
the color is very muted
but see that the border is that drab greenish?
Gajo Petrovic
@gajop
Jul 26 2016 02:30
barely
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:30
yeah it's prolly too dark
but I'm sort of proofing concept here
Gajo Petrovic
@gajop
Jul 26 2016 02:31
why is there junk in that tooltip
i think it should be reported
battlename too long?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:31
because the title overran the line
yep
Gajo Petrovic
@gajop
Jul 26 2016 02:31
ok ill make one more issue for that and i'm going
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:31
hey
for a colored button, would it be best to copy paste the existing button code and go from there? That's what I had been planning on doing, but if there is already a better class to sue as a base, lemmie know
use*
oh and before you go, what widget controls that grey overlkay thing?
I need to fix it, cause it makes my eyeballs bleed
Gajo Petrovic
@gajop
Jul 26 2016 02:34

button code

do you mean the skin stuff? then yes

ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:34
ok, that takes care of first question then :-)
The grey here, what widget is drawing that?
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:35
awesome, thank you :-)
Gajo Petrovic
@gajop
Jul 26 2016 02:35
there needs to be something
maybe grey is not the color, but something
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:35
yes, I agree
I'm making it pretty
Gajo Petrovic
@gajop
Jul 26 2016 02:36
ok gtg, bb
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:36
kk take care
better outline color: https://i.imgur.com/83GcF33.png
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:51
@GoogleFrog do you know where the color setting is for the hover state on chili buttons? I have looked everywhere and I can't seem to find it. Is it hardcoded somewhere?
Gajo Petrovic
@gajop
Jul 26 2016 02:53
focusColor
ForbodingAngel
@ForbodingAngel
Jul 26 2016 02:53
ohhhhhhh
shit derp I see it now
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:17
So here is an example of action buttons: https://i.imgur.com/ggm85tE.png
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:24
I'm adding them to the wiki now
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:32
Gajo Petrovic
@gajop
Jul 26 2016 03:33
login/register/cancel looks weird
would prefer same color for login and register
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:34
I fixed the button widths
and that's fine
Gajo Petrovic
@gajop
Jul 26 2016 03:34
3 colors there looks like a flag ;P
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:34
you can use these where it is appropriate
THis is more of an example than anyhting
Gajo Petrovic
@gajop
Jul 26 2016 03:34
ok
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:34
Pushing
Gajo Petrovic
@gajop
Jul 26 2016 03:35
but also fix it anyway :p
3 colors one next to each other doesn't seem good
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:35
fix what, the 3?
Gajo Petrovic
@gajop
Jul 26 2016 03:35
ya
we are at the polish stage for this release so needs to be done soon anyway
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:35
I would tend to agree, but it's an easy way to see the buttons without referencing the wiki
shrug I;'ll comment them out
however
Gajo Petrovic
@gajop
Jul 26 2016 03:36
nah just make register same as login
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:36
login and register shouldn't share the same color imo
Gajo Petrovic
@gajop
Jul 26 2016 03:36
well
i think 3 of the different color look bad next to each other
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:36
Perhaps register should not have a color
Gajo Petrovic
@gajop
Jul 26 2016 03:36
no color is still a color :p
it might be better if layout were different..
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:37
I need to unfuck the default button, sec lol
I did it crappy
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:49
ok the default button is nicer now imo
I'll push
Gajo Petrovic
@gajop
Jul 26 2016 03:49
i can't test until later in the evening
ForbodingAngel
@ForbodingAngel
Jul 26 2016 03:54
no worries :-) It's a start anyway. I had planned to be able to move faster, but I kinda want to establish a standard so that later on down the line, ui elements are easy to work with and configure, so it's worth taking extra time imo to sort it all out.
Gajo Petrovic
@gajop
Jul 26 2016 04:00
a lot of things also probably belong to the skin, like control font and changing the button fonts when they're highlighted
ForbodingAngel
@ForbodingAngel
Jul 26 2016 04:20
@gajop Yeah they should. I haven't really dug into the fonts much yet. I've been too focused on the controls
And instead of font sizes and colors being defined in widgets, they should be classes designated by the skin
that way it's 100% uniform
Gajo Petrovic
@gajop
Jul 26 2016 04:25
might require some chili work to get that going
Gajo Petrovic
@gajop
Jul 26 2016 05:27
btw i think i'd be smart to have a few lines here (https://github.com/Spring-Chobby/Chobby/wiki/Additional-Chili-Classnames) that show how you can specify the render class (classname = X) and how new custom classes can be made (editing the skin.lua)
ForbodingAngel
@ForbodingAngel
Jul 26 2016 07:47
@gajop done
Gajo Petrovic
@gajop
Jul 26 2016 08:59
thanks, looks good
Jose Luis
@TurBoss
Jul 26 2016 10:27
yeah thats nice
Анархид
@Anarchid
Jul 26 2016 11:35
ohh components can now have different border-images>?
this somehow looks so wesnoth
Анархид
@Anarchid
Jul 26 2016 11:41
(not to say wesnoth is bad. wesnoth is gud)
Jose Luis
@TurBoss
Jul 26 2016 11:42
wesnoth is 1337
Анархид
@Anarchid
Jul 26 2016 11:44
ohhhh
components having extra border-images means i can add shadows
and "be materialish" this way
GoogleFrog
@GoogleFrog
Jul 26 2016 12:02
gitter history is really broken
I found more stuff as I scrolled up and down
don't assume I've read any particular thing
GoogleFrog
@GoogleFrog
Jul 26 2016 12:19
its a good thing we waited for forb for skinning
otherwise we wouldn't have got anything nearly as good
Gajo Petrovic
@gajop
Jul 26 2016 12:56
i was going to ask if you were sure you can handle all those issues you assigned yourself to but seems like you started multi-killing them in commits so i guess you're fine :p
would it be too much if i also asked for the ChangeMap dialog to scroll to the current map in a way that it's centered at the middle instead of the top?
Gajo Petrovic
@gajop
Jul 26 2016 13:02

gitter history is really broken

may be worth checking if your clocks are set correctly, i get something like this on skype due to misconfigured devices

GoogleFrog
@GoogleFrog
Jul 26 2016 13:12
skype wors
works
gitter seems to load in a weird order
I think I eventually get the whole history but it makes for a strange initial read
Gajo Petrovic
@gajop
Jul 26 2016 14:36
sigh
guess what happens when you try to copy unicode characters? :|
i feel perfecting textbox will take forever, especially when i get back to editing
i am after all basically making a text editor
Анархид
@Anarchid
Jul 26 2016 14:38
@gajop: they get split into bytes? :P
Gajo Petrovic
@gajop
Jul 26 2016 14:38
yep, e.g. 3: カ�
GoogleFrog
@GoogleFrog
Jul 26 2016 14:38
lua does not do unicode well
these tickets that are marked easy are a bit weird
because they require poking around in chili
so it takes me 5 minutes but someone new could not tackle it
Gajo Petrovic
@gajop
Jul 26 2016 14:39
right
i guess i forgot about that
at least the ones that i made recently, i just wrote what i think wouldn't take a lot of time
Gajo Petrovic
@gajop
Jul 26 2016 14:47
@GoogleFrog : when I copy some text from Debug into chat & try to type that, I get some server errors
This message was deleted
[23:47] <Say {"Place":5,"Target":"bobbyLikesChobby","User":"bobbyLikesChobby","IsEmote":false,"
Text":"[966 153.211.197.68:60644 bobbyLikesChobby] error processing line \\nText\\\":\\\"[966 
153.211.197.68:60644 bobbyLikesChobby] error processing line \\\\\\\\n,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"ClientT
ype\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":1 : System.Exception: Invalid json type LobbyClient.CommandJsonSerializer : 
\\nText\\\":\\\"[966\r\n   at LobbyClient.CommandJsonSerializer.DeserializeLine(String line)\r\n   at ZkL
obbyServer.ClientConnection.<OnCommandReceived>d__11.MoveNext()","Ring":false}
[23:47] <Say {"Place":5,"Target":"bobbyLikesChobby","User":"bobbyLikesChobby","IsEmote":false,"
Text":"[966 153.211.197.68:60644 bobbyLikesChobby] error processing line \\n,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"L
obbyVersion\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"ZK 1.3.2.12\\\\\\\",\\\\\\\"Ring\\\\\\\":false,\\\\\\\"T
arget\\\\\\\":\\\\\\\"cba\\\\\\\"} : System.Exception: Invalid  : System.Exception: Invalid json type 
LobbyClient.CommandJsonSerializer : \\n,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"LobbyVersion\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":\\\\\\\\\
\\\\\\\\\\\\\\\\\\\\\\"ZK\r\n   at LobbyClient.CommandJsonSerializer.DeserializeLine(String line)\r\n   at ZkL
obbyServer.ClientConnection.<OnCommandReceived>d__11.MoveNext()","Ring":false}
[23:47] <Say {"Place":5,"Target":"bobbyLikesChobby","User":"bobbyLikesChobby","IsEmote":false,"
Text":"[966 153.211.197.68:60644 bobbyLikesChobby] error processing line \\njson type 
LobbyClient.CommandJsonSerializer : \\\\\\\\n,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"ClientType\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":1
,\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"LobbyVersion\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\\\\\\ : System.Exception: Invalid json 
type LobbyClient.CommandJsonSerializer : \\njson\r\n   at LobbyClient.CommandJsonSerializer.D
eserializeLine(String line)\r\n   at ZkLobbyServer.ClientConnection.<OnCommandReceived>d__11.M
oveNext()","Ring":false}
not entirely sure if it's a server issue or how we're serializing the messages we send
Анархид
@Anarchid
Jul 26 2016 14:49
@gajop: speaking of unicode, iirc ZK does some escaping trickery for that
Gajo Petrovic
@gajop
Jul 26 2016 14:49
define ZK
Анархид
@Anarchid
Jul 26 2016 14:50
zk's internationalization thing as bridged with transifex
Gajo Petrovic
@gajop
Jul 26 2016 14:50
right
it's just not trivial to get number of chars in a string anymore
because you're not really working with unicode strings, but rather byte arrays
Анархид
@Anarchid
Jul 26 2016 14:52
i thought that'd be the problem
as in, you cannot define where the selection starts or ends
Gajo Petrovic
@gajop
Jul 26 2016 14:52
it's not impossible just not trivial
GoogleFrog
@GoogleFrog
Jul 26 2016 14:52
it sounds like you sent bad chat
Анархид
@Anarchid
Jul 26 2016 14:53
and then you also absolutely have to support zalgo, too
Gajo Petrovic
@gajop
Jul 26 2016 14:53
what is "bad" chat?
GoogleFrog
@GoogleFrog
Jul 26 2016 14:53
idk
some sort of server thing
I don't think you need to be able to send newlines
Gajo Petrovic
@gajop
Jul 26 2016 14:54
maybe it's that
Анархид
@Anarchid
Jul 26 2016 14:55
literal newline is not valid json
if lua escapes \n and you told lua to send a string containing "\n", it escaped that string and turned it into a literal newline
Gajo Petrovic
@gajop
Jul 26 2016 14:55
@GoogleFrog can you revert the editbox.lua change? it introduced new issues
now every time you press enter in chat it'll popup the default engine chat because editbox no longer handles it
GoogleFrog
@GoogleFrog
Jul 26 2016 14:56
unbind engine chat
enter needs to get past editbox for priority popup
rebind engine chat when debug mode is ticked
Gajo Petrovic
@gajop
Jul 26 2016 14:57
can't you just handle it in keypress and forward to priority popup?
GoogleFrog
@GoogleFrog
Jul 26 2016 14:58
no, that would not be nice
the handling would need to be added to every editbox that appears in a popup
Gajo Petrovic
@gajop
Jul 26 2016 15:01
well it breaks chat input, chonsole and probably other projects that'd use this chili
GoogleFrog
@GoogleFrog
Jul 26 2016 15:04
so you want to eat all input?
Gajo Petrovic
@gajop
Jul 26 2016 15:04
no, i'm thinking
GoogleFrog
@GoogleFrog
Jul 26 2016 15:04
because currently it does nothing with enter so I don't see why it eats it
Gajo Petrovic
@gajop
Jul 26 2016 15:05
it should definitely be possible to specify what input it eats
the obvious being "eat all input that it handles"
but now it's weird
it's not eating enter but it's still sending OnKeyPress events
i don't think it should be sending those events if it's not eating the input
uh oh wait a sec
lol well i'm a fucking idiot
so there's a way to specify when it eats input..
always was there, just didn't read the code
Gajo Petrovic
@gajop
Jul 26 2016 15:10
it seems that if you return something in those OnKeyPress calls (or whatever) you can make it "eat the input"
i think editbox now needs to be cleansed from eating keys it doesn't process
there should just be no mention of enter/esc or whatever, everything that's not processed should result in not eating the input, and if the user wants to eat the input, they can be specific about it
GoogleFrog
@GoogleFrog
Jul 26 2016 15:12
yea
Gajo Petrovic
@gajop
Jul 26 2016 15:12
imo not a priority unless we'll be doing shortcuts for this release
GoogleFrog
@GoogleFrog
Jul 26 2016 16:23
ok, Time
thats the issues for today I think
Gajo Petrovic
@gajop
Jul 26 2016 16:24
i'm pretty close to finalizing the updatelayout thing but probably tomorrow
fixed it actually but now fixing selection ;..;
GoogleFrog
@GoogleFrog
Jul 26 2016 16:25
I'm not sure about the colours of the Action, Negative and Thingy buttons
Gajo Petrovic
@gajop
Jul 26 2016 16:25
i don't think login/register/cancel colors are good if that's what you mean
GoogleFrog
@GoogleFrog
Jul 26 2016 16:26
yea
but I applied them elsewhere too
Gajo Petrovic
@gajop
Jul 26 2016 16:26
e.g.?
GoogleFrog
@GoogleFrog
Jul 26 2016 16:26
well Leave and Close buttons got negative
I gave action to Start
and action to the accept button of popups
Gajo Petrovic
@gajop
Jul 26 2016 16:26
ah i didn't pull..
GoogleFrog
@GoogleFrog
Jul 26 2016 16:27
and Thingy to Host Game
Gajo Petrovic
@gajop
Jul 26 2016 16:27
Start really needs padding at least
GoogleFrog
@GoogleFrog
Jul 26 2016 16:28
yea, or biggening
Gajo Petrovic
@gajop
Jul 26 2016 16:28
host game is OK
GoogleFrog
@GoogleFrog
Jul 26 2016 16:28
I guess start is the weird one for me
I'd just make it green
Gajo Petrovic
@gajop
Jul 26 2016 16:28
kinda weird yes
feels like it's focused/highlighted
GoogleFrog
@GoogleFrog
Jul 26 2016 16:29
yes
the new skin has a lot less padding around the images
Gajo Petrovic
@gajop
Jul 26 2016 16:33
btw should definitely comment out the debug info in the tutorial so it can be reviewed
hard to judge right now
GoogleFrog
@GoogleFrog
Jul 26 2016 16:33
what?
what is the tutorial?
Gajo Petrovic
@gajop
Jul 26 2016 16:33
blah
user tooltip window
GoogleFrog
@GoogleFrog
Jul 26 2016 16:33
just disable debug mode
Gajo Petrovic
@gajop
Jul 26 2016 16:33
oh?
duh
ForbodingAngel
@ForbodingAngel
Jul 26 2016 17:27
@GoogleFrog the other chili skins use padding incorrectly
What I men is that they have been hard coding padding in the image
This is why robocracy looks awful in some situations. Padding needs to apply to the text or elements inside the containers, and margins are outside of the containers
Chili doesn't seem to have a function for margins which is unfortunate, but manually putting in margins via the images is an awful idea. So basically if you need margins outside of containers, then your spacing is bad. Hopefully that makes sense.
As far as the colors go, they need to be vibrant yet drab. If you have any suggestions, let me know, but it's important that the buttons are not like a slap in the face of color, but they do need to be nice and vibrant. Pastels make for good color choices. But like I said if you have suggestions lemme know so I can try them out.
ForbodingAngel
@ForbodingAngel
Jul 26 2016 17:33
Additionally there are a lot of elements that I haven't even touched yet. I would estimate that I'm maybe 50% done :-)