These are chat archives for Spring-Chobby/Chobby

4th
Sep 2016
GoogleFrog
@GoogleFrog
Sep 04 2016 04:24
how do i go about replacing master?
L.J. Lim
@KingRaptor
Sep 04 2016 04:44
GoogleFrog do you still need missions for launcher test?
GoogleFrog
@GoogleFrog
Sep 04 2016 05:06
I can download some from the site
I'm not currently working on that though
Gajo Petrovic
@gajop
Sep 04 2016 06:22
Btw I think it's not horrible if both lobby and game are same mode (full screen or windowed). I'd make that the default too
GoogleFrog
@GoogleFrog
Sep 04 2016 06:27
what is horrible?
afaik that is the default
do you know how to use Spring.Reload to start replays?
I don't want to parse the replay to get something as large as this https://github.com/spring/spring/blob/103.0/doc/StartScriptFormat.txt
Gajo Petrovic
@gajop
Sep 04 2016 06:28
Him, I don't, no. Might not be possible ATM
GoogleFrog
@GoogleFrog
Sep 04 2016 06:28
and afaik the other way to start replays is with command line, which reload does not do
its surely possible
GoogleFrog
@GoogleFrog
Sep 04 2016 06:48
are you going to kill master?
I've committed my WIP in case you do
I'll wait for ZKS to come back up to work on replays
GoogleFrog
@GoogleFrog
Sep 04 2016 08:17
this replay widget sucks
too many globals
GoogleFrog
@GoogleFrog
Sep 04 2016 08:55
@gajop do you know how to make spring look inside a replay zip?
basically I want to un-7z a replay to get at its script
Gajo Petrovic
@gajop
Sep 04 2016 11:55
@GoogleFrog did you figure it out?
you may be capable of loading the file like a regular archive
in particular I mean VFS.UseArchive or VFS.MapArchive from https://springrts.com/wiki/Lua_VFS
GoogleFrog
@GoogleFrog
Sep 04 2016 12:09
it was not required
GoogleFrog
@GoogleFrog
Sep 04 2016 12:44
there are only 3 issues left
one is graphicy
and the other two are testing-related
Eshed
@ashdnazg
Sep 04 2016 16:55
@GoogleFrog why do you want the script?
also the archive things won't work there
GoogleFrog
@GoogleFrog
Sep 04 2016 16:57
that was before
Eshed
@ashdnazg
Sep 04 2016 16:58
ah
ok
Gajo Petrovic
@gajop
Sep 04 2016 17:32
btw hoko, i can't compile the new engine anymore
/home/gajop/opt/bin/spring: error while loading shared libraries: libGLEW.so.1.12: cannot open shared object file: No such file or directory
or rather
i can compile it but not run it
Eshed
@ashdnazg
Sep 04 2016 17:39
what was the latest engine you could compile?
(or run)
Gajo Petrovic
@gajop
Sep 04 2016 17:39
i'm not sure :/
103 worked
Eshed
@ashdnazg
Sep 04 2016 17:40
well, I'm no aware of any change we made to libs path
are you sure you didn't change LDPATH or whatever it is called on your machine?
Gajo Petrovic
@gajop
Sep 04 2016 17:40
this worked for sure spring/spring@0564491
i didn't do anything manually
i don't even have new libglew
erm
i don't have the old one
i have 2.0 on my system
Eshed
@ashdnazg
Sep 04 2016 17:42
wat
Gajo Petrovic
@gajop
Sep 04 2016 17:42
ls /usr/lib/libGLEW.so*
/usr/lib/libGLEW.so /usr/lib/libGLEW.so.2.0 /usr/lib/libGLEW.so.2.0.0
Eshed
@ashdnazg
Sep 04 2016 17:42
well, if you can bisect the commit which stopped working it may be easier to assist
Gajo Petrovic
@gajop
Sep 04 2016 17:42
might be my system that went bonkers
Gajo Petrovic
@gajop
Sep 04 2016 17:57
so much stuff is broken :C
ZKS seems down
can't run compiled engines
starting ZK gives me no UI
not sure if i'm even running a proper version of ZK
[f=-000001] [liblobby] Error: [string "LuaMenu/Widgets/gui_battle_room_window.lua"]:1202: bad argument #2 to 'find' (string expected, got nil)
stack traceback:
        [string "libs/liblobby/lobby/observable.lua"]:49: in function '_PrintError'
        [string "libs/liblobby/lobby/observable.lua"]:43: in function <[string "libs/liblobby/lobby/observable.lua"]:43>
        [C]: in function 'find'
        [string "LuaMenu/Widgets/gui_battle_room_window.lua"]:1202: in function 'listener'
        [string "libs/liblobby/lobby/observable.lua"]:42: in function <[string "libs/liblobby/lobby/observable.lua"]:42>
        [C]: in function 'xpcall'
        [string "libs/liblobby/lobby/observable.lua"]:42: in function '_CallListeners'
        [string "libs/liblobby/lobby/lobby.lua"]:655: in function '_OnSaidBattleEx'
        [string "libs/liblobby/lobby/interface_skirmish.lua"]:159: in function 'StartBattle'
        [string "LuaMenu/Widgets/gui_battle_room_window.lua"]:188: in function 'eventListener'
        [string "libs/chiliui/LuaMenu/chili/chili/controls/o..."]:659: in function 'CallListeners'
        [string "libs/chiliui/LuaMenu/chili/chili/controls/o..."]:913: in function <[string "libs/chiliui/LuaMenu/chili/chili/controls/o..."]:912>
        (tail call): ?
        [string "libs/chiliui/LuaMenu/chili/chili/controls/s..."]:253: in function <[string "libs/chiliui/LuaMenu/chili/chili/controls/s..."]:233>
        (tail call): ?
        [C]: in function 'cdxpcall'
        [string "libs/chiliui/LuaMenu/chili/chili/handlers/d..."]:239: in function <[string "libs/chiliui/LuaMenu/chili/chili/handlers/d..."]:232>
        (tail call): ?
        (tail call): ?
        [C]: in function 'pcall'
        [string "LuaHandler/Utilities/crashHandler.lua"]:102: in function 'SafeCallAddon'
        [string "LuaHandler/Utilities/specialCallinHandlers...."]:229: in function <[string "LuaHandler/Utilities/specialCallinHandlers...."]:218>
[f=-000001] [ReloadOrRestart] Spring "/home/gajop/spring-statics/spring" should be reloading
ZK cant load unitrendering (wrong ZK version..?)
Eshed
@ashdnazg
Sep 04 2016 17:58
update ZK
also update CUS
someone put there an Include with VFS.BASE
Gajo Petrovic
@gajop
Sep 04 2016 17:59
what does that even do
Eshed
@ashdnazg
Sep 04 2016 17:59
it worked when VFS.BASE and VFS.MOD had the same effect
it only loads stuff from base content (springcontent, cursors, maphelper)
Gajo Petrovic
@gajop
Sep 04 2016 18:00
updated my ZK but it's still running the old version
Eshed
@ashdnazg
Sep 04 2016 18:00
change in settings
Gajo Petrovic
@gajop
Sep 04 2016 18:00
probably it doesn't know how to start zk:stable
Eshed
@ashdnazg
Sep 04 2016 18:00
to use Zero-K dev
if you have a ZK sdd
Gajo Petrovic
@gajop
Sep 04 2016 18:00
aha
Eshed
@ashdnazg
Sep 04 2016 18:00
some very nice feature by GoogleFrog
also, is there any idea why Chobby uses so much memory?
GoogleFrog
@GoogleFrog
Sep 04 2016 18:04
ZKS is restarting for some bugfix release
Chobby doesn't seem to be using more memory than I expect from chili
Gajo Petrovic
@gajop
Sep 04 2016 18:04
i can't get ZK to run properly
GoogleFrog
@GoogleFrog
Sep 04 2016 18:04
idk, I am off to bed
i'm starting to think there are some memory leaks
we used to have a bug
Spring-Chobby/Chobby#76 thing
and we aren't having it anymore
i think we just hid it under the rug with that
Eshed
@ashdnazg
Sep 04 2016 18:06
I don't know
Gajo Petrovic
@gajop
Sep 04 2016 18:06
the actual cause is causing the high CPU usage, and maybe even high memory too
Eshed
@ashdnazg
Sep 04 2016 18:06
it's possible that the GC isn't called when in luamenu
I'll check
Gajo Petrovic
@gajop
Sep 04 2016 18:06
i'm just guessing
Eshed
@ashdnazg
Sep 04 2016 18:06
(isn't called automatically)
Gajo Petrovic
@gajop
Sep 04 2016 18:06
we never figured out what was the root
Eshed
@ashdnazg
Sep 04 2016 18:07
GC should only remove things which aren't in use
so it's not a leak
no idea really
yea, GC isn't called automatically
Eshed
@ashdnazg
Sep 04 2016 18:13
k, this should make situation prettier spring/spring@5ac4b4c
Gajo Petrovic
@gajop
Sep 04 2016 18:14
downloads are indeed not working well
Eshed
@ashdnazg
Sep 04 2016 18:14
they are working
but no progress is shown
the callin is called
Gajo Petrovic
@gajop
Sep 04 2016 18:14
is it?
Eshed
@ashdnazg
Sep 04 2016 18:14
yes
I've checked with an echo in gui_chili_lobby.lua
it's possible that I've messed up with the timers
ah
I think I know the reason
Gajo Petrovic
@gajop
Sep 04 2016 18:17
should be < ?
Eshed
@ashdnazg
Sep 04 2016 18:18
yup
my fault
pushed
and I've checked the rest which seem to be correct
Gajo Petrovic
@gajop
Sep 04 2016 18:20
what am i doing wrong with ZK?
is the multiplayer not supposed to work?
Eshed
@ashdnazg
Sep 04 2016 18:20
question unclear
Gajo Petrovic
@gajop
Sep 04 2016 18:21
i hosted an MP game and there is still no ingame UI
i thought if it were an MP game that would solve itself out
zooming in is also quite laggy
Eshed
@ashdnazg
Sep 04 2016 18:21
maybe wrong ZK version?
Gajo Petrovic
@gajop
Sep 04 2016 18:21
/quitmenu seems to work at least
idk, i hosted online?
Eshed
@ashdnazg
Sep 04 2016 18:22
which means you version isn't up to date with dev engine
use !game zk:dev
Gajo Petrovic
@gajop
Sep 04 2016 18:22
ah
Eshed
@ashdnazg
Sep 04 2016 18:22
should set it to use $VERSION
Gajo Petrovic
@gajop
Sep 04 2016 18:22
i wanted to avoid that lol
should !game zk:test work?
Eshed
@ashdnazg
Sep 04 2016 18:23
yes
Gajo Petrovic
@gajop
Sep 04 2016 18:23
doesn't seem so :(
Eshed
@ashdnazg
Sep 04 2016 18:23
worked for me
what happened when you tried?
Gajo Petrovic
@gajop
Sep 04 2016 18:23
same thing, no UI
Eshed
@ashdnazg
Sep 04 2016 18:23
I'll check
Gajo Petrovic
@gajop
Sep 04 2016 18:24
and very choppy
[f=-000001] Warning: Unable to open archive: Zero-K test-11335-170f3a5
[f=-000001] [ArchiveScanner] Warning: Zero-K test-11335-170f3a5 checksum: not found (0)
probably not a bug
Eshed
@ashdnazg
Sep 04 2016 18:25
this is false alarm
I have UI
if no UI you should have errors
Gajo Petrovic
@gajop
Sep 04 2016 18:26
seems it's a different version
now it's trying to download something else
Eshed
@ashdnazg
Sep 04 2016 18:26
...
Gajo Petrovic
@gajop
Sep 04 2016 18:26
����[03:25] �
sigh
Eshed
@ashdnazg
Sep 04 2016 18:26
and yes, FPS seems not very great
Gajo Petrovic
@gajop
Sep 04 2016 18:27
Zero-K test-11338-729146d
now
Eshed
@ashdnazg
Sep 04 2016 18:27
luamenu needs to chill
Gajo Petrovic
@gajop
Sep 04 2016 18:27
Zero-K test-11335-170f3a5 <- before
Eshed
@ashdnazg
Sep 04 2016 18:27
that one should work
Gajo Petrovic
@gajop
Sep 04 2016 18:27
nope
Eshed
@ashdnazg
Sep 04 2016 18:28
I'm running it now
(11338)
and it does work
anyway, chobby needs to get some serious perf improvements
oh wait!
sorry
I was using a debug engine version
lol
Gajo Petrovic
@gajop
Sep 04 2016 18:29
heh
so it's that?
Eshed
@ashdnazg
Sep 04 2016 18:29
I'll try with a release one
will take some time
Gajo Petrovic
@gajop
Sep 04 2016 18:29
i'll grab a shower in the meanwhile
anyway
Eshed
@ashdnazg
Sep 04 2016 18:30
have fun
Gajo Petrovic
@gajop
Sep 04 2016 18:30
perf will remain an issue with luamenu.. always
Eshed
@ashdnazg
Sep 04 2016 18:30
why?
Gajo Petrovic
@gajop
Sep 04 2016 18:30
no multithreading
Eshed
@ashdnazg
Sep 04 2016 18:30
you can reuse tables
Gajo Petrovic
@gajop
Sep 04 2016 18:30
what?
Eshed
@ashdnazg
Sep 04 2016 18:30
and code efficient lua code
luamenu will obviously cost perf, but it doesn't have to be a lot of it
Gajo Petrovic
@gajop
Sep 04 2016 18:31
fix usertt
Spring-Chobby/Chobby#46
that increased performance by a tenfold
but we can optimize all we want, it'll still be a noticeable performance hit
it's odd though that it's still hurting so much when nothing is being rendered
Eshed
@ashdnazg
Sep 04 2016 18:35
the issue seems to be GC
there's probably something (a loop?) that creates many tables/funcs which aren't reused over frames
or over iterations
Gajo Petrovic
@gajop
Sep 04 2016 18:48
i'd delete that widget for forcing GC to expose the problem
Eshed
@ashdnazg
Sep 04 2016 18:50
I can't see how this will expose it
Gajo Petrovic
@gajop
Sep 04 2016 18:51
because that was just hiding another issue
Eshed
@ashdnazg
Sep 04 2016 18:51
I'm now collecting every frame in the menu anyway
so that won't help
and in the game it may be more complex
Gajo Petrovic
@gajop
Sep 04 2016 18:52
collecting every frame?
Eshed
@ashdnazg
Sep 04 2016 18:52
what I suggest is to create a memory profiler
like the widget profiler hook into the callins
Gajo Petrovic
@gajop
Sep 04 2016 18:52
ok if you can, go ahead
Eshed
@ashdnazg
Sep 04 2016 18:53
haha
it's code you wrote
Gajo Petrovic
@gajop
Sep 04 2016 18:53
what is?
Eshed
@ashdnazg
Sep 04 2016 18:53
I assumed you'd want to debug it yourself
the lobby?
I've barely written 20 lines of code in Chobby
Gajo Petrovic
@gajop
Sep 04 2016 18:54
oh i hadn't really considered that it might be something i'm causing :P
Eshed
@ashdnazg
Sep 04 2016 18:54
it will take me far more time to figure what's calling what and where
Gajo Petrovic
@gajop
Sep 04 2016 18:54
but this (Spring-Chobby/Chobby#76) is a particular bug
which happens immediately after starting it
Eshed
@ashdnazg
Sep 04 2016 18:54
very weird
Gajo Petrovic
@gajop
Sep 04 2016 18:55
but not always
sometimes
and i have no idea under what conditions
i mean sure, maybe i'm creating some tables that i shouldn't be, and i should be reusing some instead
a pretty common thing which creates a new table each time listeners are called
Eshed
@ashdnazg
Sep 04 2016 18:56
nah, this is minor
also note that I've moved the local args = {...} outside the loop
so it was slightly worse earlier
Gajo Petrovic
@gajop
Sep 04 2016 18:57
yeah that looks bad
they weren't even local
Eshed
@ashdnazg
Sep 04 2016 18:57
in the deed
Gajo Petrovic
@gajop
Sep 04 2016 18:58
but i don't think that's all that important
Eshed
@ashdnazg
Sep 04 2016 18:58
you know the things which are called often in the lobby
Gajo Petrovic
@gajop
Sep 04 2016 18:58
it has nothing to do with mouse zoom lagging
Eshed
@ashdnazg
Sep 04 2016 18:58
I had no zoom lagging
Gajo Petrovic
@gajop
Sep 04 2016 18:58
well i don't even have a UI
Eshed
@ashdnazg
Sep 04 2016 18:59
I had 125 FPS or something
zk:test
Gajo Petrovic
@gajop
Sep 04 2016 18:59
how do i even show fps?
i did
Eshed
@ashdnazg
Sep 04 2016 18:59
when a game is running
if you didn't have gui in zk:test you should check the infolog for errors
Gajo Petrovic
@gajop
Sep 04 2016 18:59
i did, i found nothing related
Eshed
@ashdnazg
Sep 04 2016 19:00
did you put on pastebin and asked me to take a look?
Gajo Petrovic
@gajop
Sep 04 2016 19:04
where is the infolog..
siigh
oh yeah, that 4th spring datadir folder i have
it's 4AM, i'm grumpy
[f=-000001] Connecting to battle, Zero-K test-11338-729146d, DesertTriad, 103.0.1-95-g20ebb8c
hopefully that's not wrong
maybe there are some newer engines now
Gajo Petrovic
@gajop
Sep 04 2016 19:09
ok sleep time for me, gl
Eshed
@ashdnazg
Sep 04 2016 19:24
everything seems ok, seriously no idea