Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 04 12:35
    Damgam opened #487
  • Aug 24 05:54
    ForbodingAngel commented #486
  • Aug 24 05:54
    ForbodingAngel commented #486
  • Aug 23 13:08
    Anarchid commented #486
  • Aug 23 13:08
    Anarchid commented #486
  • Aug 23 02:01
    ForbodingAngel edited #486
  • Aug 23 02:01
    ForbodingAngel milestoned #486
  • Aug 23 02:01
    ForbodingAngel opened #486
  • Aug 21 03:12
    gajop commented #484
  • Aug 21 03:09
    gajop opened #485
  • Aug 21 01:31
    MaDDoXbr commented #484
  • Aug 20 21:52
    gajop commented #484
  • Aug 20 21:52

    gajop on master

    remove tc config https://github… (compare)

  • Aug 20 20:35
    azaremoth commented #484
  • Aug 19 13:43

    gajop on master

    disable analytics if wrapper do… (compare)

  • Aug 18 15:21
    gajop commented #482
  • Aug 18 15:21
    gajop closed #482
  • Aug 18 09:26

    gajop on master

    remove trailing ws (compare)

  • Aug 18 08:18

    gajop on master

    add sl log uploading functional… (compare)

  • Aug 18 08:11

    gajop on master

    basic spring-launcher connectiv… (compare)

Gajo Petrovic
@gajop
i think it requires a bit more thinking to separate between logical and physical lines
so selection and stuff works..
GoogleFrog
@GoogleFrog
how is it enabled?
Gajo Petrovic
@gajop
what? UpdateLayout?
GoogleFrog
@GoogleFrog
yes
Gajo Petrovic
@gajop
by me pushing a commit :p
GoogleFrog
@GoogleFrog
can you push it?
did you see my comments on the settings ticket? I think you should add the ability to edit springsettings regardless of whether we eventually can set a startscript
because I also want to read springsettings and don't know how to deal with settings in replays
Gajo Petrovic
@gajop
i might have some time to get back to it later tonight
not being able to set settings in a script (for replays) can be an issue
i guess the ideal solution would be to really fix SetConfig* stuff
GoogleFrog
@GoogleFrog
I don't trust that SetConfig will work
GoogleFrog
@GoogleFrog
would you make the simple change soon?
Gajo Petrovic
@gajop
soonest i can do is tonight, am going to work soon
if it's a problem, you can revert the whole thing locally
GoogleFrog
@GoogleFrog
I mean the spring change
Gajo Petrovic
@gajop
aha
Gajo Petrovic
@gajop
idk if i'm allowed to do that
i can make a PR and see
i'm not going to change it directly with my push rights
lest they be taken away :p
GoogleFrog
@GoogleFrog
abma seemed to not be able to make sense of the change and did not know why it was there
Gajo Petrovic
@gajop
i guess the idea is if you change certain settings a malicious widget could go wild
and maybe SetConfig doesn't allow you to set arbitrary things
i think the problem stems from the way of thinking that widgets are made by player-made mods, rather than parts of the game
probably will run into the same thing when we try to do the URL stuff
GoogleFrog
@GoogleFrog
yes
a widget could currently rewrite a dll
Gajo Petrovic
@gajop
idk how the steam workshop works, but usually games have good sandboxes to prevent malicious stuff
i guess game widgets or widgets with special permissions granted by the user (or whitelisted by the game) should have free reign, but normal widgets really shouldn't
maybe i should do the politics PRs sooner rather than later
since i'd take time for them to be discussed and merged
GoogleFrog
@GoogleFrog
yes
gajop @gajop goes afk for a while
GoogleFrog
@GoogleFrog
well we want urls and settings in 2 weeks apparently
and making SetConfig functional has a high risk of breaking other things
GoogleFrog
@GoogleFrog
I'd really like the text box changes to not require skin changes
Gajo Petrovic
@gajop
it needs them
otherwise it's draw to look like an editbox
the borderColor and other stuff from the editbox's skin override anything you set
GoogleFrog
@GoogleFrog
if editBox always contains those settings then it should be in the control
and the text box inheritance can override that to 0
Gajo Petrovic
@gajop
idk if it does or not, i went with what was in place; the same settings are in the robocracy skin
not yet sure how to deal with this
i think it's not intuitive to override editbox and have changes happen in the textbox as well
one solution is to introduce a trully abstract class for both editbox and textbox, something akin to textcontrol
GoogleFrog
@GoogleFrog
that sounds good
Анархид
@Anarchid