by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 24 10:50

    gajop on master

    Uparrow/downarrow in console au… Changes requested by PR: - Rev… Fix whitespace and 3 more (compare)

  • May 24 10:50
    gajop closed #513
  • May 24 10:50
    gajop closed #511
  • May 24 03:32
    GoogleFrog synchronize #511
  • May 23 00:23
    GoogleFrog synchronize #511
  • May 22 03:00
    GoogleFrog synchronize #511
  • May 22 02:05
    GoogleFrog synchronize #511
  • May 21 02:08
    MasterBel2 commented #496
  • May 20 13:53
    gajop commented #495
  • May 20 13:52
    gajop commented #496
  • May 20 13:50
    gajop closed #484
  • May 20 13:49
    MaDDoXbr commented #484
  • May 20 09:47
    GoogleFrog synchronize #511
  • May 20 06:47
    silentwings commented #462
  • May 20 06:45
    silentwings commented #490
  • May 20 06:44
    silentwings commented #490
  • May 20 06:43
    silentwings commented #490
  • May 20 06:11
    MasterBel2 synchronize #513
  • May 20 06:03
    MasterBel2 commented #496
  • May 20 06:02
    MasterBel2 commented #496
Gajo Petrovic
@gajop
can it be made not to cause it?
Eshed
@ashdnazg
unfortunately no
Gajo Petrovic
@gajop
;(
Eshed
@ashdnazg
limiting ourselves to the LuaMenu folders saves lives
or at least my life :P
Gajo Petrovic
@gajop
i'm already very worried with things becoming too diverging to merge upstream
liblobby not so much, but chili in particular
in general i want to have stuff in libs/ identical to upstream stuff
or in a way that they can be merged
Eshed
@ashdnazg
makes sense
hmm
you may be right
if chili is used in unsynced luarules it can't be in the luaui folders
anyway
I think libs should be outside the environments
Gajo Petrovic
@gajop
i think we basically want the menu not to pollute VFS of games
what do you mean?
Eshed
@ashdnazg
absolutely
Gajo Petrovic
@gajop

absolutely

so that's already the status quo?

Eshed
@ashdnazg
mostly yes
synced lua code can't read from luamenu
and I've moved all stuff to the luamenu dirs
so they don't accidentally mingle
Gajo Petrovic
@gajop
oh so it's still merging the two VFS?
Eshed
@ashdnazg
no
you can choose
but unfortunately it proved impossible to make VFS.ZIP exclude lua menu
Gajo Petrovic
@gajop
that sounds like a 'yes' to me?
Eshed
@ashdnazg
no
Gajo Petrovic
@gajop
if you can access luamenu stuff from game
not talking about variables
Eshed
@ashdnazg
now VFS.MOD will not read MENU stuff
Gajo Petrovic
@gajop
ok
that's good
it's actually pretty good if we can choose also but optional
Eshed
@ashdnazg
every bit of unsynced code which doesn't specify the mode or which specified VFS.ZIP (or VFS.RAW_FIRST) will read from menu archive
Gajo Petrovic
@gajop
i'm basically asking this if both luamenu and game have stuff in "libs", would they merge/conflict or not, and the answer seems no
imo if all you need to do is correctly specify it, it's not a problem
Eshed
@ashdnazg
it depends on the function which looks for them
in any case synced lua code is protected
it's correct to assume people never correctly specify
Gajo Petrovic
@gajop
"good default", sure
so about the last thing you said
wouldn't it imply that game's luaui code would read from menu archive by default?
Eshed
@ashdnazg
the default in luaui reads will be able to read things from luamenu
indeed
Gajo Petrovic
@gajop
that doesn't seem to be the best default
by default i'd exclude things
Eshed
@ashdnazg
unfortunately it seems to be a big problem to change that
Gajo Petrovic
@gajop
because the default isn't VFS.MOD?