Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 26 19:32

    Beherith on master

    Add a "crop" member to images. … Merge branch 'master' into mast… Merge pull request #535 from Be… (compare)

  • Feb 26 19:32
    Beherith closed #535
  • Feb 26 19:32
    Beherith synchronize #535
  • Feb 26 19:30
    Beherith opened #535
  • Feb 25 15:45

    gajop on master

    simplify download handler implement spring-launcher based… (compare)

  • Feb 23 10:39

    gajop on master

    nlc, fix build (compare)

  • Feb 23 10:28

    gajop on master

    nlc parse local minimaps with sprin… (compare)

  • Feb 21 20:22

    Beherith on master

    remove echo from gui_integer_po… support a multitude of spads th… Merge pull request #534 from Be… (compare)

  • Feb 21 20:22
    Beherith closed #534
  • Feb 21 20:22
    Beherith opened #534
  • Feb 20 21:36

    Beherith on master

    Update gui_integer_popup_window… Merge pull request #533 from Be… (compare)

  • Feb 20 21:36
    Beherith closed #533
  • Feb 20 21:36
    Beherith opened #533
  • Feb 11 21:02

    Beherith on master

    Make logout button pop up the l… Merge pull request #532 from Be… (compare)

  • Feb 11 21:02
    Beherith closed #532
  • Feb 11 19:44
    Beherith opened #532
  • Feb 08 15:45
    gajop commented #531
  • Feb 08 15:44

    gajop on master

    Lobby should handle locked stat… Merge pull request #531 from Be… (compare)

  • Feb 08 15:44
    gajop closed #531
  • Feb 07 12:44
    Beherith opened #531
Gajo Petrovic
@gajop
;(
Eshed
@ashdnazg
limiting ourselves to the LuaMenu folders saves lives
or at least my life :P
Gajo Petrovic
@gajop
i'm already very worried with things becoming too diverging to merge upstream
liblobby not so much, but chili in particular
in general i want to have stuff in libs/ identical to upstream stuff
or in a way that they can be merged
Eshed
@ashdnazg
makes sense
hmm
you may be right
if chili is used in unsynced luarules it can't be in the luaui folders
anyway
I think libs should be outside the environments
Gajo Petrovic
@gajop
i think we basically want the menu not to pollute VFS of games
what do you mean?
Eshed
@ashdnazg
absolutely
Gajo Petrovic
@gajop

absolutely

so that's already the status quo?

Eshed
@ashdnazg
mostly yes
synced lua code can't read from luamenu
and I've moved all stuff to the luamenu dirs
so they don't accidentally mingle
Gajo Petrovic
@gajop
oh so it's still merging the two VFS?
Eshed
@ashdnazg
no
you can choose
but unfortunately it proved impossible to make VFS.ZIP exclude lua menu
Gajo Petrovic
@gajop
that sounds like a 'yes' to me?
Eshed
@ashdnazg
no
Gajo Petrovic
@gajop
if you can access luamenu stuff from game
not talking about variables
Eshed
@ashdnazg
now VFS.MOD will not read MENU stuff
Gajo Petrovic
@gajop
ok
that's good
it's actually pretty good if we can choose also but optional
Eshed
@ashdnazg
every bit of unsynced code which doesn't specify the mode or which specified VFS.ZIP (or VFS.RAW_FIRST) will read from menu archive
Gajo Petrovic
@gajop
i'm basically asking this if both luamenu and game have stuff in "libs", would they merge/conflict or not, and the answer seems no
imo if all you need to do is correctly specify it, it's not a problem
Eshed
@ashdnazg
it depends on the function which looks for them
in any case synced lua code is protected
it's correct to assume people never correctly specify
Gajo Petrovic
@gajop
"good default", sure
so about the last thing you said
wouldn't it imply that game's luaui code would read from menu archive by default?
Eshed
@ashdnazg
the default in luaui reads will be able to read things from luamenu
indeed
Gajo Petrovic
@gajop
that doesn't seem to be the best default
by default i'd exclude things
Eshed
@ashdnazg
unfortunately it seems to be a big problem to change that
Gajo Petrovic
@gajop
because the default isn't VFS.MOD?
Eshed
@ashdnazg
yes
Gajo Petrovic
@gajop
ok i understand