Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 19 14:27

    Beherith on master

    Add listener for OnRequestBattl… (compare)

  • Apr 18 18:41
    raph-amiard edited #541
  • Apr 18 18:41
    raph-amiard opened #541
  • Apr 16 09:03

    Beherith on master

    Adapt sl_loopback.lua * no nee… Merge pull request #540 from ra… (compare)

  • Apr 16 09:03
    Beherith closed #540
  • Apr 16 08:28
    raph-amiard opened #540
  • Apr 12 20:08
    Beherith closed #539
  • Apr 12 20:08

    Beherith on master

    sl_loopback.lua: make resilient… Merge pull request #539 from ra… (compare)

  • Apr 12 14:51
    raph-amiard opened #539
  • Apr 12 07:46

    Beherith on master

    Make travis happy (whitespace) (compare)

  • Apr 12 07:43

    Beherith on master

    Minor: fix tabs sl_loopback.lua: Pass allyTeams… Merge pull request #538 from ra… (compare)

  • Apr 12 07:43
    Beherith closed #538
  • Apr 12 07:43
    Beherith commented #538
  • Apr 11 22:02
    raph-amiard opened #538
  • Mar 17 22:52

    Beherith on master

    Display negative handicap Merge pull request #537 from Be… (compare)

  • Mar 17 22:52
    Beherith closed #537
  • Mar 17 22:52
    Beherith opened #537
  • Mar 17 22:43

    Beherith on master

    Lobby should implement listing … interface ingnorelist i18n fix and 5 more (compare)

  • Mar 17 22:43
    Beherith closed #536
  • Mar 17 22:43
    Beherith opened #536
Gajo Petrovic
@gajop
in general i want to have stuff in libs/ identical to upstream stuff
or in a way that they can be merged
Eshed
@ashdnazg
makes sense
hmm
you may be right
if chili is used in unsynced luarules it can't be in the luaui folders
anyway
I think libs should be outside the environments
Gajo Petrovic
@gajop
i think we basically want the menu not to pollute VFS of games
what do you mean?
Eshed
@ashdnazg
absolutely
Gajo Petrovic
@gajop

absolutely

so that's already the status quo?

Eshed
@ashdnazg
mostly yes
synced lua code can't read from luamenu
and I've moved all stuff to the luamenu dirs
so they don't accidentally mingle
Gajo Petrovic
@gajop
oh so it's still merging the two VFS?
Eshed
@ashdnazg
no
you can choose
but unfortunately it proved impossible to make VFS.ZIP exclude lua menu
Gajo Petrovic
@gajop
that sounds like a 'yes' to me?
Eshed
@ashdnazg
no
Gajo Petrovic
@gajop
if you can access luamenu stuff from game
not talking about variables
Eshed
@ashdnazg
now VFS.MOD will not read MENU stuff
Gajo Petrovic
@gajop
ok
that's good
it's actually pretty good if we can choose also but optional
Eshed
@ashdnazg
every bit of unsynced code which doesn't specify the mode or which specified VFS.ZIP (or VFS.RAW_FIRST) will read from menu archive
Gajo Petrovic
@gajop
i'm basically asking this if both luamenu and game have stuff in "libs", would they merge/conflict or not, and the answer seems no
imo if all you need to do is correctly specify it, it's not a problem
Eshed
@ashdnazg
it depends on the function which looks for them
in any case synced lua code is protected
it's correct to assume people never correctly specify
Gajo Petrovic
@gajop
"good default", sure
so about the last thing you said
wouldn't it imply that game's luaui code would read from menu archive by default?
Eshed
@ashdnazg
the default in luaui reads will be able to read things from luamenu
indeed
Gajo Petrovic
@gajop
that doesn't seem to be the best default
by default i'd exclude things
Eshed
@ashdnazg
unfortunately it seems to be a big problem to change that
Gajo Petrovic
@gajop
because the default isn't VFS.MOD?
Eshed
@ashdnazg
yes
Gajo Petrovic
@gajop
ok i understand
Eshed
@ashdnazg
remember that widgets can exist in the map archive and in raw filesystem
I've originally tried to prevent this
but it was a rabbithole
every change broke something else
Gajo Petrovic
@gajop
i can live with it, i assume people writing libs to be more responsible in writing correct VFS access modes