Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 20 07:52
    ForbodingAngel commented #510
  • Mar 20 07:51
    ForbodingAngel reopened #510
  • Mar 20 07:48
    ForbodingAngel closed #510
  • Mar 20 07:48
    ForbodingAngel opened #510
  • Mar 07 18:15
    gajop commented #509
  • Mar 07 18:15
    gajop commented #509
  • Mar 07 18:14
    gajop commented #509
  • Mar 07 17:43
    Ruwetuin opened #509
  • Mar 05 23:48
    Ruwetuin edited #508
  • Mar 05 23:47
    Ruwetuin opened #508
  • Feb 24 03:30

    gajop on master

    reapplied uiScale affecting fon… Merge pull request #506 from be… (compare)

  • Feb 24 03:30
    gajop closed #506
  • Feb 24 03:08
    GoogleFrog commented #506
  • Feb 24 03:08
    GoogleFrog commented #506
  • Feb 23 11:59
    Ruwetuin opened #507
  • Feb 22 03:18
    gajop commented #506
  • Feb 22 03:18
    gajop review_requested #506
  • Feb 22 00:04
    Ruwetuin opened #506
  • Feb 21 01:28
    Ruwetuin commented on f7f46b0
  • Feb 20 17:02

    gajop on master

    allow games to specify default … (compare)

Eshed
@ashdnazg
if chili is used in unsynced luarules it can't be in the luaui folders
anyway
I think libs should be outside the environments
Gajo Petrovic
@gajop
i think we basically want the menu not to pollute VFS of games
what do you mean?
Eshed
@ashdnazg
absolutely
Gajo Petrovic
@gajop

absolutely

so that's already the status quo?

Eshed
@ashdnazg
mostly yes
synced lua code can't read from luamenu
and I've moved all stuff to the luamenu dirs
so they don't accidentally mingle
Gajo Petrovic
@gajop
oh so it's still merging the two VFS?
Eshed
@ashdnazg
no
you can choose
but unfortunately it proved impossible to make VFS.ZIP exclude lua menu
Gajo Petrovic
@gajop
that sounds like a 'yes' to me?
Eshed
@ashdnazg
no
Gajo Petrovic
@gajop
if you can access luamenu stuff from game
not talking about variables
Eshed
@ashdnazg
now VFS.MOD will not read MENU stuff
Gajo Petrovic
@gajop
ok
that's good
it's actually pretty good if we can choose also but optional
Eshed
@ashdnazg
every bit of unsynced code which doesn't specify the mode or which specified VFS.ZIP (or VFS.RAW_FIRST) will read from menu archive
Gajo Petrovic
@gajop
i'm basically asking this if both luamenu and game have stuff in "libs", would they merge/conflict or not, and the answer seems no
imo if all you need to do is correctly specify it, it's not a problem
Eshed
@ashdnazg
it depends on the function which looks for them
in any case synced lua code is protected
it's correct to assume people never correctly specify
Gajo Petrovic
@gajop
"good default", sure
so about the last thing you said
wouldn't it imply that game's luaui code would read from menu archive by default?
Eshed
@ashdnazg
the default in luaui reads will be able to read things from luamenu
indeed
Gajo Petrovic
@gajop
that doesn't seem to be the best default
by default i'd exclude things
Eshed
@ashdnazg
unfortunately it seems to be a big problem to change that
Gajo Petrovic
@gajop
because the default isn't VFS.MOD?
Eshed
@ashdnazg
yes
Gajo Petrovic
@gajop
ok i understand
Eshed
@ashdnazg
remember that widgets can exist in the map archive and in raw filesystem
I've originally tried to prevent this
but it was a rabbithole
every change broke something else
Gajo Petrovic
@gajop
i can live with it, i assume people writing libs to be more responsible in writing correct VFS access modes
the biggest conflict i can see is in the "libs/" dir
Eshed
@ashdnazg
and the most important thing is the synced code
now, you can still put a units folder in your menu
Gajo Petrovic
@gajop
maybe xP
Eshed
@ashdnazg
but that will suck :D