These are chat archives for SrTobi/code-bing

2nd
Dec 2015
Jacob Hands
@jahands
Dec 02 2015 15:22
Haven't had time to mess with this over the weakend
I just added #20 which is a fix for #17 that I think is cleaner than #19. Let me know what you think.
Tobias Kahlert
@SrTobi
Dec 02 2015 17:06
hey i commented your solution.
i want to merge and publish today (in the next 3-5 hours)
Tobias Kahlert
@SrTobi
Dec 02 2015 17:13
the last thing is this readme. i will do this as soon as I get home
Jacob Hands
@jahands
Dec 02 2015 17:34
Wait to publish till we get #20 resolved
Tobias Kahlert
@SrTobi
Dec 02 2015 20:00
jop definitely
Jacob Hands
@jahands
Dec 02 2015 20:00
Just pushed a commit that I think is a good solution.
Tobias Kahlert
@SrTobi
Dec 02 2015 20:24
I updated the readme. could you shortly review it. I think your English is better then mine ^^
Jacob Hands
@jahands
Dec 02 2015 20:28
Sure thing
Tobias Kahlert
@SrTobi
Dec 02 2015 20:41
thanks
Jacob Hands
@jahands
Dec 02 2015 20:56
#21 I know how to use secondary branches now :D
Tobias Kahlert
@SrTobi
Dec 02 2015 21:00
:)
mom i will look into it in a few seconds
Jacob Hands
@jahands
Dec 02 2015 21:03
lol
Tobias Kahlert
@SrTobi
Dec 02 2015 21:04
mom = moment :)
Jacob Hands
@jahands
Dec 02 2015 21:04
Is that a thing? Or just a typo? I'm so behind on what kids say these days xD
Tobias Kahlert
@SrTobi
Dec 02 2015 21:06
hmmm dont know... i use it and no one ever complained.... until now xD
Jacob Hands
@jahands
Dec 02 2015 21:06
Not complaining, just didn't know what what you meant by it hah
Tobias Kahlert
@SrTobi
Dec 02 2015 21:07
:) ok complaining is a bit too harsh sorry for that...
Jacob Hands
@jahands
Dec 02 2015 21:07
All good : )
Back on topic.... I think with my pr's we are deff ready for 0.0.2 release
Tobias Kahlert
@SrTobi
Dec 02 2015 21:11
ok merged the readme pr
i think there is still some discussion on #20/#19 needed.
Jacob Hands
@jahands
Dec 02 2015 21:17
Okay, what are your thoughts on it?
Tobias Kahlert
@SrTobi
Dec 02 2015 21:18
im writing it into the pr
Jacob Hands
@jahands
Dec 02 2015 21:18
Ok
Tobias Kahlert
@SrTobi
Dec 02 2015 21:19
done
meanwhile i am recording a new gif for the shortcut thing
Jacob Hands
@jahands
Dec 02 2015 21:39
I'm cleaning up the logic for #20 real quick
Tobias Kahlert
@SrTobi
Dec 02 2015 21:39
ok, new gif is online
the yt video at the end is great
Jacob Hands
@jahands
Dec 02 2015 21:46
Hahaha that's awesome
I cleaned up the logic a LOT in #20 I just updated btw
Tobias Kahlert
@SrTobi
Dec 02 2015 21:47
btw, next version is v0.1.0
Jacob Hands
@jahands
Dec 02 2015 21:47
Awesome
Tobias Kahlert
@SrTobi
Dec 02 2015 21:47
i think we added enough to increase the minor version ^^
Jacob Hands
@jahands
Dec 02 2015 21:48
Certainly so
I hate to say it but you should probably censor the DER BITCH TEST bit on the giff so the plugin doesn't get flagged
Tobias Kahlert
@SrTobi
Dec 02 2015 21:50
really? hmmmm^^
ok, first of all i have to watch that video
Jacob Hands
@jahands
Dec 02 2015 21:50
It's 2015, people feel like everything is a direct attack on their personal character :/
People get insulted sooooo easily
Tobias Kahlert
@SrTobi
Dec 02 2015 21:53
ok..... its not that cool
you wanna know what happens in the video?
yea I try to censor it
Jacob Hands
@jahands
Dec 02 2015 21:54
I don't really care hah...
If you need to you could just crop out the bottom bit of the gif
By the way I do think that new setting I added is helpful
Gotta remember that people can add per-workspace settings and maybe on some project they have "yt" and "g" all over their files but still want to use all diff providers whenever they do a non-selection search.
Tobias Kahlert
@SrTobi
Dec 02 2015 22:09
yeah and thats accomplished by my pr. and they can still prepend providers if they want. its controlled by their query and not an static option
Tobias Kahlert
@SrTobi
Dec 02 2015 22:14
ok, updated the image
Jacob Hands
@jahands
Dec 02 2015 22:14
query.indexOf(selectedText) == 0 what happens if they edit the selection before searching?
Something about searchFor(text, text); just feels dirty...
I do think query.indexOf(selectedText) == 0 would be great added to my options though
Tobias Kahlert
@SrTobi
Dec 02 2015 22:16
yeah good point
Jacob Hands
@jahands
Dec 02 2015 22:16
But I do think what I added is good too
Tobias Kahlert
@SrTobi
Dec 02 2015 22:16
an combo might be a good solution
Jacob Hands
@jahands
Dec 02 2015 22:16
I'll add a bit so if they leave the first part as the selection then it uses default
and let you see what you think
Tobias Kahlert
@SrTobi
Dec 02 2015 22:25
ok
Jacob Hands
@jahands
Dec 02 2015 22:40
Ok pushed
It combines both of our logic in one, and removes the stupid extra searchDefaultFor function I had
Tobias Kahlert
@SrTobi
Dec 02 2015 23:01
ok, just checking your code and then i will get some sleep^^
Jacob Hands
@jahands
Dec 02 2015 23:01
Sweet
Tobias Kahlert
@SrTobi
Dec 02 2015 23:06
ok works great so far
ok, one missing ;
after that we can merge and publish
Jacob Hands
@jahands
Dec 02 2015 23:09
Wow fail, thanks for catching that. Fixed!
Uhm
wat
Tobias Kahlert
@SrTobi
Dec 02 2015 23:09
or is it just for me?
Jacob Hands
@jahands
Dec 02 2015 23:10
Me too... well you want to just go ahead and make a github release for 0.1.0 and mark 0.1.0 milestone as done?
Tobias Kahlert
@SrTobi
Dec 02 2015 23:11
yep...
Jacob Hands
@jahands
Dec 02 2015 23:11
Fail microsoft is fail
I'm really enjoying coding this with you
It really helps to have others help with it
imo I did make the code better and that was primarily from getting input from you =)
Tobias Kahlert
@SrTobi
Dec 02 2015 23:18
yeah its really more fun to do coding in a team. and github pr + review is a great tool for that.
v0.1.0 is ouf
Jacob Hands
@jahands
Dec 02 2015 23:19
It's awesome to finally actually start learning Github/git more (usually I use it by myself).
Awesome!
We did it :D
Marketplace is back up!
Tobias Kahlert
@SrTobi
Dec 02 2015 23:19
I added you as collaborator, so you can push now too. Nevertheless I think pr's are the right way to go.
cool then i can publish
Jacob Hands
@jahands
Dec 02 2015 23:21
Thanks! Yeah I like using PR's. It would have been harder for me to add to your #19 PR if you straight up committed to master
(and by add to I mean rewrote ;) )
But now I can merge PR's too if needed
Tobias Kahlert
@SrTobi
Dec 02 2015 23:37
published