Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    kastolars
    @kastolars

    Hi! I am new to open source contribution and would like to take on this issue:

    Stranger6667/css-inline#138

    Dmitry Dygalo
    @Stranger6667

    Hi @kastolars :) Happy to see your interest in css-inline.

    I think the best way to start would be to extend the InlineOptions struct with a new bool option - https://github.com/Stranger6667/css-inline/blob/master/css-inline/src/lib.rs#L63 (together with a relevant builder function)
    Then check whether this option is enabled before this line - https://github.com/Stranger6667/css-inline/blob/master/css-inline/src/lib.rs#L302. I.e. if it is disabled, then we go the old way. otherwise, we need to insert more values into attributes

    I'd be happy to provide more details on any of these :) Also, if you'd like to open a WIP pull request with this issue (any state of readiness), then I'll review the changes as soon as I can

    kastolars
    @kastolars
    Sounds great! Yeah I'm looking over the code right now and looking into how I can test my changes.
    Thank you for the guidance
    Dmitry Dygalo
    @Stranger6667
    Happy to help! :) I left a few comments on the PR - feel free to ping me if you need anything there :)
    I plan to add a few more thoughts on the next steps during this week
    kastolars
    @kastolars
    Sounds great! I'll check them out.
    kastolars
    @kastolars
    Hi Dmitry, haven't forgotten about this issue. I'm looking into possibly leveraging xml-rs for the parsing work that needs to be done.
    Dmitry Dygalo
    @Stranger6667
    Hi @kastolars ! Thank you for the headsup! :) This week got pretty hectic and I'll get back to the issue during the weekend
    kastolars
    @kastolars
    Awesome sounds good
    kastolars
    @kastolars
    hey @Stranger6667 , is this project still going?
    Dmitry Dygalo
    @Stranger6667
    Hey @kastolars ! Thank you for pinging me - I somehow missed a notification about your latest push to the branch. I'll reply in the PR soon
    kastolars
    @kastolars
    Sounds good, will read over the comments soon