Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 04 12:37
    valeriyvan commented #24
  • Oct 04 10:39

    bielikb on master

    Refactors forEach for using tra… Merge branch 'master' into trai… Merge pull request #24 from val… (compare)

  • Oct 04 10:39
    bielikb closed #24
  • Oct 04 10:39
    bielikb commented #24
  • Oct 02 16:01
    codecov[bot] commented #32
  • Oct 02 15:34
    valeriyvan commented #24
  • Oct 02 15:32
    codecov[bot] commented #32
  • Oct 02 15:32
    valeriyvan synchronize #32
  • Oct 02 15:29
    codecov[bot] commented #24
  • Oct 02 15:25
    codecov[bot] commented #22
  • Oct 02 15:16
    codecov[bot] commented #24
  • Oct 02 15:16
    valeriyvan synchronize #24
  • Oct 02 15:12
    codecov[bot] commented #22
  • Oct 02 15:12
    valeriyvan synchronize #22
  • Oct 01 14:39
    bielikb commented #24
  • Oct 01 14:29
    bielikb commented #45
  • Oct 01 14:28

    bielikb on master

    Add Package.swift Merge pull request #45 from Hai… (compare)

  • Oct 01 14:28
    bielikb closed #45
  • Oct 01 14:03
    codecov[bot] commented #45
  • Oct 01 13:56
    Haitec opened #45
Johannes
@V1rus999
South African, so we're kind of in the same timezone range
Do you guys have any intention of rewriting everything in Kotlin?
Vitor Nunes
@VitorNoVictor
:)
We don't have plans for that yet
Johannes
@V1rus999
Ahh okay, it would be a cool experiment
Johannes
@V1rus999
Hi all, I added a pull request (to allow user to add a custom thread executor), it failed in the build. Not sure why? Can I get a review on the request please?
Sebastian Chlan
@schlan
@V1rus999 i merged your PR, the travis build was green so it should be fine. i'll look into the codecov issues another time
make sure you sign up for https://hacktoberfest.digitalocean.com/ .... 3 more prs and you'll get a tshirt :D
Johannes
@V1rus999
:smile: Thanks! What would you guys think about adding another executor. This one will be a "post execution executor" which will make it easier for the user to handle posting back to the main thread? If they don't set it we will keep on posting back to the current thread.
Johannes
@V1rus999
P.S what does Suas stand for and how is it pronounced?
Sebastian Chlan
@schlan
I'm gonna think about that, it probably makes sense to do so.
Suas is irish and means 'up'
Johannes
@V1rus999
Wow okay, thanks for clearing that up. Let me know so I can start working on it!
Vitor Nunes
@VitorNoVictor
@V1rus999 check this out https://forvo.com/word/ga/suas/#ga :)
Johannes
@V1rus999
@VitorNoVictor yeah found the pronunciation thanks. When will there be another release for Suas? Anything else I can work on for now?
cloud9999strife
@cloud9999strife
Hi All. I'm getting string deprecations warnings in the LoggerMiddleware.swift when using Suas on iOS. Would it be okay if I fix those and send a pull request?
Steven Diviney
@divo
@cloud9999strife fire away. Drop a message in here when you want review
cloud9999strife
@cloud9999strife
@divo Thanks, here is a link to the merge request: zendesk/Suas-iOS#20
Steven Diviney
@divo
Looks fine, will just wait on the build
cloud9999strife
@cloud9999strife
cool
cloud9999strife
@cloud9999strife
The build failed, looks like those changes will need to be done as part of a Swift 4 upgrade as those methods seem to be part of Swift 4.
cloud9999strife
@cloud9999strife
I submitted a pull request on the iOS branch to disable debug logging. It would be cool if someone could give me some feedback on it. @divo
Sebastian Chlan
@schlan
divo is on holidays, i'll let him know as soon as he is back
thanks for the pr =)
cloud9999strife
@cloud9999strife
@divo thanks for the pull. I created another pull request to make the bool flag publicly accessible. At the moment only internal components can use it. I also added a description so that it looks better in Xcode.
Steven Diviney
@divo
@cloud9999strife thanks for the contributions
I approved your pr but then noticed a small typo in the doc
cloud9999strife
@cloud9999strife
@divo Thanks
cloud9999strife
@cloud9999strife
@divo I created another pull request to fix those Xcode warnings. I checked the Xcode version this time so that it builds on other versions. However, the Travis CI build has been "in progress" for about a day now. Maybe it's broken?
cloud9999strife
@cloud9999strife
Looks like the CI build passed. It would be cool to get some feedback on it (zendesk/Suas-iOS#28). @divo
Johannes
@V1rus999
Hey guys, I see there is a new Suas release, but there is no changelog to go along with the releases. Are you planning on creating one?
Sebastian Chlan
@schlan
The latest android release was a small one, only containing some bug fixes and I think a new api for providing a custom executor.
It’s very likely that we’re gonna do another release soon. I’ll make sure that we have release note on the release page on github.
Johannes
@V1rus999
Hi guys is this project still going on? I see v1.2.0 is already available but no changelog
Steven Diviney
@divo
Hey @V1rus999 , yes it's still going. We are using it in Zendesk but we don't have a whole lot of time to work on Suas
I'll ask @eepDev about a changelog on Monday
TMTron
@tmtron

hi - hope this is the right place to ask

Shouldn't the CombinedReducer.reduce function also check for referential equality?

if(newStateForKey != null) {
    state.updateKey(reducer.getStateKey(), newStateForKey);
    if (newStateForKey !== oldStateForKey ) {
        updatedKeys.add(reducer.getStateKey());
    }
} else {
    state.updateKey(reducer.getStateKey(), oldStateForKey);
}

E.g. the reducers in the weather-app example, do not return null (as recommended in the documentation), but the oldState

Elvis Porebski
@eepDev
@tmtron Yes it should, nice catch :raised_hands: Want to create a PR with a fix?
@V1rus999 we added release notes on GitHub for now and will soon update our readme docs as well.
TMTron
@tmtron
@eepDev done: zendesk/Suas-Android#51
TMTron
@tmtron
What is the idea/advantage of defining unique strings for each action?
In JavaScript, this may be required because we have no type-safety. But in Java/Kotlin, we can simple use instance-of checks, right?
E.g the string constants in the weather-app are not used anywhere - you only use instance-of checks in the Reducers
subzero10
@subzero10
hello everyone. i am trying Suas for my Android app. i am having difficulties enabling any of the provided Middleware. I cannot find them anywhere to import.
TMTron
@tmtron
did you add the gradle dependency? e.g. compile 'com.zendesk.suas:suas-thunk:1.2.0'
subzero10
@subzero10
i figured that out just 5 minutes ago. thanks!
is it mentioned anywhere in the docs?
TMTron
@tmtron
not sure - I think https://suas.readme.io/docs/installation would be a good place to mention that ..
subzero10
@subzero10
:+1:
Doug
@douggieP_gitlab
I see that the artifacts for 1.0.0 in JCenter and Maven Central have changed. Any way to find out what's different?
Doug
@douggieP_gitlab
nvmnd. I was mistaken
Doug
@douggieP_gitlab
Am I understanding this correctly - AsyncActions aren't actually asynchronous unless you make them so? And they aren't actually Actions?