by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jul 08 19:13
    3lvis commented #260
  • Jul 08 19:07

    3lvis on master

    Update Networking.podspec (compare)

  • Jul 08 19:02
    mkll closed #260
  • Jul 08 19:01

    3lvis on 5.0.3

    (compare)

  • Jul 08 18:54

    3lvis on remove-cache-in-purge

    (compare)

  • Jul 08 18:54

    3lvis on master

    Remove crashing in purging (#26… (compare)

  • Jul 08 18:54
    3lvis closed #261
  • Jul 08 18:46
    mkll commented #260
  • Jul 08 18:44
    3lvis opened #261
  • Jul 08 18:44

    3lvis on remove-cache-in-purge

    Remove crashing in purging (compare)

  • Jul 08 18:44

    3lvis on remove-cache-in-purge

    (compare)

  • Jul 08 18:37

    3lvis on master

    Remove forced crash in cacheOrP… (compare)

  • Jul 08 18:37
    3lvis commented #260
  • Jul 08 17:56
    mkll opened #260
  • Jun 29 14:09

    3lvis on master

    Add sponsor message (compare)

  • Jun 27 11:15

    3lvis on master

    Create FUNDING.yml (compare)

  • Jun 06 16:36
    mkll commented #254
  • Jun 06 16:25
    3lvis commented #254
  • Jun 06 16:18

    3lvis on 5.0.2

    (compare)

  • Jun 06 16:17

    3lvis on master

    Update Networking.podspec (compare)

Robin Malhotra
@codeOfRobin
Are those for mocks/stubs?
Elvis Nuñez
@3lvis
yes, that's correct
Robin Malhotra
@codeOfRobin
Oh. Any reason you've put them in the main framework?
I'd think those would belong in the Tests target
Elvis Nuñez
@3lvis
It's a library feature
Robin Malhotra
@codeOfRobin
I'm a bit of a beginner in testing, so excuse my ignorance
Oh
Robin Malhotra
@codeOfRobin
Interesting
Actually, that was the only thing that was questionable
The rest of the codebase seems very clear
Elvis Nuñez
@3lvis
If you have anything else let me know
Robin Malhotra
@codeOfRobin
I'm actually working on a library of my own
This looked like the clearest one, codebase wise.
If you have anything else let me know
Elvis Nuñez
@3lvis
is always very useful to get the feedback from other developers
Robin Malhotra
@codeOfRobin
Awesome, thank you so much
I have a couple of refactors/reimplementations of functions in my fork
If you want I'll make a PR .
codeOfRobin/Networking@953b964
Elvis Nuñez
@3lvis
That would be very nice!
I'm especially interesting in hearing the reasoning behind your changes. I'm sure there are things that could be improved :)
Robin Malhotra
@codeOfRobin
Awesome. Made a PR :tada:
Robin Malhotra
@codeOfRobin
One more thing
TestCheck.testBlock(self.disableTestingMode) {
                completion(response as? NetworkingImage, error)
            }
Basically checks if tests are running or not
and if tests are running, will provide mocked data instead of actual data, right?
Elvis Nuñez
@3lvis
I should have documented that properly
other feature of Networking is that the tests run synchronously.
That's on the README.
But if you return on the main thread, it won't be consider synchronous.
it has to return in the same queue as it was.
Actually, it is documented, haha.
If it's in a unit testing target then it will return in the current thread, otherwise it will return in the main thread.
Robin Malhotra
@codeOfRobin
Hmm. I think I get it now
Elvis Nuñez
@3lvis

The reason why I wanted tests to be synchronous is to not deal with a lot of

XCTestExpectations when running tests

tests should be REALLY easy to write
and using this library you can do that.
Robin Malhotra
@codeOfRobin
Ah
That makes sense
Also, are you using dataTaskWithURL even for image downloads?
In fact, I'm only seeing one call to URLSession.dataTaskWithURL
in line 601 of Networking.swift
Elvis Nuñez
@3lvis
I don't follow, what's your doubt or concern?
Soojin Ro
@nsoojin
hey @3lvis, 3.0.1 is not released in cocoapods!?
Elvis Nuñez
@3lvis
@nsoojin Hi! Is in CocoaPods now
Robin Malhotra
@codeOfRobin
Hey @3lvis !
Robin Malhotra
@codeOfRobin
Wanted to talk to you about the stuff we discussed here: https://twitter.com/3lvis/status/911577082026692608
Elvis Nuñez
@3lvis
@codeOfRobin sent you a DM :)