Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 21 06:04
    Musador13 starred Syncleus/aparapi-examples
  • Oct 25 19:27
    GZGavinZhao starred Syncleus/aparapi
  • Oct 23 22:12
    david-d25 starred Syncleus/aparapi
  • Oct 21 07:07
    edom71 starred Syncleus/aparapi
  • Oct 12 22:35
    Raunak-Singh-Inventor closed #168
  • Oct 12 22:35
    Raunak-Singh-Inventor closed #168
  • Oct 11 09:03
    grfrost commented #168
  • Oct 08 12:13
    treyperry starred Syncleus/aparapi
  • Oct 06 09:01
    dependabot[bot] closed #5
  • Oct 06 09:01

    dependabot[bot] on bundler

    (compare)

  • Oct 06 09:01
    dependabot[bot] commented #5
  • Oct 06 09:01
    dependabot[bot] labeled #8
  • Oct 06 09:01
    dependabot[bot] opened #8
  • Oct 06 09:01

    dependabot[bot] on bundler

    Bump addressable from 2.7.0 to … (compare)

  • Oct 03 14:25
    yqy7 starred Syncleus/aparapi
  • Oct 02 14:47
    Kevin-HYX starred Syncleus/aparapi
  • Sep 30 17:23
    dependabot[bot] labeled #170
  • Sep 30 17:23

    dependabot[bot] on maven

    Build(deps): Bump scala-library… (compare)

  • Sep 30 17:23
    dependabot[bot] opened #170
  • Sep 16 02:49
    lakxtxue starred Syncleus/aparapi
grfrost
@grfrost
OK. I will pull the latest jni and native repos. Apply these patches and ensure that it runs (for me ;) ) then commit (assuming I have permission). Then I will pull again (sans patching) and check that my workloads run. Is that enough?
grfrost
@grfrost
Alas nyet. Permission to Syncleus/aparapi-native.git denied to grfrost.
CoreRasurae
@CoreRasurae
@freemo:qoto.org Hi, I am also having issues with my git.qoto.org account. When I login it says that my plan from gitlab.com has expired...
what can I do? do I have to do something on my side, or is it something with git.qoto.org?
CoreRasurae
@CoreRasurae
I am unable to push stuff into my repo, I can only fetch from it
freemo
@freemo:qoto.org
[m]
@CoreRasurae: give me a day or two to fix it. the license had a issue but im in contact with gitlab onn it.
CoreRasurae
@CoreRasurae
@freemo:qoto.org sure, no problem
CoreRasurae
@CoreRasurae
@freemo:qoto.org @grfrost My MR is ready to be reviewed and merged.
@freemo:qoto.org The CI stopped working again....
Freemo
@freemo:qoto.org
[m]
@CoreRasurae: i can look into the CI. did it break on its own or did you introduce breaking changes?
CoreRasurae
@CoreRasurae
@freemo:qoto.org It does not do anything at all. It fails at start. There are no API breaking changes at this moment, however when using private memory arrays there is behavioral change, but it is absolutely necessary to be OpenCL compliant. I am leaving the breaking changes associated with the Kernel, Device and Range association for another MR, at a later time. I propose that we first solve this broken stuff in Aparapi 3.0.0 before doing the badly needed breaking changes for the Kernel, Device and Range association for Aparapi 4.0.0. This way we give the users an option to progress in small steps, without needing to overhaul their code bases at once, if they just need to use NoCL annotated methods or if they need Private memory arrays.
When I say being OpenCL compliant in terms o private memory arrays I mean that we have to follow OpenCL semantics for private arrays.
CoreRasurae
@CoreRasurae
That introduces a behavioral change, with respect to previous Aparapi versions, except that previous versions were handling private memory arrays as constant memory space arrays and despite some kernels run and provide correct results, I am almost sure that OpenCL compiler moves those variables out of the constant memory space, back to global memory, since in many kernels those supposedly private variables have to be written to. Thus, despite some kernels will work, there is no performance gain, thus diverging from the expected.
and for sure none of them is private memory, at best it will be constant memory space.
Freemo
@freemo:qoto.org
[m]
ok let me look at whats going on and try to fix the CI in the next few days
CoreRasurae
@CoreRasurae
sure, BTW my MR is ready for revision and merging, from my side
Freemo
@freemo:qoto.org
[m]
@CoreRasurae: great, i want to bring CI back up first if possible so let me take a stab at that first
CoreRasurae
@CoreRasurae
sure
Freemo
@freemo:qoto.org
[m]
@CoreRasurae: By the way if your ever looking for remote work, likely using aparapi, let me know.
CoreRasurae
@CoreRasurae
@freemo:qoto.org Sure, I will
CoreRasurae
@CoreRasurae
Hi @freemo:qoto.org @grfrost I found an issue with AMD OpenCL ICD, that can deadlock an application while executing threaded Aparapi applications that concurrently call OpenCL APIs. Namely when compiling a kernel while another is being executed. This does not happen with NVIDIA which has thread safe OpenCL APIs. I have a simple workaround for this that can be inserted into Aparapi. Do you want me include it in the current MR?
@freemo:qoto.org BTW Do you have an expected date for proceeding with the MR analysis?
Probably this should be reported to AMD too.
grfrost
@grfrost

Hey @CoreRasurae regarding possible AMD runtime/driver bug. Can you reproduce using a small C++ example? My guess is that AMD will not 'go the lengths' of installing Aparapi. but if you have a C++ test case they will take a look.

I would be happy to validate too if you can produce a C++ testcase.

WRT MR I will defer to @freemo:qoto.org

CoreRasurae
@CoreRasurae
@grfrost I can try to recreate something like that with a C++ testcase. Let me try if can build it up in the next few days.
CoreRasurae
@CoreRasurae
@grfrost Sorry, I couldn't find the time to create the testcase, not yet...
grfrost
@grfrost
No worries. Busy times. I am expecting a call to be the new UK Prime Minister any time now :)
CoreRasurae
@CoreRasurae
:)
CoreRasurae
@CoreRasurae
@freemo:qoto.org Hi there, I hope all is well. I am writing to get a status update over the Aparapi MR. What is your plan for these MRs?
Freemo
@freemo:qoto.org
[m]
Hi
Forgot about thisa, been busy.. i think IIRC the CI had broken.. i can take a look this week
AS long as the CI fix isnt too crazy I should have time for it
CoreRasurae
@CoreRasurae
@freemo:qoto.org That would be great, as I am finalizing my application and nearing the first release. This would allow me release it against an official Aparapi release. BTW can I publish my code for the application, which will also be open source, on qoto.org?
Freemo
@freemo:qoto.org
[m]
@CoreRasurae: wonderful, i will be sure to work on it for you then... and yes you are most welcome. Anything open source for any purpose is always welcome onn qoto
CoreRasurae
@CoreRasurae
Ok, great!
CoreRasurae
@CoreRasurae
@freemo:qoto.org There is one thing that is not addressed with this MR though, which I found at a later stage, which is that AMD OpenCL ICD drivers do not deal well with concurrent kernel compile and execute calls at least. I haven't had the time to map to actual OpenCL calls, however the OpenCL ICD driver can deadlock, causing the application to stall. This does not happen with NVIDIA OpenCL ICD. This happens on Windows AMD drivers. I wasn't able to test on Linux, since none of my machines with AMD GPUs have working AMD drivers on Linux. I have a simple fix for this issue, which is to synchronize Aparapi-JNI calls for kernel compile and kernel execute. I am not sure if the OpenCL spec says something about the need for the API calls to be thread safe, or not, so this may, or may not be an AMD driver bug. Still, since this issue is already happening with current AMD released Windows drivers, it may be best to protect Aparapi that way. Should I add an MR for this?
Another thing that seem to be happening is that I may have introduced a regression with compiled kernel caching in 3.0.0 that seems that Aparapi is always compiling the same kernel on the same cards, again and again, when called concurrently for the same device from different threads. I have to fix this too, its just that I am lacking the time due to still being quite involved in the PhD... final stages... big boss... :D
Freemo
@freemo:qoto.org
[m]
i have AMD linux and can test here.. do we have any unit tests that that trigger this issue that I can test ?
but yea i think an MR for the fix, if for no other reasont han for me to review it, might be worth while
CoreRasurae
@CoreRasurae
ok, I don't have a unit test, since it would deadlock
unless in case of deadlock if include a test timeout time
*if=we
Freemo
@freemo:qoto.org
[m]
well the point of unit tests is they fail when there is a problem... so we would probably want a timeout and then have the test fail
CoreRasurae
@CoreRasurae
I will try to create a unit test for Aparapi for this issue in the next few days
Freemo
@freemo:qoto.org
[m]
wonderful, thanks
Freemo
@freemo:qoto.org
[m]
I think i finally have a breather, going to work on CI this weekend I think. Sorry for the delays guys
the link https://git.qoto.org/aparapi seems to have some problem, sometime is not responding, is this the main link? thx
Freemo
@freemo:qoto.org
[m]
@marco.stefanetti_gitlab: works for me jsut fine.. but one of our load balancers had bad hardware for a few days.. was fixed ysterday
1 reply
there is a mirror on github also