These are chat archives for TeyimPila/tela-mis

27th
Mar 2016
Abdulmajid Hamza
@SkaeX
Mar 27 2016 08:24
Muluh
You'll have to approve
i.e your Pull Request
Pila
@TeyimPila
Mar 27 2016 11:01
I've approved them. Are you looking through the other PRs?
Abdulmajid Hamza
@SkaeX
Mar 27 2016 11:01
Yes
Check comments i left
Pila
@TeyimPila
Mar 27 2016 11:03
i had a small issue though
Abdulmajid Hamza
@SkaeX
Mar 27 2016 11:03
uhuh?
Pila
@TeyimPila
Mar 27 2016 11:04
the...phone number and email are common in Facilitator, Enumerator and Tutor but not in Beneficiary
Abdulmajid Hamza
@SkaeX
Mar 27 2016 11:07
Make them inherit from a class say FieldWorker
Pila
@TeyimPila
Mar 27 2016 11:07
ok so i can keep Beneficiary out of the inheritance right?
because they don't even have much to be abstracted
Abdulmajid Hamza
@SkaeX
Mar 27 2016 11:08
y
Pila
@TeyimPila
Mar 27 2016 11:10
if Beneficiary inherits from that class then they will have email and phone number attributes, which are not required for a Beneficiary
Pila
@TeyimPila
Mar 27 2016 11:41
please check it out now