Static code review for your Gerrit patchsets. Runs Checkstyle, PMD, FindBugs, Scalastyle, CodeNarc, JSLint for you!
@mirkosertic I think about your PIT implementation
currently Sputnik runs analysys within its own JVM
it is fine as Sputnik analyse Java
but as other needs and tools come in I'd like to implement something wider
so Sputnik runs system command and provides InputStream to this spawned process
this way you can gather any tool's output
would it fit to PIT processor for Sputnik?
@mirkosertic its mostly about reporting private fields on classes with Lombok annontations
what a douche
but it works fine when i run sonar via gradle...
still there. looks like sonarrunner source will have to deliver
Depends. If you filter files by changeset it should run very fast depending in your Hardware and configured rules. More rules means more time. Package design analysis will wie the Hotspot. With more than 300kloc analysis in modern Hardware can take 10 to 20 minutes for the whole project.
few files is few seconds
i think warmup takes more time :)
before Sputnik I've used SonarCube as analyzer, but there was no an easy way to filter out files. And yes, warmup and execution was slow overall. I wrote sputnik to completely drop SonarCube as I could exchange rules to PMD, FindBugs and Checkstyle. Of course I know about SonarCube's own analyzer (squid? or similar name) but Sonar guys were in the middle of migration back then
also i have an idea to improve stash connector a bit
Hi all, we have small annoucement: https://touk.pl/blog/2016/04/06/sputnik-lands-on-github/ https://sputnik.ci
I am testing the following code in a file test.js with jshint like $jshint test.js:-
function myFunction(p1, p2) { ; ; return p1 == p2; // The function returns the product of p1 and p2 }
and Iam getting following error
test.js: line 2, col 1, Unnecessary semicolon.
test.js: line 3, col 2, Unnecessary semicolon.
2 errorsBut while testing it using sputnik on gerrit, sputnik is giving +1 for it. When there are errors in the file , why am I still getting +1 as code review in gerrit
@pjagielski http://pastebin.com/SRkWYgXr
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with Checkstyle: CheckstyleException: Unable to find: sun_checks.xml
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with JSHint: FileNotFoundException: jshint.json (No such file or directory)
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with Sonar: FileNotFoundException: sonar-project.properties (No such file or directory)
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with JSHint: FileNotFoundException: jshint.json (No such file or directory)
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with Sonar: FileNotFoundException: sonar-project.properties (No such file or directory)
TouK/sputnik#147
I have also attached execution logs to the issue
@Tomasz Kalkosiński
Can somebody give me samples of:
- checkstyle.xml
- pmd.xml
- findbugs.xml
I am very new to this..!!
If you guys any useful links..please pass it to me