Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 03 13:42
    baroodya opened #245
  • Jul 19 17:55
    Gungy2 closed #244
  • Jul 19 13:30
    Gungy2 opened #244
  • Jul 12 10:00
    SpOOnman closed #97
  • Jul 12 10:00
    SpOOnman edited #97
  • Jul 12 09:48

    SpOOnman on sputnik-2.8.0

    (compare)

  • Jul 12 09:32

    SpOOnman on master

    Bump Kotlin-related dependencie… (compare)

  • Jul 12 09:32
    SpOOnman closed #242
  • Jul 08 09:57
    fipciu1996 commented #229
  • Jun 15 07:16
    Gungy2 synchronize #242
  • Jun 10 13:07
    pjagielski synchronize #242
  • Jun 10 13:03

    pjagielski on Gungy2-master

    (compare)

  • Jun 10 13:02

    pjagielski on Gungy2-master

    Bump Kotlin-related dependencie… Merge remote-tracking branch 'o… (compare)

  • Jun 10 12:51

    pjagielski on master

    Setup GHA on pull request (#243… (compare)

  • Jun 10 12:51
    pjagielski closed #243
  • Jun 10 12:46
    pjagielski synchronize #243
  • Jun 10 12:46

    pjagielski on github_actions

    Java 8 (compare)

  • Jun 10 12:33
    pjagielski synchronize #243
  • Jun 10 12:33

    pjagielski on github_actions

    Java 8 (compare)

  • Jun 10 12:31
    pjagielski synchronize #243
Tomasz Kalkosiński
@SpOOnman
hi
@mirkosertic I think about your PIT implementation
currently Sputnik runs analysys within its own JVM
it is fine as Sputnik analyse Java
but as other needs and tools come in I'd like to implement something wider
so Sputnik runs system command and provides InputStream to this spawned process
this way you can gather any tool's output
would it fit to PIT processor for Sputnik?
Michał Niczyporuk
@mihn
@mirkosertic 5.1 but i removed those. my regular sonar on master doesnt report those errors, only sputnik does.
@mirkosertic its mostly about reporting private fields on classes with Lombok annontations
Ghost
@ghost~56c5e494e610378809c21b53
Ok, did you enable sonar.skipdesign? If so, disable it
Michał Niczyporuk
@mihn
first i need to find a branch to test it
Michał Niczyporuk
@mihn
[Sonar] ERROR: Remove this unused "test" private field. (Rule: squid:S1068)
what a douche
Ghost
@ghost~56c5e494e610378809c21b53
Which Version of sonarqube Java Plugin are you using?
Michał Niczyporuk
@mihn
 3.5,
but it works fine when i run sonar via gradle...
Michał Niczyporuk
@mihn
i just compared output from sonar on both types, and i found some differences ;)
Ghost
@ghost~56c5e494e610378809c21b53
Please let me know what the issue was:-)
Michał Niczyporuk
@mihn
just a hint atm. need to take a peak into sonarqube sources
Michał Niczyporuk
@mihn
updated sputnik 1.6.0 - just noticed it was out
still there. looks like sonarrunner source will have to deliver
Tomasz Kalkosiński
@SpOOnman
how long does it take SonraCube to analyze changeset with a few files?
Ghost
@ghost~56c5e494e610378809c21b53
Depends. If you filter files by changeset it should run very fast depending in your Hardware and configured rules. More rules means more time. Package design analysis will wie the Hotspot. With more than 300kloc analysis in modern Hardware can take 10 to 20 minutes for the whole project.
Michał Niczyporuk
@mihn
atm i work only 20kloc projects and it takes around 1 minute
few files is few seconds
i think warmup takes more time :)
Tomasz Kalkosiński
@SpOOnman
before Sputnik I've used SonarCube as analyzer, but there was no an easy way to filter out files. And yes, warmup and execution was slow overall. I wrote sputnik to completely drop SonarCube as I could exchange rules to PMD, FindBugs and Checkstyle. Of course I know about SonarCube's own analyzer (squid? or similar name) but Sonar guys were in the middle of migration back then
Michał Niczyporuk
@mihn
i prefer to use only SonarQube - only one quality profile to maintain :)
also i have an idea to improve stash connector a bit
Piotr Jagielski
@pjagielski
karthikvee
@karthikvee

I am testing the following code in a file test.js with jshint like $jshint test.js:-
function myFunction(p1, p2) { ; ; return p1 == p2; // The function returns the product of p1 and p2 }
and Iam getting following error

test.js: line 2, col 1, Unnecessary semicolon.
test.js: line 3, col 2, Unnecessary semicolon.
2 errors

But while testing it using sputnik on gerrit, sputnik is giving +1 for it. When there are errors in the file , why am I still getting +1 as code review in gerrit

Piotr Jagielski
@pjagielski
@karthikvee can you attach your sputnik.properties file?
karthikvee
@karthikvee
cketti
@cketti
hi. is there an easy way to use sputnik.ci with my own checkstyle config?
karthikvee
@karthikvee
@pjagielski :sparkles: Finally got standalone setup of sputnik to show the violations/errors :sparkles: :+1:
Piotr Jagielski
@pjagielski
@karthikvee nice! sorry for delayed response....
Rafał Nowak
@rafalnowak
@cketti hi, we are working on this option right now, it should be released soon
karthikvee
@karthikvee
I am getting following errors of file not found: How can i resolve them
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with Checkstyle: CheckstyleException: Unable to find: sun_checks.xml
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with JSHint: FileNotFoundException: jshint.json (No such file or directory)
INFO p.t.s.e.v.SummaryMessageVisitor - Adding problem message to review: There is a problem with Sonar: FileNotFoundException: sonar-project.properties (No such file or directory)
karthikvee
@karthikvee
@pjagielski @cketti @SpOOnman @mihn @mirkosertic @rafalnowak
TouK/sputnik#147
I have also attached execution logs to the issue
karthikvee
@karthikvee

@Tomasz Kalkosiński

Can somebody give me samples of:

  1. checkstyle.xml
  2. pmd.xml
  3. findbugs.xml

karthik.pwn@gmail.com

Piotr Jagielski
@pjagielski
@karthikvee if you use sputnik.ci you don't need these files in your repo, we provide some defaults
Michał Niczyporuk
@mihn
@pjagielski @SpOOnman Dominik told me you found a fix for 'unused properties' on lomboked classes
Harish
@harishbm34
Hi Could you please help me to understand "spurnikVM" from basic
I am very new to this..!!
If you guys any useful links..please pass it to me