These are chat archives for TypeStrong/atom-typescript

3rd
Jul 2015
kpgarrod
@kpgarrod
Jul 03 2015 08:48
I am noticing (for the last few releases) that some errors are not cleared when I fix them. The only way I can get the errors cleared is to close down Atom (or the project at least) and re-open. Is anybody else getting this?
Basarat Ali Syed
@basarat
Jul 03 2015 08:49
I am getting something like this. Note that the atom-ts error panel does clear errors, just the linter errors keep hanging @kpgarrod is that correct?
Cu3PO42
@Cu3PO42
Jul 03 2015 08:49
I have sometimes noticed that, too, although deleting the line and pasting it again usually does it for me. Using vim-mode that’s just a quick ddP
kpgarrod
@kpgarrod
Jul 03 2015 08:56
@basarat. not sure. I will check. Linter errors are shown in the bottom of the screen, right?
Cu3PO42
@Cu3PO42
Jul 03 2015 08:56
The linter error list should be below the TS bar.
Basarat Ali Syed
@basarat
Jul 03 2015 08:56
blob
the lower one is linter ... it is out of date even right now
kpgarrod
@kpgarrod
Jul 03 2015 09:01
How do I attach a file here?
Basarat Ali Syed
@basarat
Jul 03 2015 09:02
@kpgarrod drop it ... or paste it from clipboard
kpgarrod
@kpgarrod
Jul 03 2015 09:02
Screen Shot 2015-07-03 at 10.58.45 AM
Basarat Ali Syed
@basarat
Jul 03 2015 09:03
@kpgarrod was that a drop?
Cu3PO42
@Cu3PO42
Jul 03 2015 09:03
This message was deleted
Dropping from OS X definitely works...
kpgarrod
@kpgarrod
Jul 03 2015 09:04
Screen Shot 2015-07-03 at 10.58.45 AM.png
sorry, tried pasting
Basarat Ali Syed
@basarat
Jul 03 2015 09:04
@kpgarrod press cmd+s does that fix it?
kpgarrod
@kpgarrod
Jul 03 2015 09:05
You see, I have fixed the error at line 104
there is no coachId there now
As you say, the error disappears from the ts errors
Basarat Ali Syed
@basarat
Jul 03 2015 09:07
"disappears from ts errors" "but sticks in linter errors" right?
kpgarrod
@kpgarrod
Jul 03 2015 09:07
no, cmd+s does not fix it
even closing and reopening the file doesn't
@basarat: yes, right
Basarat Ali Syed
@basarat
Jul 03 2015 09:09
cool It's an issue with the new linter rewrite. I am hoping other lint clients (like us) will suffer the same fate and someone there will fix it :)
It's not particularly easy to reproduce
I've even tried execing "linter:lint" command and even that doesn't fix it
Cu3PO42
@Cu3PO42
Jul 03 2015 09:10
:/
Basarat Ali Syed
@basarat
Jul 03 2015 09:10
This is their gitter page btw : https://gitter.im/AtomLinter/Linter
Cu3PO42
@Cu3PO42
Jul 03 2015 09:11
The joys of being dependant on someone else fixing errors
Basarat Ali Syed
@basarat
Jul 03 2015 09:12
we could put in the effort (its oss) ... just because nearly everybody who uses atom uses linter => they will get a clear issue report soon
and they are actively maintaing it :rose:
Cu3PO42
@Cu3PO42
Jul 03 2015 09:13
Maybe I’ll look into it after I get sourcemaps working for the node debugger
Basarat Ali Syed
@basarat
Jul 03 2015 09:13
blob
what I'm working on ^ typescript/register support
for node
Cu3PO42
@Cu3PO42
Jul 03 2015 09:13
That’s awesome!
kpgarrod
@kpgarrod
Jul 03 2015 09:14
@basarat: actually, the typescript error doesn't always get cleared
Basarat Ali Syed
@basarat
Jul 03 2015 09:15
@kpgarrod ctrl+s should clear that : https://github.com/TypeStrong/atom-typescript#sync
does it?
If so I know I have a bug to find :) lately I haven't needed that
kpgarrod
@kpgarrod
Jul 03 2015 09:16
no, it doesn't
Basarat Ali Syed
@basarat
Jul 03 2015 09:17
:(
screenshot?
kpgarrod
@kpgarrod
Jul 03 2015 09:19
Screen Shot 2015-07-03 at 11.15.18 AM.png
Cu3PO42
@Cu3PO42
Jul 03 2015 09:19
Can you consistently reproduce that?
kpgarrod
@kpgarrod
Jul 03 2015 09:20
not sure, but it seems to be happening regularly
Basarat Ali Syed
@basarat
Jul 03 2015 09:21
in a not so loud voice (at least its not a bug in linter then) ashamed
Cu3PO42
@Cu3PO42
Jul 03 2015 09:23
Welp, I can’t seem to be able to reproduce that
In my code
kpgarrod
@kpgarrod
Jul 03 2015 09:24
I just updated to 5.0.9 and the errors have gone for now
Cu3PO42
@Cu3PO42
Jul 03 2015 09:24
Awesome!
kpgarrod
@kpgarrod
Jul 03 2015 09:25
I'll try to watch out for the exact conditions that cause it if it happens again
Cu3PO42
@Cu3PO42
Jul 03 2015 09:25
That’ll be great :)
kpgarrod
@kpgarrod
Jul 03 2015 09:26
mmm, back again
Basarat Ali Syed
@basarat
Jul 03 2015 09:27
screenshot ... before it goes too bad
kpgarrod
@kpgarrod
Jul 03 2015 09:27
it seems that linter was still linting when the errors had disappeared
after the linter errors appeared, the ts errors got stuck as well (maybe)
just looking at my packages, I see I have linter and linter-tslint disabled
installed but disabled
Basarat Ali Syed
@basarat
Jul 03 2015 09:30
Just a tip (that might help understand it better):
  • ts errors are the source of truth .... they are sync matched with code editor changes by us
  • linter errors cannot impact any other portion of our code paths. linter has a read only view of our state. But they may be out of sync
screenshot of the errors please. I want to see them before they become 7
remote debugging : - )
kpgarrod
@kpgarrod
Jul 03 2015 09:35
well, I've uninstalled linter
and still have the problem
Basarat Ali Syed
@basarat
Jul 03 2015 09:36
@kpgarrod screenshot in current state please
fwiw we will reinstall linter on next atom reboot ... so that will not help
kpgarrod
@kpgarrod
Jul 03 2015 09:37
Screen Shot 2015-07-03 at 11.35.56 AM.png
Basarat Ali Syed
@basarat
Jul 03 2015 09:37
@kpgarrod atom version?
kpgarrod
@kpgarrod
Jul 03 2015 09:38
1.0.0
Basarat Ali Syed
@basarat
Jul 03 2015 09:41
@kpgarrod if its happening reliably can we get a gif?
kpgarrod
@kpgarrod
Jul 03 2015 09:48
How do I do that?
Cu3PO42
@Cu3PO42
Jul 03 2015 09:49
@kpgarrod on a mac you could use http://recordit.co
Basarat Ali Syed
@basarat
Jul 03 2015 09:50
blob
kpgarrod
@kpgarrod
Jul 03 2015 09:51
thanks
Cu3PO42
@Cu3PO42
Jul 03 2015 09:51
I always thought that was Windows only… A lesson learned
kpgarrod
@kpgarrod
Jul 03 2015 10:02
It seems to be a problem with this specific file
now I'm not getting any errors at all!
Basarat Ali Syed
@basarat
Jul 03 2015 10:03
its 8pm here on a friday night. I'm heading home. Sorry :rose:
Cu3PO42
@Cu3PO42
Jul 03 2015 10:03
Have a great evening!
kpgarrod
@kpgarrod
Jul 03 2015 10:05
@basarat: enjoy your weekend
helarqjsc
@helarqjsc
Jul 03 2015 17:09
@basarat I've noticed that atom.d.ts in this repo differs significantly from the one in DefinitelyTyped. Some methods are missing, a lot of methods have been added (e.g. onDidChangeActivePaneItem and other event subscriptions). Is there a reason why they are maintained separately? Wouldn't it be better and easier for everybody to push changes from this repo to the main branch of DT?