by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 04 17:01
    christopherthielen opened #1318
  • Jun 04 00:46
    ShiMeiWo closed #379
  • Jun 04 00:46
    ShiMeiWo commented #379
  • Jun 03 00:59
    capraynor closed #1317
  • Jun 03 00:59
    capraynor commented #1317
  • Jun 02 16:50
    krisztianb commented #1316
  • Jun 02 13:25
    Gerrit0 commented #1317
  • Jun 02 13:23
    Gerrit0 commented #1316
  • Jun 02 09:33
    capraynor edited #1317
  • Jun 02 09:33
    capraynor opened #1317
  • Jun 02 02:06
    Gerrit0 commented #521
  • Jun 01 22:27
    TheBrokenRail commented #1313
  • Jun 01 09:48
    jayarjo commented #521
  • May 31 07:45
    aztack commented #1182
  • May 31 06:44
    aztack commented #1295
  • May 30 20:09
    krisztianb commented #1311
  • May 30 18:34
    Gerrit0 commented #1311
  • May 30 17:38
    krisztianb labeled #1316
  • May 30 17:38
    krisztianb opened #1316
  • May 30 17:26
    krisztianb commented #1311
there are very critical secruity alerts with it but i'm not too sure if that too important?
Gerrit Birkeland
@Gerrit0
Yikes that hasn't been updated in a while
The default theme doesn't even have jQuery anymore, which fixes the biggest security issues
HarryET
@HarryET
yup I found it and customized it so it was dark mode
note sure really how to fix them though... this is my first time using typedoc
Gerrit Birkeland
@Gerrit0
Yea, I need to write better docs for creating themes... and just about everything else.
HarryET
@HarryET
wdym?
any help to make it work with search.json and fix a few of the big security issues would be helpful though. If that possible xD
Gerrit Birkeland
@Gerrit0
There is https://typedoc.org/guides/themes/ which covers some of how to create a theme, but there is a lot missing there that is useful to know
think that might be better if i convert it to dark mode
dont know wether it uses search.js or search.json though
but the one i sent might be ok if it was patched? if that even possible?
Gerrit Birkeland
@Gerrit0
Definitely possible, it doesn't look like neo theme has been updated either.
HarryET
@HarryET
think it is as dependabot want to update it
gonna merge all of dependabots prs
Gerrit Birkeland
@Gerrit0
Pulling it down to take a closer look
HarryET
@HarryET
ok, 4 dependencies are being updated now!
Gerrit Birkeland
@Gerrit0
It might be easier to clone the default theme and update that
HarryET
@HarryET
really?
Gerrit Birkeland
@Gerrit0
Where'd you clone this one from?
HarryET
@HarryET
lemme get it
Gerrit Birkeland
@Gerrit0
Okay yea, that doesn't have any real changes from the default themes
I miss the git history ._. Can't easily look and see what you changed from the default theme
HarryET
@HarryET
ok, so i'm not sure what to do to make mine look simmilar tto that.
could you help me?
@Gerrit0
HarryET
@HarryET
wait, i think i got it now
the only thing is i dont know how to change the search.js to search.json @Gerrit0
Gerrit Birkeland
@Gerrit0
There are other changes that have happened too that you probably want. I'd fork https://github.com/TypeStrong/typedoc-default-themes, then just update _constants.sass with your colors
Then you won't have to update the search
HarryET
@HarryET
oh, thats what im doing
should search just work?
Gerrit Birkeland
@Gerrit0
Yea
So long as its on a web server
HarryET
@HarryET
using github pages
Gerrit Birkeland
@Gerrit0
That'll work
Just won't work if you try to open the html file in your browser, there there's a bug where it still tries to load search.js (#1279)
HarryET
@HarryET
ah, ok
going to build my docs and test locally to check theme is correct
HarryET
@HarryET
@Gerrit0 works perfect going locally going to put on github pages and test the search
Gerrit Birkeland
@Gerrit0
:+1:
HarryET
@HarryET
@Gerrit0 search is wokring apart from a ' at the end of each result
weird.PNG
i gtg be back in about 30mins
Easy to fix if you want to send a PR
HarryET
@HarryET
@Gerrit0 PR sent