Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 24 2019 19:46

    Doug-Reed on master

    fix: remove ratings from detail… fix: remove ratings from app br… doc: updates CHANGELOG and 1 more (compare)

  • Jan 24 2019 19:46
    Doug-Reed closed #870
  • Jan 24 2019 17:20
    Doug-Reed synchronize #870
  • Jan 24 2019 17:20

    Doug-Reed on rating

    doc: updates CHANGELOG (compare)

  • Jan 24 2019 17:18
    Doug-Reed opened #870
  • Jan 24 2019 17:07

    Doug-Reed on rating

    fix: remove ratings from app br… (compare)

  • Jan 24 2019 16:34

    Doug-Reed on rating

    fix: remove ratings from detail… (compare)

  • Jan 16 2019 10:46
    greenkeeper[bot] commented #861
  • Jan 16 2019 10:33

    greenkeeper[bot] on stylelint-9.10.0

    chore(package): update stylelin… chore(package): update lockfile… (compare)

  • Jan 15 2019 11:08

    greenkeeper[bot] on @commitlint

    (compare)

  • Jan 15 2019 11:04

    greenkeeper[bot] on @commitlint

    (compare)

  • Jan 15 2019 10:50

    greenkeeper[bot] on @commitlint

    chore(package): update @commitl… chore(package): update lockfile… (compare)

  • Jan 15 2019 10:46

    greenkeeper[bot] on @commitlint

    chore(package): update @commitl… chore(package): update lockfile… (compare)

  • Jan 02 2019 19:33

    greenkeeper[bot] on eslint-plugin-markdown-1.0.0

    (compare)

  • Jan 02 2019 19:26

    greenkeeper[bot] on eslint-plugin-markdown-1.0.0

    chore(package): update eslint-p… chore(package): update lockfile… (compare)

  • Dec 28 2018 02:31
  • Dec 17 2018 22:01
    greenkeeper[bot] commented #853
  • Dec 17 2018 22:01

    greenkeeper[bot] on karma-3.1.4

    chore(package): update karma to… chore(package): update lockfile… (compare)

  • Dec 05 2018 18:05

    apetro on rm-rate-from-static-and-exclusive

    (compare)

  • Dec 05 2018 18:05

    apetro on master

    fix: rm "Rate {app}" button fro… (compare)

Tim Levett
@timlevett
We pull all information from uPortal's API
James Wennmacher
@jameswennmacher
Perfect. I assume the portal has to redirect the authenticated user via /Login to the /web URL?
Thanks for responding BTW :smile:
Are you guys still using this tool?
Tim Levett
@timlevett
What we do for shib is protect /web and /portal. If a user hits either and doesn't have a valid session we redirect to shib, then redirect to /portal/Login. Then in the pipeline if they are on the proper profile, we terminate the pipeline and redirect to /web
This isn't our primary communication location, but i think we still use it from time to time
James Wennmacher
@jameswennmacher
Is there another tool for non-UWM folks to collaborate with you on? Yesterday I directed the Sinclair dev team to here :smile:
Tim Levett
@timlevett
I think this may be a good medium to talk angularjs-portal, that or on the uportal-dev list? what are your thoughts? PS, sorry to hear you are leaving...
and congrats on your new opportunity!
James Wennmacher
@jameswennmacher
Thanks. I'm really going to miss working with all of you. It's been great. IMHO this gitter channel is great. I think keeping it separated at the moment is probably reasonable to minimize confusion but it is really what works for all of you.
I'll have to find that pipeline component Andrew P added and configure it or do an equivalent. Thanks for clarifying to me how it works!
Tim Levett
@timlevett
Yeah, this works for us. Sorry for the delay in response. I meant to reply yesterday but lost all the time
np, i'll send a gist with some pipeline config
James Wennmacher
@jameswennmacher
BTW I suggested to the Sinclair team that they try to make changes in a way they can submit PRs to your repo. They aren't as experienced with git so your team may need to help them a bit, or possibly reach out to them about it in a month or two if they haven't submitted any PRs to see if they can contribute back.
Tim Levett
@timlevett
sounds good. Yes, it seemed they wanted to do some custom work then contribute it after the fact. I'm my experience the longer you wait the more difficult it gets
James Wennmacher
@jameswennmacher
Yep, and it is harder to commit to institutional repo and then push the change to the community repo. I think Drew's approach of committing to community and pulling the change into institutional repo is the way to go.
Tim Levett
@timlevett
here is the snippet of the customization we did to the renderingPipelineContext.xml to get redirects to work properly
basically we have a different profile for the alternative front end
James Wennmacher
@jameswennmacher
Thanks!
Benito Gonzalez
@bjagg
Hey guys, I am setting up an angularjs portal. I started with fresh repos of uPortal and AngularjS-Portal. Portal is on master branch using Hsql. AngularJS-Portal is on master branch running ./.build.sh master.
It's deploying, but I only see loading screen after I log into uPortal as student. Here is the error in the console: angular.js:4659 Uncaught Error: [$injector:unpr] http://errors.angularjs.org/1.5.6/$injector/unpr?p0=FEATURESProvider%20%3C-%20FEATURES
Tim Levett
@timlevett
yeah, that master deploy script is out of date. Let me fix it and push up a PR. Sorry @bjagg
Created UW-Madison-DoIT/angularjs-portal#487 to track
Tim Levett
@timlevett
PR: UW-Madison-DoIT/angularjs-portal#488
Benito Gonzalez
@bjagg
Thanks Tim! I commented on your PR
Still seeing the error about a missing module. It's from angular.bootstrap(document, ['my-app']); in main.js
Tim Levett
@timlevett
that seems like a generic error, is that the whole stack?
Benito Gonzalez
@bjagg
That was the only line in the stacktrace that was project code.
Benito Gonzalez
@bjagg
angular.js:38 Uncaught Error: [$injector:unpr] http://errors.angularjs.org/1.5.6/$injector/unpr?p0=FEATURESProvider%20%3C-%20FEATURES(anonymous function) @ angular.js:38(anonymous function) @ angular.js:4501d @ angular.js:4654(anonymous function) @ angular.js:4506d @ angular.js:4654e @ angular.js:4678invoke @ angular.js:4700(anonymous function) @ angular.js:4516q @ angular.js:322db @ angular.js:4516c @ angular.js:1777Ac @ angular.js:1798(anonymous function) @ main.js:7execCb @ require.js:1693check @ require.js:881(anonymous function) @ require.js:1136(anonymous function) @ require.js:134(anonymous function) @ require.js:1186each @ require.js:59emit @ require.js:1185check @ require.js:936(anonymous function) @ require.js:1136(anonymous function) @ require.js:134(anonymous function) @ require.js:1186each @ require.js:59emit @ require.js:1185check @ require.js:936(anonymous function) @ require.js:1136(anonymous function) @ require.js:134(anonymous function) @ require.js:1186each @ require.js:59emit @ require.js:1185check @ require.js:936enable @ require.js:1173init @ require.js:786callGetModule @ require.js:1200completeLoad @ require.js:1608onScriptLoad @ require.js:1714
Benito Gonzalez
@bjagg
Sorry about the lack of formatting
Tim Levett
@timlevett
no worries. Looks like you may still be overriding the app-config.js. did you upgrade your master after the latest pull request merged?
its not finding the FEATURES value, but if you are using master-override.js instead of master-app-config.js that shouldn't be an issue. try a mvn clean and then run build.sh master.
Benito Gonzalez
@bjagg
I noticed that the content of config.js is a comment saying it's a placeholder
I didn't have have npm and other tools installed on my Linux box, but once I realized that spent time installing things
Even played with Angular version ... bumped to 1.5.8
But, yes, I checked out master, cleaned up changes and ran 'mvn clean && ./build.sh master'
Tim Levett
@timlevett
the config.js is for a google analytics key, should be fine if not configured. See http://uw-madison-doit.github.io/uw-frame/latest/#/md/ga for more ga config setup, again, not required
hmmm, so try some things for me just to make sure its only an issue with the build.sh master.
Try just doing the following.
1) shutdown your remote tomcat
2) run mvn clean package && mvn jetty:run. This should bring up angularjs-portal on /web and mock portal on /portal. Does that work?
Tim Levett
@timlevett

3) if that works do a git status and provide the output via a gist.github.com.

I'm going to work on setting up vanilla uportal with angularjs-portal master build just to see if i can recreate it

another thought is you may be getting cached content. If you look at the web.xml in angularjs-portal we put a 10 minute cache on all JS
So one may suggest incognito window or run with dev tools open with cache disabled
Tim Levett
@timlevett
i'll wait to hear from you before diving into if i can recreate, hope this helps.
Benito Gonzalez
@bjagg
I was able to get the mock portal up after I did a pull. Thanks! There were still some JS console errors, but I can move forward. Appreciate the help!
Yeah, I had been working on your branch and forgot to pull when I switched back to master -- silly me
Tim Levett
@timlevett
yeah, there may be some errors about fetching content from /storage
ah, that'll happen :D
we created a very simple key/value store that we deploy to /storage