Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 24 2019 19:46

    Doug-Reed on master

    fix: remove ratings from detail… fix: remove ratings from app br… doc: updates CHANGELOG and 1 more (compare)

  • Jan 24 2019 19:46
    Doug-Reed closed #870
  • Jan 24 2019 17:20
    Doug-Reed synchronize #870
  • Jan 24 2019 17:20

    Doug-Reed on rating

    doc: updates CHANGELOG (compare)

  • Jan 24 2019 17:18
    Doug-Reed opened #870
  • Jan 24 2019 17:07

    Doug-Reed on rating

    fix: remove ratings from app br… (compare)

  • Jan 24 2019 16:34

    Doug-Reed on rating

    fix: remove ratings from detail… (compare)

  • Jan 16 2019 10:46
    greenkeeper[bot] commented #861
  • Jan 16 2019 10:33

    greenkeeper[bot] on stylelint-9.10.0

    chore(package): update stylelin… chore(package): update lockfile… (compare)

  • Jan 15 2019 11:08

    greenkeeper[bot] on @commitlint

    (compare)

  • Jan 15 2019 11:04

    greenkeeper[bot] on @commitlint

    (compare)

  • Jan 15 2019 10:50

    greenkeeper[bot] on @commitlint

    chore(package): update @commitl… chore(package): update lockfile… (compare)

  • Jan 15 2019 10:46

    greenkeeper[bot] on @commitlint

    chore(package): update @commitl… chore(package): update lockfile… (compare)

  • Jan 02 2019 19:33

    greenkeeper[bot] on eslint-plugin-markdown-1.0.0

    (compare)

  • Jan 02 2019 19:26

    greenkeeper[bot] on eslint-plugin-markdown-1.0.0

    chore(package): update eslint-p… chore(package): update lockfile… (compare)

  • Dec 28 2018 02:31
  • Dec 17 2018 22:01
    greenkeeper[bot] commented #853
  • Dec 17 2018 22:01

    greenkeeper[bot] on karma-3.1.4

    chore(package): update karma to… chore(package): update lockfile… (compare)

  • Dec 05 2018 18:05

    apetro on rm-rate-from-static-and-exclusive

    (compare)

  • Dec 05 2018 18:05

    apetro on master

    fix: rm "Rate {app}" button fro… (compare)

Benito Gonzalez
@bjagg
Thanks!
Tim Levett
@timlevett
@bjagg as promised: Jasig/uPortal#702
Benito Gonzalez
@bjagg
Cool -- things are looking good
Tim Levett
@timlevett
Indeed, thanks for the quick review!
as you can see there has been a big push from our side to move to more of a materialized design using Angular Material
Benito Gonzalez
@bjagg
Hey Tim, I'm back. Working on the redirect from the snippet you gave earlier. Where do you define angular.landing.page in your portal project? (Want to keep consist with you.)
Tim Levett
@timlevett
i think its portal.properties
but let me confirm
welcome back!
actually i was wrong, its actually in uportal-war/src/main/resources/properties/security.properties
angular.landing.page=/web/
angular.profile.name=bucky
Benito Gonzalez
@bjagg
Thanks. I will run with that!
Tim Levett
@timlevett
anytime
Benito Gonzalez
@bjagg
Oh, would you mind contributing org.jasig.portal.rendering.predicates.URLInSpecificState and org.jasig.portal.rendering.predicates.RenderOnWebFlagSet?
Tim Levett
@timlevett
sure!
Tim Levett
@timlevett
@bjagg - Jasig/uPortal#708
Benito Gonzalez
@bjagg
Thanks!!
Benito Gonzalez
@bjagg
Looks like an enhancement to RedirectRenderingPipelineTerminator.java was also done
Benito Gonzalez
@bjagg
The appender property was added to that class
Benito Gonzalez
@bjagg
I hate colds!
Anyhoo, do you have the changes to the class above?
Benito Gonzalez
@bjagg
Any integration with Solr?
Tim Levett
@timlevett
for whatever reason i never saw RedirectRenderingPipelineTerminator
i can take a look tomorrow
Benito Gonzalez
@bjagg
ok thx
it's prob not too many lines of code, but I didn't want to write a separate version and deal with conflicts
Tim Levett
@timlevett
@bjagg PR for Terminator appender enhancement Jasig/uPortal#712
Benito Gonzalez
@bjagg
Thanks Tim!
Benito Gonzalez
@bjagg
@im
@timlevett Things are looking good with the redirect. Thanks for all your help!
Tim Levett
@timlevett
excellent! glad to hear it
Benito Gonzalez
@bjagg
So with the default implementation of Notifications, only a title and link is displayed? Not notification body?
greghollenbaugh
@greghollenbaugh
Is it possible to have different portlet/tile title colors?
Tim Levett
@timlevett
@bjagg - correct, no body. If you wanted to add in the possibility of body that would be a great edition
@greghollenbaugh - currently all icons in compact mode are black, but that could be a good enhancement, maybe in the widgetConfig
In expanded mode the widget con be whatever you want, but default to similar to the compact mode.
Tim Levett
@timlevett
created UW-Madison-DoIT/angularjs-portal#528 for the color change of the fa-icon
please feel free to create issues for things you want the product to do.
Benito Gonzalez
@bjagg
Hey guys, I added a menu bar with menus based on uPortal tabs and menu items that link to portlets in those tabs
That works well
Now, the request is to allow clicking on menu titles to display the current tab portlets as tiles in AngularJS-Portal
Benito Gonzalez
@bjagg
Trying to estimate this. At first review, I need to dynamically set Service_Loc.layout and .layoutTab. I suspected caching may need to adjusted to handle different tabs
anything else you can think of?
Tim Levett
@timlevett
That seems to make sense. I believe the cache key is the URL, so if that is changing then the cache will only return a specific tab, but you can set cache:false in the $http.get call
Benito Gonzalez
@bjagg
Any other code that may need to be modified to support this? Hopefully it is that simple, but "that simple" is rarely the case :)
Tim Levett
@timlevett
yeah, that should be about it
Benito Gonzalez
@bjagg
Thanks @timlevett . So in the function to switch tabs, I am changing SERVICE_LOC.layout and .layoutTab. Whats the best way to refresh the page without undue API calls?
Tim Levett
@timlevett
I would recommend making a route for each tab
so if you land on say /web/expanded it'll just do a default tab
or the first tab