Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

UltraStar-Deluxe/USDX

Code and project files of USDX

People

Repo info

Activity

06:15

bohning commented #583
06:09

bohning commented #583
Jun 13 23:04

basisbit commented #583
Jun 13 22:05

s09bQ5 edited #583
Jun 13 22:00

s09bQ5 opened #583
Jun 13 21:43

s09bQ5 on ffmpeg-4.3-4.4

Replace FFmpeg 4.0 units with m… (compare)
Jun 07 10:59

deuteragenie commented #538
Jun 07 10:49

s09bQ5 commented #538
Jun 07 10:46

chordig commented #582
Jun 07 10:45

chordig edited #582
Jun 07 10:45

chordig edited #582
Jun 07 10:44

chordig edited #582
Jun 07 10:40

deuteragenie commented #538
Jun 07 10:37

deuteragenie commented #538
Jun 07 10:36

deuteragenie commented #538
Jun 07 09:57

s09bQ5 commented #538
Jun 07 09:08

deuteragenie commented #538
Jun 07 08:50

chordig edited #582
Jun 07 08:48

chordig edited #582
Jun 07 08:43

chordig edited #582

Markus Böhning

@bohning

is anybody on here using Ubuntu 18.04?

Markus Böhning

@bohning

@s09bQ5 would it be easily adaptable to read/write playlist files (*.upl) as UTF-8? Or is that already happening?

s09bQ5

@s09bQ5

@bohning, according to issue #152, where you participated in the discussion, USDX already reads and writes playlists in UTF-8

Markus Böhning

@bohning

Hahaha, sorry, I could have found that myself. Someone opened an issue for UltraStar Manager regarding an encoding problem of playlist files and I came to the conclucsion, that USDX must output CP1252. Thanks a lot.

Markus Böhning

@bohning

One of the features I am missing the most in current USDX (compared to CMD) is the feature of changing the display of the video (or: how the video is currently displayed).

In order to avoid black bars on top/bottom in the video preview (song selection) stealing space in the small cover-sized preview, I remove black bars from my videos with HandBrake. However, currently, videos are displayed to fill the available screen height, thus cropping lots of video data on the left and right for widescreen videos.

In CMD, it was possible to toggle between crop, stretch and fill (or something like that). I’d be very happy if I could at least switch the behavior so that widescreen videos are shown in full width, adding black bars at the top/bottom.

Thus, these options would be nice:

fill height (crop left/right or add black bars left/right if necessary)
fill width (crop top/bottom or add black bars top/bottom if necessary)
fill to either width or height (add black bars where necessary, do not crop)

Since there is a wide variety of video aspect ratios (some old ones almost square, some newer ones extremely widescreen), I would probably resort to the last option as a default. In CMD, it could be toggled for each video and the setting was saved (but I would not need that and I think that would be a lot of work).

I looked at the CMD code and a while ago tried to implement that in the current USDX, but it was more comprehensive than I thought and failed.

So if anyone able to code this thinks this is a good idea, I’d be glad to help and discuss =)

Cheers!

(with black bars in video preview)

Markus Böhning

@bohning

(black bars removed via HandBrake)

s09bQ5

@s09bQ5

You do realize that there is already a member variable fAspectCorrection in the TVideo_FFmpeg class that can be set to the values acoStretch, acoCrop, and acoLetterBox? It is just always set to acoCrop. The jukebox uses the 'A' key to cycle between the modes, but the value is never assigned to the TVideo_FFmpeg object.

Markus Böhning

@bohning

Ah, I did not know that! So ’A’ cycles between the modes (in jukebox mode), but it currently has no effect, correct?

s09bQ5

@s09bQ5

Didn't try it, but the code for 'A' looks broken

Markus Böhning

@bohning

I tried pressing ’A’ in jukebox mode - nothing happens (as expected after your explanation)

Markus Böhning

@bohning

So from what I understand, acoLetterBox seems to be the most sensible option as default for most videos/users, rather than crop?

acoLetterBox means, it would add black bars on top/bottom, if the video is more widescreen than the screen, and would add black bars on left/right if the screen is more widescreen than the video (no information lost)

acoCrop always loses video information by cropping parts of the video (top/bottom or left/right), at the upside that the entire screen is filled with the video (no black bars)

I guess it’s a matter of taste - some would prefer to see the full video and doesn’t mind the black bars, some would prefer to fill the screen with the video and don’t mind the cropping

It really only makes a big difference for very widescreen videos, such as 1.84:1, 2.39:1, 2.75:1 or even 4:1

Markus Böhning

@bohning

for testing, I just changed the default AR to LetterBox, but have to go back to Lua5.3 to be able to compile (Lua5.4.2 not supported)

shall I open an issue for that?

Markus Böhning

@bohning

Okay, compiled now with acoCrop in SongSelection, but acoLetterBox in SingScreen:

Obviously, my screen is more widescreen than the video, therefore black bars left and right as expected.

Markus Böhning

@bohning

Counterexample: very widescreen video, acoCrop in SongSelection (video preview), but acoLetterBox in SingScreen

I really prefer that behavior as default. What are you thoughts?

I think for small deviations between video and screen ARs, crop is acceptable, hardly noticeable and thus preferable in order to have a full screen video, but undesirable if video and screen ARs are too different, then LetterBox seems to be the more reasonable option

Markus Böhning

@bohning

Ergo, a perfect solution for me would be: if AR difference is below a certain threshold (adjustable), use acoCrop, if it’s above a certain threshold, use acoLetterbox (set threshold to 0 to force acoLetterBox)

Markus Böhning

@bohning

UltraStar-Deluxe/USDX#562

With this PR, LetterBox is default, aspect ratio can be toggled via ’A’ (in SingScreen). However, the setting is not saved (unlike in CMD, where it was stored somehow).

Markus Böhning

@bohning

shall I open an issue for that?

Never mind, already exists (#557).

Markus Böhning

@bohning

Hey y’all

Markus Böhning

@bohning

I have (finally) successfully extended the appveyor CI script to build for all three platforms.

The upside of AppVeyor is that it allows to store build artifacts for up to 6 months (depeding on file size) – and I don’t see a downside to build on Travis and on AppVeyor in parallel. Plus I think the Travis build for Linux was broken anyways, right?

For Windows, I haven’t tested the resulting Installer or portable version, for Mac it seems that there the resulting dmg contains different versions of some libraries and it does not work on my mac, and for Linux, I fail at running the resulting AppImage (it’s the first time I have worked with AppImages.

So far, the changes are in my fork. If any of you can help with either platform, it would be highly appreciated.

https://ci.appveyor.com/project/bohning/usdx-b86ct/builds/37727542

(click on the respective platform, then select „Artifacts“ in the menu)

Orpheo

@orpheomusik_twitter

Hey everyone! I have the following problem: I imported a .mid file and created a song with it. However whenever i play the song Ultrastar shows all notes from the song on the first screen. I created the same song just with a .txt without the midi and then the problem doesnt appear.

Anyone knows a solution?

Elijah Lucian

@ELI7VH

hi friends. Is this open for anybody to contribute their songs?

basisbit

@basisbit

@ELI7VH there exists a songs repository where you may add any create-commons (or similar) licensed music: https://github.com/UltraStar-Deluxe/songs

Elijah Lucian

@ELI7VH

dope. thank you :)

Morten

@mnissov

is it possible to select who's singing from a pool when starting a song? Like for example if you have 5 people in a room but only 2 singing at a time: to choose two from the pool of five?

basisbit

@basisbit

this is not yet supported. However what we often do at events is to just assign numbers as player names in usdx and then pass the microphone which is labeled with that number to whoever is supposed to sing next. Also, you might want to try the tournament mode.

Morten

@mnissov

Tournament mode is not quite what I had in mind, it's too structured. A similar comparison would be the player profile setup used in ultra start - play for example.

At least the advantage in my eyes is the ability for personalized leaderboards without needing more than, say, 2 microphones for 1 vs 1 "matches". Unfortunately ultra star play is very much an early alpha at the moment, is this a feature you see coming in the near future?

basisbit

@basisbit

you can also put players on the F1 ..F10 keys and then in the song selection use them to quickly switch between the profiles

Morten

@mnissov

in USDX?

Paul Magnifico

@ChillOutMagic_twitter

Hey guys. I'm not sure if anyone else has had this issue on a MAC. When i try to delete songs....as soon as i load the program again...all the deleted songs re-appear. I have emptied the trash...i have no i cloud or backup activated. Just seeing if anyone else has had this issue and if it's Ultra related or is it my Mac restoring the files?

Markus Böhning

@bohning

Hi @ChillOutMagic_twitter I am on Mac and do not have these problems, so I suppose it is not USDX related

Morten

@mnissov

you can also put players on the F1 ..F10 keys and then in the song selection use them to quickly switch between the profiles

is this applicable to usdx or us-play?

Chat via Matrix