These are chat archives for UltraStar-Deluxe/USDX

4th
Aug 2016
basisbit
@basisbit
Aug 04 2016 10:59
hey, one of your recent changes broke the auto-voice-removal feature. can you please fix that again before I do the beta release? Thanks!
RattleSN4K3
@RattleSN4K3
Aug 04 2016 17:20
I haven't touched anything regarding that.
how is it broken?
RattleSN4K3
@RattleSN4K3
Aug 04 2016 18:29
found the problem. gonna see how it will be fixed (reverted/adjusted)
basisbit
@basisbit
Aug 04 2016 18:29
thanks a lot
RattleSN4K3
@RattleSN4K3
Aug 04 2016 19:17
Hmm. Too lazy to check a proper adjustment for that problem. A quick fix using the SameSize of the source stream wasn't working as expected. The thing is (as far as I checked the implementation), the voice removal expects a given framesize. With the replay gain code, I set BASS to use floating-point data for DSP. therefore the voice removal didn't get the data it was expecting (16 bit; framesize := 4). BASS_CONFIG_FLOATDSP converted it to 32bit, pass it to the DSPs, and convert it back. I'll likely go and revert that specific line (setting bass config). But the problem persists. It can be noticed by playing back a 8bit music file (although very rare anyone uses it...), the file has the same problem. A loud noise can be heared.
UltraStar-Deluxe/USDX@546ccc4
basisbit
@basisbit
Aug 04 2016 20:27
so, what do you think about having the beta release this evening?
RattleSN4K3
@RattleSN4K3
Aug 04 2016 21:04
don't know. personally I think there are some things which should be done before a release (such as a non-dev changelog, or fixed themes etc.). it's up to you