These are chat archives for UltraStar-Deluxe/USDX

5th
Aug 2016
basisbit
@basisbit
Aug 05 2016 07:50
the .nsh install script can't compile because of not supported characters in the language files. I'll release the beta as simple-installer instead.
basisbit
@basisbit
Aug 05 2016 07:56
even after fixing the language files issues, the installer is basically unusable in the current state
RattleSN4K3
@RattleSN4K3
Aug 05 2016 12:45

the installer is basically unusable in the current state

how so?

the .nsh install script can't compile because of not supported characters in the language files

it works just fine. how's that you can't compile.

RattleSN4K3
@RattleSN4K3
Aug 05 2016 12:55
why the installer/zip release name "UltraStar.Deluxe_v1.3.2-beta"? it's inconsistent to previous releases like "ultrastardx-1.1".
basisbit
@basisbit
Aug 05 2016 16:52
uh, then I am doing something wrong with nsis
could you create the file and add it to the release tag?
RattleSN4K3
@RattleSN4K3
Aug 05 2016 16:53
yep
basisbit
@basisbit
Aug 05 2016 16:55
also, I don't really care about consistency for the file names. Don't see a reason why we should not name it however we want
RattleSN4K3
@RattleSN4K3
Aug 05 2016 16:56
there are several reasons
basisbit
@basisbit
Aug 05 2016 16:56
(as long as it contains the version number, name of the game,..)
RattleSN4K3
@RattleSN4K3
Aug 05 2016 16:57
can I re-tag the release on a new commit?
RattleSN4K3
@RattleSN4K3
Aug 05 2016 17:05
btw. nsis compiles but there is a problem with german. i accientally replaced a string (\n\r -> \r\n) which resulted in an escaped K (\K).
RattleSN4K3
@RattleSN4K3
Aug 05 2016 17:32
the installer is ready. some things to verify. The installer installs USDX to a folder named "UltraStar Deluxe 1.3.2 Beta", that's desired right? The start menu also has the version in its folder name. However, the desktop icon only has "Play UltraStat Deluxe". everything's fine what that?
re-tag in order to have the source code with a proper VERSION?
basisbit
@basisbit
Aug 05 2016 18:14
nah, no retagging
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:14
it is basically tagged wrong.
basisbit
@basisbit
Aug 05 2016 18:14
no?
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:14
?
basisbit
@basisbit
Aug 05 2016 18:15
the installer should install to folder %Program Files(x86)%/UltraStar Deluxe
it is not tagged wrong
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:16
is is tagged wrong as the version file hasn't been updated
the referenced commit/repo/revision is wrong
basisbit
@basisbit
Aug 05 2016 18:16
no, 1.3.2 is correct
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:16
and is it not updated.
basisbit
@basisbit
Aug 05 2016 18:17
the next commit after that should be to change the version to 1.3.3
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:17
and the specific release should have "1.3.2-beta" and not "1.3.1+"
basisbit
@basisbit
Aug 05 2016 18:18
but I am not going to discuss this any further. this is a beta and it doesn't matter if such minor things are wrong
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:19
it's not beta. such things are clear to follow. and it has to be like that from day 1
it's the same problem with the merged commit (instaed of continuing an existing repo)
where the problem if I re-tag the correct commit (and obviously remove the current one)?
RattleSN4K3/USDX@c4d9650
basisbit
@basisbit
Aug 05 2016 18:26
I told you already that continuing the repo would have caused a wrong timeline just as your self-merged repo has a wrong timeline now.
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:26
I am talking when you initially creating the repo on github
basisbit
@basisbit
Aug 05 2016 18:26
yes, I know
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:26
you should have pushed the existing mirror instead of adding the "trunk 1.2" aka worldparty mod files
basisbit
@basisbit
Aug 05 2016 18:27
and that has been discussed in the irc and we decided to do it this way for good reasons
but apparently you don't get them. not my problem.
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:27
what'S the good reason?
basisbit
@basisbit
Aug 05 2016 18:27
scroll up, I think this has already been said here
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:27
CVS is not a share place. it's revision control for a reason. the big "merge" just broke it
also "where the problem if I re-tag the correct commit (and obviously remove the current one)?"
basisbit
@basisbit
Aug 05 2016 18:28
also, I am most likely gonna close this gitter channel this weekend. All others use irc and there is no reason in having all the additional work just because you don't like irc
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:30
there are ways to bridge this
gitter is more github related than IRC
what's the answer that question?
basisbit
@basisbit
Aug 05 2016 18:38
no problem, just that this is a waste of time
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:38
it's not your time.
basisbit
@basisbit
Aug 05 2016 18:38
but as always, feel free to do that if you want, as it does not break anything
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:39
I don't want to do so much on my own. it's a community project and thus a consense has to be found.
will the general filename for the program be "UltraStar-Deluxe_vVERSION_APPENDIX" instead of "ultrastardx..."?
basisbit
@basisbit
Aug 05 2016 18:43
I'd prefer that, yes.
v1.3.2-beta is the correction version / tag name
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:44
I keep the registy path with included version in order to have multiple verisons installed.
basisbit
@basisbit
Aug 05 2016 18:44
that is not a good idea
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:44
is not conflicting at all
basisbit
@basisbit
Aug 05 2016 18:44
in windows, you should have just one version installed
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:45
it currently is like that
basisbit
@basisbit
Aug 05 2016 18:45
the standard user will not know what version to use
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:45
a installer force to uninstall
but in case someone wants to test a dev version and use a provided installer version, it should be possible to install such versions side by side
basisbit
@basisbit
Aug 05 2016 18:46
shortcuts, folder names, registry entries should always be without version numbers
RattleSN4K3
@RattleSN4K3
Aug 05 2016 18:48
I don't disagree there. but beta tests should be supported (with installer as well). I think adding the version for dev builds could fit well
basisbit
@basisbit
Aug 05 2016 18:52
please no, because then that would not be full testing
and it would create additional shortcuts/...
also the 1.3.2-beta is by far way more playable and stable than any of the previous versions
what version of nsis do you use?
RattleSN4K3
@RattleSN4K3
Aug 05 2016 19:19
latest
basisbit
@basisbit
Aug 05 2016 22:16
so, you still plan on doing the setup file?
RattleSN4K3
@RattleSN4K3
Aug 05 2016 23:17
I am doing it already. had to update some other things.