Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 17:07
    updateclibot[bot] auto_merge_enabled #1011
  • 17:07
    updateclibot[bot] labeled #1011
  • 17:07
    updateclibot[bot] labeled #1011
  • 17:07

    updateclibot[bot] on updatecli_6a1c726e25648f93a45aa3b540ba8fd6307a62f92830404f55259bfbbc1b3c6f

    chore: Updated the content of t… (compare)

  • 17:07
    updateclibot[bot] opened #1011
  • Nov 30 07:30
    dduportal labeled #1009
  • Nov 30 06:59
    olblak synchronize #973
  • Nov 30 06:59
    olblak edited #1003
  • Nov 30 06:58
    olblak edited #1003
  • Nov 30 06:58
    olblak edited #1003
  • Nov 29 20:18
    olblak synchronize #1003
  • Nov 29 19:23
    olblak synchronize #1003
  • Nov 29 19:22
    olblak synchronize #1003
  • Nov 29 19:19
    dduportal synchronize #990
  • Nov 29 19:19

    dduportal on rename

    wip: rename pullrequest files t… wip: rename code references fro… wip: add deprecation of pullreq… and 4 more (compare)

  • Nov 29 19:19
    olblak synchronize #1003
  • Nov 29 13:47

    dduportal on updatecli_cac467f9bdc931266038f8cf363edc865370121deb3954b93e70d0588827a04f

    (compare)

  • Nov 29 13:47

    dduportal on main

    chore: Updated the content of t… (compare)

  • Nov 29 13:47
    dduportal closed #1010
  • Nov 29 13:46
    dduportal auto_merge_disabled #1010
olblak
@olblak:matrix.org
[m]
It's not urgent so I'll wait a bit
Regarding the docker-compose PR, did you try it recently? In the current state, the feature is usefull to me but I am a bit out of idea on how to improve it
olblak
@olblak:matrix.org
[m]
I just discover that a docker image tag and digest can be used together such as updatecli/updatecli:v0.38.0@sha256:e420b84349f75cb25ca7fe88ec510afa418a0aec7d3d8e639e337669a377099d
This could could reconcile me with digest
olblak
@olblak:matrix.org
[m]
I recently got affected on the other side because of https://github.com/updatecli/updatecli/issues/632#issuecomment-1096552409
The gittag target do not returned file changes, so it creates the gittag if needed then return an error because no files where changed which is expected
Thanks for the discussion back then because I was about to blindly revert the PR but I guess I need to find a better solution
dduportal
@dduportal:matrix.org
[m]
olblak: in the case of gittag (and gitbranch if implemented for targets) targets, would that make sense to add the .git file as the changed file?
olblak: I'm also working on removing the concept of SCM from targets (to delegate it to actions only). As part of this experiment, I thought about how the plugin should handle themselves the return status (instead of trying magically to determine it).
olblak: OH. Can you share your manifest with this error please, I think I have an idea. (TL;DR; you don't need an scmid for a target of kind gittag)
olblak
@olblak:matrix.org
[m]
Ooooh that a very good point, I'll share that later today
olblak
@olblak:matrix.org
[m]
dduportal: I am planning to release the docker-compose file once I wrote the documentation, I don't have a better implementaiton at the moment
dduportal
@dduportal:matrix.org
[m]
olblak: would be 0.39.0 right? Make sense. Is it ok if we "try" to target 0.40.0 for the s/pullrequests/actions/ (but only if it is ok for you of course regarding approval review and tests)?
olblak
@olblak:matrix.org
[m]
0.39.0 is the next version. I had a look to your PR and it already looks great but it's still in draft mode so I don't know if you plan to add more to it
The docker-compose could also be release. I am waiting for it to merge to implement a first version of Dockerfile autodiscovery
dduportal
@dduportal:matrix.org
[m]
olblak: could you start (if not already done), the doc PR for docker-compose ?
olblak
@olblak:matrix.org
[m]
I started but I didn
't finish it yet
dduportal
@dduportal:matrix.org
[m]
that is the same status for my PR in fact: I won't move it out of draft until I got a "valid" doc PR. 😅
hervelemeur
@hervelemeur:matrix.org
[m]
olblak
@olblak:matrix.org
[m]
I also missed the 100 release :p
olblak
@olblak:matrix.org
[m]
If something want to review the docker-compose documentation
dduportal
@dduportal:matrix.org
[m]
during the week-end most probably 👍️
olblak
@olblak:matrix.org
[m]
olblak
@olblak:matrix.org
[m]
Just for info I'll hold any new release before next weekend
dduportal
@dduportal:matrix.org
[m]
I’ve started to review your pr, but i do it by parts
dduportal
@dduportal:matrix.org
[m]
olblak: about updatecli/updatecli#973 I think I have a solution for the flakiness
olblak: btw 2 general nitpicks:
  • Can you regroup the "if err != nil" blocks with the function call before: you tend to add (randomly) empty lines sometime (e.g. remove the empty line because there is no logic separation when reading code between a function call and return error if not nil)
  • Same for the empty line that appears sometime between a function signature and the first line of their body. It makes the code harder to read
dduportal
@dduportal:matrix.org
[m]
olblak: I've pushed my proposed change to test the (not anymore?) flakiness.
hervelemeur
@hervelemeur:matrix.org
[m]
wolfi-dev/os#131
WDYT of suggesting them to use updatecli?
olblak
@olblak:matrix.org
[m]
because it seems they are working on something similar
And James seems on the hooks
olblak
@olblak:matrix.org
[m]
That being said
Would be usefull
olblak
@olblak:matrix.org
[m]
dduportal: do you still have code need for the action PR?
1 reply
hervelemeur
@hervelemeur:matrix.org
[m]
olblak
@olblak:matrix.org
[m]
Indeed that's a project which I follow from far. Ghuilherme reached out to me two weeks ago to show me the POC he did :)
dduportal
@dduportal:matrix.org
[m]

I'm going to release v0.38.1 to shipp the commit messages fixes from @macedom.

olblak I've fixed the labels of a few PRs (updatecli/updatecli#1006 is a bugfix, not an enhancement, abd the 2 documentation PRs were missing the correct labels).

olblak
@olblak:matrix.org
[m]
hervelemeur: If you are familiar with the NPM registry updatecli/updatecli#1009
and have some suggestion
I won't have the time to review PR until I am back home
hervelemeur
@hervelemeur:matrix.org
[m]
Sorry haven't took the time yet
olblak
@olblak:matrix.org
[m]
Still in Stockholm :-)