These are chat archives for Viridovix/show-me-the-code-github

9th
Nov 2015
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:42
Hi, new PR Viridovix/show-me-the-code-github#27
Commit message validation
Definitely not the final solution, but at least something to work with
Michal Kordas
@mkordas
Nov 09 2015 21:43
Thanks Łukasz - are commit-msg files treated by default as hooks?
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:43
+#Hooks aren’t transferred with a clone of a project
+#You must copy that script to .git/hooks directory and make it executable
Michal Kordas
@mkordas
Nov 09 2015 21:44
Ok, now I see
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:44
if you move it where it belongs, it will work
Michal Kordas
@mkordas
Nov 09 2015 21:44
so everyone needs to do that?
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:44
yep
Michal Kordas
@mkordas
Nov 09 2015 21:45
isn't there any solution to execute hook on server when someone will forget to copy the script?
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:45
there are server-side scripts, but i still need to learn about that
still ,this solution is recommended to have even if there is a server side hook
in case of multi commit PRs - it prevents from being rejected by server because one of the commits is invalid
Michal Kordas
@mkordas
Nov 09 2015 21:47
sure - maybe even Gradle could move this file when not moved yet?
I mean copy file
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:47
But glad you asked - i di not mark this pr as closing an issue because of what you mentioned here
probably can :)
*probalby could
Michal Kordas
@mkordas
Nov 09 2015 21:49
that's fine, just description about next steps was missing
Łukasz Nowak
@nowaklukasz
Nov 09 2015 21:51
Comment updated
Michal Kordas
@mkordas
Nov 09 2015 22:19
thanks, PR looks really nice
Łukasz Nowak
@nowaklukasz
Nov 09 2015 22:43
TY for review