Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Paweł Lipski
    @PawelLipski
    so it's a problem with setup.py itself being python2-compatible but not python3 compatible
    so as for now... maybe suggest running python2 setup.py install (also in the --user and sudo versions) explicitly?
    Paweł Suder
    @pasuder
    Due to fact that support for python2 will be ended at Jan 1st, 2020 (in less than 11 months) (link: https://pythonclock.org/) I am suggesting to no stick to python2 and prioritize VirtusLab/git-machete#35 ;) IMO adding to README information about support for python2 and linking task will be good enough.
    Paweł Suder
    @pasuder
    Hello, how is it going? Do we do some planing?
    Paweł Lipski
    @PawelLipski
    Okay, I'll migrate to python 3 soon :)
    Sorry for lag, was vacationing :palm_tree:
    I'll send you the patch with the updates I did recently tomorrow
    Paweł Suder
    @pasuder
    Ok, great :)
    Paweł Lipski
    @PawelLipski
    Merged, finally :) thanks @pasuder for your effort... and patience for my nitpicks ;)
    Paweł Lipski
    @PawelLipski
    @Deloryn #13 is finally merged to master, feel free to reapply your #38 fixes
    Paweł Suder
    @pasuder
    @PawelLipski np. ;)
    Paweł Lipski
    @PawelLipski
    Hi @pasuder, pls accept the collaborator invite, there's VirtusLab/git-machete#40 waiting but I apparently can't add you as an reviewer before you're a collaborator ;)
    Paweł Suder
    @pasuder
    @PawelLipski yeap, I will do, I will try to do it tomorrow on Sat.
    Paweł Lipski
    @PawelLipski
    @pasuder fixes to VirtusLab/git-machete#41 applied :)
    actually, isn't 80 chars (and not 120) the Python standard, as defined by PEP-8?
    (TTBT it feels slightly too few... but I won't question the PEPs ;) )
    Paweł Suder
    @pasuder
    Yeap @PawelLipski 80 chars is PEP8 standard. 120 is a commonly used ;)
    Paweł Lipski
    @PawelLipski
    :thumbsup:
    pls approve PR #41 if all looks ok... also if you could take a look at PR #40 (custom hooks)
    :)
    Paweł Suder
    @pasuder
    OK, I will try today.
    Paweł Suder
    @pasuder
    Sorry, I was busy a bit. Next week I am off completely. On Monday I will try.
    Paweł Lipski
    @PawelLipski
    Ok, np :)
    Monday 25th, right?
    Paweł Lipski
    @PawelLipski
    Well... the queue of the features waiting for release is quite long, I feel I should go on ;)
    Paweł Suder
    @pasuder
    Hello hello, I finally came back from vacation and other things.
    Let me do review.
    Paweł Lipski
    @PawelLipski
    Ok, thanks :)
    Paweł Lipski
    @PawelLipski
    @pasuder finally applied your comments, sorry for this superlong lag, was busy preparing a git internals meetup (https://slides.com/plipski/git-internals/live#/) ;)
    Paweł Suder
    @pasuder
    @PawelLipski not a problem, I was busy too.
    Paweł Lipski
    @PawelLipski
    pls drop an approve on #41 :)
    Paweł Suder
    @pasuder
    Done @PawelLipski
    Paweł Suder
    @pasuder
    @PawelLipski done for VirtusLab/git-machete#50
    Ilaï Deutel
    @ilai-deutel
    Hi! I've created a git-machete package in the Arch Linux User Repository (https://aur.archlinux.org/packages/git-machete/), to make it easier for Arch Linux users to install and update the tool.
    Let me know if you have comments or questions :)
    Paweł Lipski
    @PawelLipski
    wow, thanks!
    will take a look in the weekend :)
    Paweł Lipski
    @PawelLipski
    @ilai-deutel a couple things:
    Paweł Lipski
    @PawelLipski
    1) pls take a look if a mention in README like this is sufficient: VirtusLab/git-machete#52
    2) is this package meant to make bash/zsh completion instantly available? I think you still need to perform the steps described in https://github.com/VirtusLab/git-machete/wiki, right? even though there's an Install bash and zsh completions section in PKGBUILD
    3) FYI, there's an already approved change that makes git-machete runnable under both Python 2 and Python 3 (#50)... this will bump version to 2.10.0, and then I think the dependency in PKGBUILD can be safely changed to Python 3:)
    Ilaï Deutel
    @ilai-deutel
    1) Done!
    2) The bash completion works out of the box; for zsh completion to be automatically loaded, I think you need this change: VirtusLab/git-machete#53
    3) I saw that, it's great! Looking forward to it
    Paweł Lipski
    @PawelLipski
    Just replied on both #52 and #53 :)
    Also, if you could consider updating the description of the AUR package to what's in the repo's description itself (Probably the sharpest git repository organizer & rebase workflow automation tool you've ever seen)... sounds sexier IMO ;)
    can be with next release (2.10.0) or so ofc :)
    Ilaï Deutel
    @ilai-deutel
    Sounds good!
    Paweł Lipski
    @PawelLipski
    Hi @ilai-deutel, Python3-ready 2.10.0 has been released, if you could update the AUR package... and also update the package description (see message above) :)
    Ilaï Deutel
    @ilai-deutel
    Done :)
    Paweł Lipski
    @PawelLipski
    Hi @ilai-deutel ... do you think there's a reasonable way to wire up the AUR package release to Travis pipeline without me nagging you constantly? ;)
    Ilaï Deutel
    @ilai-deutel
    Updated!
    The update process can be partially automated, but not completely. I always run manual tests to check if the package works well with the newest ArchLinux dependencies (e.g. Python 3.8, git 2.24). I also run package checks with Namcap.
    I am supposed to be notified of the releases on the repo, but for some reason Github isn't notifying me (it works on other repos). I'll change my notification settings to "watching everything" and see if it works better.
    You could also flag the package as out-of-date directly on the AUR, I'm assuming it will notify me :)
    Paweł Lipski
    @PawelLipski
    Ok, thanks :) I'd be also grateful if you could promote the project around your team/organization :)
    Paweł Lipski
    @PawelLipski
    Hi @ilai-deutel, I flagged the package... also if you could update the package description this time as on github Probably the sharpest git repository organizer & rebase/merge workflow automation tool you've ever seen - the "merge" part is new
    Ilaï Deutel
    @ilai-deutel
    :thumbsup: