Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:06
    codecov-io commented #753
  • 00:06
    charmander synchronize #753
  • 00:00
    sl1-1 synchronize #753
  • Feb 23 23:55
    charmander closed #752
  • Feb 23 23:55

    charmander on master

    replace most uses of define.err… cleanup unused imports Replace WeasylError('permission… and 3 more (compare)

  • Feb 23 23:52
    codecov-io commented #753
  • Feb 23 23:52
    codecov-io commented #753
  • Feb 23 23:52
    sl1-1 synchronize #753
  • Feb 23 23:48
    codecov-io commented #752
  • Feb 23 23:47
    codecov-io commented #752
  • Feb 23 23:46
    lgtm-com[bot] commented #688
  • Feb 23 23:46
    codecov-io commented #753
  • Feb 23 23:46
    sl1-1 synchronize #753
  • Feb 23 23:42
    charmander labeled #752
  • Feb 23 23:42
    codecov-io commented #752
  • Feb 23 23:42
    charmander synchronize #752
  • Feb 23 23:40
    codecov-io commented #688
  • Feb 23 23:40
    sl1-1 synchronize #688
  • Feb 23 22:33
    lgtm-com[bot] commented #688
  • Feb 23 22:26
    codecov-io commented #688
Charmander
@charmander
@kfkitsune Hopefully fixed!
Kyra
@kfkitsune
@charmander It looks good to me; did you need to re-order the tweens? I thought I saw (though now deleted) that you thought the tweens were mis-ordered for timing purposes?
Charmander
@charmander
I thought db_timer was too late in the tween chain to measure everything, but nothing before it makes queries :P
The reordering of query_debug was necessary to catch the session query
(but it probably would have been enough just to move it up one spot… still, it’s fine where it is. the ordering between most of those non-querying tweens doesn’t matter much.)
@kfkitsune Thanks for the review!
Kyra
@kfkitsune
Most welcome! Nice improvement adding the function timings. =D
Charmander
@charmander
it seems that pillow thumbnailing doesn’t preserve timestamps
maybe the ones I saw were both reuploads somehow…?
(or the reupload form submitted twice)
Charmander
@charmander
@sl1-1 In the mood to work on Pillow again? :)
sl1-1
@sl1-1
I can take a look at it when I get home, ya. What's up?
sl1-1
@sl1-1
Well... I think that pull request is at least somewhat readable? XD
Charmander
@charmander
Yep, it’s picking up the diff more often than I expected!
@sl1-1 Is it possible to separate the WeasylError changes into another pull request that can be merged earlier?
They don’t depend on Jinja, right?
sl1-1
@sl1-1
I spent some time in my IDE trying to get everything to line up, so the diffs wouldn't be nuts!
You mean the raising the error instead of calling d.errorpage?
Charmander
@charmander
appreciated =D
@sl1-1 yep!
sl1-1
@sl1-1
I should be able to do that, ya
will poke around on it in a bit
sl1-1
@sl1-1
Done? MAybe probably
Charmander
@charmander
Nice! I’ll take a look
sl1-1
@sl1-1
Also, just doing some playing around, but I think Pillow strips PNG/JPEG metadata on save, unless you explicitly include it
Charmander
@charmander

maybe the ones I saw were both reuploads somehow…?

yeah, I saw that too when writing a test and thought it might be this ^

reuploads still use the old thumbnailing
@sl1-1 For #753, the removal of unused things is nice. I’d rather not include the wrapping, tuple reformatting, or renaming, though.
sl1-1
@sl1-1
I can also verify that it doesn't write a tIME section for pngs
which renaming? the variables that shadow builtins, or the protected functions, or both?
Charmander
@charmander
both
sl1-1
@sl1-1
does reverting with git actually work properly? or do I need to edit history and force push? (Not a git expert :) )
Charmander
@charmander
I’m not sure what you mean by reverting with git, but anything that produces the right diff in the end will work well enough. :)
oh, they were separated enough for git revert? sure.
Still have cid and iteritems though
and format
and _filter, _type
sl1-1
@sl1-1
ya, was just seeing if that worked
That should in theory do it?
Charmander
@charmander
Thanks!

If the key or section is missing, or the value isn't a valid boolean, returns value, default False.

=|

sl1-1
@sl1-1
?
Charmander
@charmander
@sl1-1 ah, the print too please
@sl1-1 Returning False when the value is present but not a valid boolean seems unnecessarily error-prone
sl1-1
@sl1-1
print should be gone
ya, though, I was actually assuming that it used the normal python logic for determining if it's true or false, so I was wondering if it the issue was that it would make something a Boolean, or if configparser would raise an error, and after a quick google, I can see it raises a ValueError.
sl1-1
@sl1-1
I guess a good solution would be to load the config file at startup, and validate it, instead. That way you don't get a exception at some weird time due to a misconfiguration
Charmander
@charmander
Oh, good point
I didn’t even realize that would happen :D
sl1-1
@sl1-1
I clearly misconfigure stuff more than you do! :P