These are chat archives for WebDevStudios/CMB2

25th
Sep 2015
Ronald Huereca
@ronalfy
Sep 25 2015 01:15
@sc0ttkclark got radio button to work. On some of these controls, we just have to manually output. Maybe get @jtsternberg to clean up.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 04:26
ok cool
Ronald Huereca
@ronalfy
Sep 25 2015 04:46
@sc0ttkclark https://github.com/ronalfy/CMB2/tree/customizer has code and output tests
Manual outputting seems the way to go here for a lot of these
I'll try to get the rest tomorrow or this weekend sometime. But super excited.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 04:48
cool, looks like we're nearly there
Ronald Huereca
@ronalfy
Sep 25 2015 04:48
Logging off. Good night.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 04:48
night
Ronald Huereca
@ronalfy
Sep 25 2015 04:48
Yeah, need to figure out the timer thing.
Have to load the scripts using customizer enqueue since the body is in an iframe.
Ronald Huereca
@ronalfy
Sep 25 2015 14:55
@sc0ttkclark could you take a peek at something? I need your brain.
My boss has given me one more day to work on this. I asked for two originally, but we're so close.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 15:45
sure
AWESOME!
@ronalfy use my brain
Ronald Huereca
@ronalfy
Sep 25 2015 17:13
@sc0ttkclark I can't get the timer options to work at all. I got the scripts in there, no errors. I can literally take the HTML generated and paste it into the front end with the same scripts, and it works. Sample code in my readme. https://github.com/ronalfy/cmb2/tree/customizer
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 17:21
where's your code to enqueue?
oh i see now
Ronald Huereca
@ronalfy
Sep 25 2015 17:24
it's in bootstrap. I had to run it at a low priority
to get customizer to work properly
I'm going to work on the multi-check tools. But have at it. The timer just doesn't appear.
Ronald Huereca
@ronalfy
Sep 25 2015 17:27
Yeah, that's what I used
the scripts are all in there properly
Just nothing displays.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 17:30
hmm, so script loads to page, but you can't get it to actually work on the time field itself?
Ronald Huereca
@ronalfy
Sep 25 2015 17:37
yah if I load the scripts on the front
I'm honestly going to do a pull request after I this multicheck to work and I can shelve the time pieces for later.
Ronald Huereca
@ronalfy
Sep 25 2015 18:18
@sc0ttkclark here ya go WebDevStudios/CMB2#468
if you look at CMB-Customizer, it has all the required and mapping needed
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 18:24
can we pull our the bootstrap stuff into the area before we run the action you're hooking into there?
pull out*
i'll go through the code and do format cleanup and general review too
Ronald Huereca
@ronalfy
Sep 25 2015 18:24
No, the bootstrap needs to be there or it needs to happen early
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 18:25
why call add_action( 'cmb2_init', 'cmb2_customizer_init', 1, 1 ); when you could put the code ahead of running cmb2_init itself in CMB2
Ronald Huereca
@ronalfy
Sep 25 2015 18:25
ugh, didn't know that was an option
Do you mind just plowing through those. I am totally brain-spent.
I say either reject the pull request and continue working on mine, or merge into customizer branch and we can continue working on it there.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 18:31
don't need to reject the PR, can be modified and PR automatically updates
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 19:11
@ronalfy to verify, you're done with the customizer integration -- excluding repeatable / group field functionality right? i can go through and tweak formatting, put the bootstrap loading before cmb2_init, etc?
Ronald Huereca
@ronalfy
Sep 25 2015 19:13
@sc0ttkclark yes. I think I commented out which fields I was unable to do
@sc0ttkclark yeah, I did it in the pull request
Can't get to work: text_time, select_timezone, text_date_timestamp, text_datetime_timestamp, text_datetime_timestamp_timezone , hidden, wysiwyg
Sample code is in readme.md
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 19:14
ok cool
Ronald Huereca
@ronalfy
Sep 25 2015 19:14
I swore I did it somewhere lol
@sc0ttkclark you are def welcome to school me.
I can probably get WYSIWYG, but not sure the editor is the place for that
customizer .. whatever
but everything should be in my readme.md
@sc0ttkclark I'm not the lead, but I think we can sneak in customizer as a beta feature and improve as needed.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 19:19
yeah, once i get done with my part, i think we'll be in a place we can get people to help test and figure out the remaining non-repeatable/group field types
Ronald Huereca
@ronalfy
Sep 25 2015 19:19
Cool. My brain is officially fried. I'm sure you can imaghine.
Scott Kingsley Clark
@sc0ttkclark
Sep 25 2015 19:20
lol yep
Ronald Huereca
@ronalfy
Sep 25 2015 19:20
I keep thinking to the Kill Bill line: you didn't think it would be that easy, did you?
"Ya know, for a second there, I kinda did."
Logging off. You gents have a good weekend. @sc0ttkclark if you need me, @ me because I get these cool notification emails :D