Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Justin Sternberg
@jtsternberg
ah ok
there's the code i'm using right now as a whole
in both cases, the sub groups don't output their fields
Justin Sternberg
@jtsternberg
ah yah, I can already see some issues (requiring core-refactoring) with that.
Scott Kingsley Clark
@sc0ttkclark
well i'll look into the code and see what i can help out with
we definitely want at least 2-3 levels (our admin ui will limit to 2 or 3 levels deep (group of fields in a group)
basically, adding a group field, it adds to the fields array, but only adds one level deep in the nested array.. It'll need to be updated to do more recursively then explicitly
recursion.. always a joy :D
Scott Kingsley Clark
@sc0ttkclark
ah i see
yes, that looks fantastical
lol
i'll have a ponder
Justin Sternberg
@jtsternberg
My brain took a beating to get it to work the way it currently works... Can't imagine the cerebral abuse required to get it to work recursively while not breaking back-compat. lol
Scott Kingsley Clark
@sc0ttkclark
no one is using the object vars directly right?
Justin Sternberg
@jtsternberg
which ones?
Scott Kingsley Clark
@sc0ttkclark
CMB2 class properties
they're only using methods, right?
Justin Sternberg
@jtsternberg
well.. I don't know that that's a given
Scott Kingsley Clark
@sc0ttkclark
i'm not worried about supporting the old flat arrays for deep groups
(cmb2_meta_groups or whatever filter it was)
Justin Sternberg
@jtsternberg
but, we can append the magic getter to grab them and provide updated ones if needed: https://github.com/WebDevStudios/CMB2/blob/master/includes/CMB2.php#L999-L1010
Scott Kingsley Clark
@sc0ttkclark
yaeh
thx for taking some moments today with me, appreciate it
Justin Sternberg
@jtsternberg
no problem, sorry I don't have more of them
Scott Kingsley Clark
@sc0ttkclark
lol, know what you mean
i'm spread thin
Scott Kingsley Clark
@sc0ttkclark
have some ideas i want to kick around this week with you about group fields storage and the field arrays
Justin Sternberg
@jtsternberg
Ok sounds good
Scott Kingsley Clark
@sc0ttkclark
just lemme know what day / time works best for you, just chatting here, but don't want to lose my train of thought with the passive chats for this part
Scott Kingsley Clark
@sc0ttkclark
i'll be busy most wednesday, but available today / thurs / fri this week
Scott Kingsley Clark
@sc0ttkclark
new version, great!
Justin Sternberg
@jtsternberg
Yah?
Scott Kingsley Clark
@sc0ttkclark
well in general, the changelog looked good, but you mentioned you were working on wysiwyg in group fields for the an upcoming version too
i have limited availability this morning to chat, and maybe later this afternoon, but i'll be out around 1-4pm central
José Carlos Chávez
@jcchavezs
Hi! I just added my plugin CMB2 Conditionals for relate fields inside a CMB2 metabox. You can take a look at it at https://github.com/jcchavezs/cmb2-conditionals.
Scott Kingsley Clark
@sc0ttkclark
@jcchavezs hey, looks cool, so it adds required values?
looks like it's all DOM + JS, right? there's no way to be sure someone doesn't hack the DOM though and bypass the requirement or the required value, there's no PHP validation -- also heredoc+inline JS vs a .js file?
Scott Kingsley Clark
@sc0ttkclark
@jtsternberg you have some time to chat this week?
Justin Sternberg
@jtsternberg
@sc0ttkclark yah, I think I can carve out some time. When would like to do it?
Scott Kingsley Clark
@sc0ttkclark
as soon as you're ready :)
Scott Kingsley Clark
@sc0ttkclark
@jtsternberg you think you could put your name on this list for CMB2? i'll help you integrate -- sc0ttkclark/wordpress-fields-api#21
Scott Kingsley Clark
@sc0ttkclark
also this looks cool, once it gets solid i'm going to write the CMB2 / Pods integrations for it -- https://github.com/brentjett/wp-theme-configuration
Scott Kingsley Clark
@sc0ttkclark
awesome @jtsternberg
when you want to carve some time out for me/pods so we can figure out a plan of action for group fields