just kludged to add it to it's own free form array that I tack back on with array_merge()
just there for back compat or I wouldn't have thought of it
how about back-compat for the prop method?
passes all tests, including some I added specifically for prop
since that's how the arbitrary values are retrieved currently
ah ok, you still have the prop method. should have looked
reworked to use the "new way"
everything internally in cmb2 should be using the getters/setters now
and helper functions too
outside code doesn't yet, but the back compat bits should be catching nearly all that
yah, makes sense. so my biggest opposition to the individual setters/getters is the non-DRY redundancy throughout this file. Just eats at me. :) not necessarily a good enough argument to remove, but...
so, ultimately, it's "doable"
explicit getters and setters are the one time I come off my "less code is always better" stump
or one of the rare times
but in the end, it's usually not much less code overall and the IDE can generate the skeletons