Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Justin Sternberg
@jtsternberg
yessir, a few
PG Lewis
@pglewis
I'd like to take a few minutes to talk about how we want to move forward before tomorrow afternoon, if possible
friend's bachelor party tomorrow evening so I'll likely be switching gears from code-focus to whiskey focus for a night
Justin Sternberg
@jtsternberg
ok, let's talk
PG Lewis
@pglewis
what are your thoughts on the current refactor? Is this something we could consider continuing that direction?
Justin Sternberg
@jtsternberg
yah, so far so good, though we still have to get add_field_group working, right?
PG Lewis
@pglewis
add_field_group?
Justin Sternberg
@jtsternberg
or add_group_field.. whatever lol
PG Lewis
@pglewis
add_group_field should be working except for saving and/or loading
the only thing broken with groups in general afaik
display should be working
all other tests, and the metabox examples in the example functions should /display/ right, or close to right
minus what I haven't quite tracked down yet with the field array -> field objects conversion
group saving may need some hammering with the new data structure yet, I just haven't gotten that far yet
I'm not personally using add_group_field in my nesting example, but that doesn't mean I pulled it out or that it doesn't work
just wasn't a necessary thing to do the nesting since add_field() now works splendidly with group fields as well as a metabox
PG Lewis
@pglewis
but if you setup the example functions in the repo, you should see the group field on a page like always
via add_group_field
just won't load/save
and I haven't really put any focus into the load/save yet because I was still cleaning up tests
iow: that was expected
since the refactor made it this far and is as close as it is to passing tests, I'm confident the back-compat part is doable
Justin Sternberg
@jtsternberg
Hmm I switched to your branch and my test group metabox disappeared entirely
PG Lewis
@pglewis
are you using the example from the repo?
Justin Sternberg
@jtsternberg
For the most part
PG Lewis
@pglewis
if it's a different test metabox than what I was testing I'd have to look at it and see
Justin Sternberg
@jtsternberg
I didn't dig in too deep, so I'll see if I did something weird
PG Lewis
@pglewis
I'm looking on a non-front-page page
and seeing the group mb
can add a new entry, just won't save
(or may be saving and won't load)
Justin Sternberg
@jtsternberg
so maybe it's because I have previously saved values?
PG Lewis
@pglewis
front page also appears to load right
user mb, options
all show for me
if I ignore data, it works perfectly lol
Justin Sternberg
@jtsternberg
ha ha nice
PG Lewis
@pglewis
(actually probably a few glitches in the display due to the couple remaining broken tests)
Justin Sternberg
@jtsternberg
the biggest frustration with groups is the name/id attributes
PG Lewis
@pglewis
but I'd like to verify you're seeing that as well
Justin Sternberg
@jtsternberg
But I know @sc0ttkclark has talked about doing something more javascripty so we too many inputs
PG Lewis
@pglewis
I can send you my function.php if that helps
though if you're seeing something broken I haven't come across, I'd like to get a copy of that
Justin Sternberg
@jtsternberg
let me look again
PG Lewis
@pglewis
pretend I have a magic wand I can wave to fix loading and saving :)
Justin Sternberg
@jtsternberg
I merged my trunk in.. maybe that has something to do with it? (I doubt it)
want me to push mine?
PG Lewis
@pglewis
I don't think you can merge the trunk changes in directly
I would revert those and run off the branch as is
confuses the matter